RE: Permutations

2014-09-05 Thread Finan, Sean
> We also had issues in cTAKES 2.5. > Here is the patch for 2.5. Before I got the patch to 3.0 Sean made his > changes. Thanks for verifying, Sean From: Kim Ebert [kim.eb...@perfectsearchcorp.com] Sent: Friday, September 05, 2014 12:28 PM To: dev@ctakes.a

RE: Permutations

2014-09-05 Thread Finan, Sean
Hi Kim, Pei, I don't think that I changed anything to which Kim is referring, just a couple of other things that happen to be in the same segment. From the attached it looks like Kim's change is to copy a list and sort the copy, while mine were moving the sort from an inner to outer loop. At

Re: Permutations

2014-09-05 Thread Kim Ebert
Hi Pei and Sean, Sean, any thoughts about this would be helpful. We also had issues in cTAKES 2.5. Here is the patch for 2.5. Before I got the patch to 3.0 Sean made his changes. === modified file 'src/edu/mayo/bmi/lookup/algorithms/FirstTokenPermutationImpl.java' --- src/edu/mayo/bmi/lookup/al

Re: Permutations

2014-09-05 Thread Pei Chen
Hi Kim, Thanks for pointing that out. https://issues.apache.org/jira/browse/CTAKES-310 has been opened for this. If you commit the changes, we can see if we can include in the 3.2.1 patch release. I was looking at the changelist for this file, and it may look like some of these optimizations may ha