[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075935#comment-14075935
]
Cameron McKenzie commented on CURATOR-126:
--
I've had a bit of a look at this and
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076204#comment-14076204
]
Jordan Zimmerman commented on CURATOR-126:
--
I think the above change is a good
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076460#comment-14076460
]
Jordan Zimmerman commented on CURATOR-126:
--
An Executor is just a thread as
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076457#comment-14076457
]
Scott Blum commented on CURATOR-126:
Also, versions of Java 1.8 have a bug in
GitHub user dragonsinth opened a pull request:
https://github.com/apache/curator/pull/22
CURATOR-125: Fix race condition in CuratorFrameworkImpl.close()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragonsinth/curator
Github user dragonsinth commented on the pull request:
https://github.com/apache/curator/pull/22#issuecomment-50380674
oops wrong number
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user dragonsinth opened a pull request:
https://github.com/apache/curator/pull/23
CURATOR-126: Fix race condition in CuratorFrameworkImpl.close()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragonsinth/curator
Github user dragonsinth closed the pull request at:
https://github.com/apache/curator/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076567#comment-14076567
]
ASF GitHub Bot commented on CURATOR-125:
Github user dragonsinth commented on the
[
https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076565#comment-14076565
]
ASF GitHub Bot commented on CURATOR-125:
GitHub user dragonsinth opened a pull
[
https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076573#comment-14076573
]
Scott Blum commented on CURATOR-125:
Please delete the above 3 comments (and this
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076576#comment-14076576
]
Scott Blum commented on CURATOR-126:
You're right, Thread.interrupt(), Thread.join()
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15483096
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -722,39 +725,35 @@ public void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076603#comment-14076603
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15483196
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -770,9 +769,8 @@ private void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076610#comment-14076610
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15483300
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -300,12 +295,20 @@ public Void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076617#comment-14076617
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15485742
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -770,9 +769,8 @@ private void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076696#comment-14076696
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on a diff
[
https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated CURATOR-125:
-
Comment: was deleted
(was: Github user dragonsinth commented on the pull request:
[
https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated CURATOR-125:
-
Comment: was deleted
(was: Please delete the above 3 comments (and this one) opened a
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15485966
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -722,39 +725,35 @@ public void
[
https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated CURATOR-125:
-
Comment: was deleted
(was: GitHub user dragonsinth opened a pull request:
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076701#comment-14076701
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15486219
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -770,9 +769,8 @@ private void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076709#comment-14076709
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15486333
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -770,9 +769,8 @@ private void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076715#comment-14076715
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on a diff
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076718#comment-14076718
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on a diff
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15487030
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -74,7 +71,7 @@
private final
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15487087
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -300,12 +295,20 @@ public Void
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076736#comment-14076736
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076733#comment-14076733
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076743#comment-14076743
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on a diff
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15487723
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -74,7 +71,7 @@
private final
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15490243
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -74,7 +71,7 @@
private final
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076839#comment-14076839
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076842#comment-14076842
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on a diff
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15491274
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
---
@@ -239,6 +241,16 @@ public Builder
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076884#comment-14076884
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on a diff
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076878#comment-14076878
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on a
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated CURATOR-126:
-
Fix Version/s: 2.6.1
IllegalStateException in performBackgroundOperation during close
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman reassigned CURATOR-126:
Assignee: Jordan Zimmerman (was: Cameron McKenzie)
IllegalStateException in
FYI
There will be some new APIs in the next release (CURATOR-126 for example) that
suggests making this 2.7.0 instead of 2.6.1
-JZ
Is it possible (or desirable?) to split some of the bug fixes into a 2.6.1
before adding the APIs for 2.7.0?
On Mon, Jul 28, 2014 at 4:34 PM, Jordan Zimmerman
jor...@jordanzimmerman.com wrote:
FYI
There will be some new APIs in the next release (CURATOR-126 for example)
that suggests
How would we manage this with our current branching structure?
On Tue, Jul 29, 2014 at 7:36 AM, Mike Drob mad...@cloudera.com wrote:
Is it possible (or desirable?) to split some of the bug fixes into a 2.6.1
before adding the APIs for 2.7.0?
On Mon, Jul 28, 2014 at 4:34 PM, Jordan
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50406296
Yeah - please do. Canât hurt.
From:Â cammckenzie notificati...@github.com
Reply:Â apache/curator re...@reply.github.com
Date:Â July 28, 2014 at 4:41:57
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076932#comment-14076932
]
ASF GitHub Bot commented on CURATOR-126:
Github user cammckenzie commented on the
That’s a good point. I think, we’d have master just be whatever the next
release will be. Then, we could have a 2.7.0 branch that would become master
after 2.6.1 is released. OK?
-JZ
From: Cameron McKenzie mckenzie@gmail.com
Reply: dev@curator.apache.org dev@curator.apache.org
Date: July
might make more sense to create a 2.6.1 branch from the 2.6.0 release tag
and cherry pick all of the relevant commits in. leave master as pointing to
2.7.0. if you have both branches active at once then commit to master and
continue to cherry-pick as appropriate. or commit to the branch and merge
I’m not a fan of cherry picking, etc. I’ve seen too many mistakes made.
Officially, Curator follows Github Flow:
http://scottchacon.com/2011/08/31/github-flow.html - which boils down to have a
master and lots of other branches. So, maybe even having a 2.7.0 branch would
be a mistake. Features
Github user dragonsinth commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50407804
That would be great. If you can send me a commit or diff, I'd be happy to
play with trying to test it programmatically.
---
If your project is set up for it, you
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076966#comment-14076966
]
ASF GitHub Bot commented on CURATOR-126:
Github user dragonsinth commented on the
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50416483
I have pushed a unit test up onto the CURATOR-126 branch. Have a play with
it, I still seem to be getting the error logged when running against the fix.
Could be
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077122#comment-14077122
]
ASF GitHub Bot commented on CURATOR-126:
Github user cammckenzie commented on the
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077164#comment-14077164
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on the
Github user dragonsinth commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50418934
Where are the commits? I did a git remote update on both my fork and
apache and couldn't find them.
---
If your project is set up for it, you can reply to this
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50419008
They're there for me, I just pulled off the apache master (CURATOR-126
branch). The changes look good to me Jordan, I was trying to avoid changing the
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50419120
Sorry Scott - it looks like CURATOR-126 hasnât syncâd yet to the Github
repo. The whole Github sync think is a lot of black magic. It is, however,
here:Â
[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077168#comment-14077168
]
ASF GitHub Bot commented on CURATOR-126:
Github user Randgalt commented on the
Github user dragonsinth commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50420280
Sweet, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Scott Blum created CURATOR-128:
--
Summary: There is no namespace-safe way to refer to the root node
Key: CURATOR-128
URL: https://issues.apache.org/jira/browse/CURATOR-128
Project: Apache Curator
[
https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077241#comment-14077241
]
Cameron McKenzie commented on CURATOR-128:
--
I think that it would be preferable
[
https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077258#comment-14077258
]
Jordan Zimmerman commented on CURATOR-128:
--
The problem in ZKPaths.makePath() is
[
https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077388#comment-14077388
]
Scott Blum commented on CURATOR-128:
It couldn't be made more lenient?
e.g.
/ +
[
https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077398#comment-14077398
]
Cameron McKenzie commented on CURATOR-128:
--
This sounds ok to me. It assumes
67 matches
Mail list logo
