[jira] [Commented] (CURATOR-131) Should not modify collection while iterating over it

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092482#comment-14092482 ] ASF GitHub Bot commented on CURATOR-131: Github user cammckenzie commented on the

[jira] [Commented] (CURATOR-131) Should not modify collection while iterating over it

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092499#comment-14092499 ] ASF GitHub Bot commented on CURATOR-131: Github user asfgit closed the pull

[jira] [Closed] (CURATOR-131) Should not modify collection while iterating over it

2014-08-11 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cameron McKenzie closed CURATOR-131. Resolution: Fixed Should not modify collection while iterating over it

Build failed in Jenkins: Curator ยป Curator Framework #891

2014-08-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/Curator/org.apache.curator$curator-framework/891/ -- [INFO] [INFO] [INFO]

Build failed in Jenkins: Curator #891

2014-08-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/Curator/891/changes Changes: [mdrob] CURATOR-131 use iterator.remove instead of foreach -- [...truncated 95 lines...] [JENKINS] Recording test results [INFO] [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092777#comment-14092777 ] ASF GitHub Bot commented on CURATOR-79: --- Github user madrob commented on a diff in

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16053998 --- Diff: curator-recipes/src/test/java/org/apache/curator/framework/recipes/locks/TestInterProcessMutex.java --- @@ -107,4 +113,70 @@ public Void call()

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092779#comment-14092779 ] ASF GitHub Bot commented on CURATOR-79: --- Github user madrob commented on a diff in

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092784#comment-14092784 ] ASF GitHub Bot commented on CURATOR-79: --- Github user Randgalt commented on a diff in

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16054205 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092795#comment-14092795 ] ASF GitHub Bot commented on CURATOR-79: --- Github user madrob commented on a diff in

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16055156 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092805#comment-14092805 ] ASF GitHub Bot commented on CURATOR-79: --- Github user Randgalt commented on a diff in

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16057954 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092856#comment-14092856 ] ASF GitHub Bot commented on CURATOR-79: --- Github user madrob commented on a diff in

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093063#comment-14093063 ] ASF GitHub Bot commented on CURATOR-79: --- Github user ortschun commented on a diff in

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093228#comment-14093228 ] Mike Drob commented on CURATOR-136: --- So in this particular case, it's hanging in

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093232#comment-14093232 ] Mike Drob commented on CURATOR-136: --- Part of the problem is that {{start()}} takes the

[jira] [Created] (CURATOR-139) Add slf4j logging implementation to test scope

2014-08-11 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-139: - Summary: Add slf4j logging implementation to test scope Key: CURATOR-139 URL: https://issues.apache.org/jira/browse/CURATOR-139 Project: Apache Curator Issue

[GitHub] curator pull request: CURATOR-139 Add slf4j-log4j test bindings

2014-08-11 Thread madrob
GitHub user madrob opened a pull request: https://github.com/apache/curator/pull/36 CURATOR-139 Add slf4j-log4j test bindings Add test bindings so that log output is preserved. Makes it easier to debug jenkins and failed unit tests, which not appreciably increasing the time

[jira] [Commented] (CURATOR-139) Add slf4j logging implementation to test scope

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093335#comment-14093335 ] ASF GitHub Bot commented on CURATOR-139: GitHub user madrob opened a pull

[jira] [Commented] (CURATOR-139) Add slf4j logging implementation to test scope

2014-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093340#comment-14093340 ] Mike Drob commented on CURATOR-139: --- The log output was ~6M, which doesn't strike me as

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16083287 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16083310 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093388#comment-14093388 ] ASF GitHub Bot commented on CURATOR-79: --- Github user cammckenzie commented on a diff

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093389#comment-14093389 ] ASF GitHub Bot commented on CURATOR-79: --- Github user cammckenzie commented on a diff

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16083651 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093396#comment-14093396 ] ASF GitHub Bot commented on CURATOR-79: --- Github user Randgalt commented on a diff in

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-11 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/35#discussion_r16083843 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -469,6 +469,26 @@ private String

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093405#comment-14093405 ] ASF GitHub Bot commented on CURATOR-79: --- Github user cammckenzie commented on a diff

[jira] [Commented] (CURATOR-134) Curator sends a connection LOST event before sessionTimeout

2014-08-11 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093689#comment-14093689 ] Cameron McKenzie commented on CURATOR-134: -- I've had a look into this and can