[jira] [Work logged] (CURATOR-537) Expose ourPath in LeaderLatch readonly

2022-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-537?focusedWorklogId=762076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762076 ] ASF GitHub Bot logged work on CURATOR-537: -- Author: ASF GitHub Bot

[GitHub] [curator] tisonkun commented on pull request #414: CURATOR-537: Fix effective path can be used as a fencing token of LeaderLatch

2022-04-25 Thread GitBox
tisonkun commented on PR #414: URL: https://github.com/apache/curator/pull/414#issuecomment-1109203940 @cammckenzie OK that should be fine to leave the current method as is. Let me push one more commit and modify the method document, -- This is an automated message from the Apache Git Ser

[jira] [Work logged] (CURATOR-537) Expose ourPath in LeaderLatch readonly

2022-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-537?focusedWorklogId=762074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762074 ] ASF GitHub Bot logged work on CURATOR-537: -- Author: ASF GitHub Bot

[GitHub] [curator] cammckenzie commented on pull request #414: CURATOR-537: Fix effective path can be used as a fencing token of LeaderLatch

2022-04-25 Thread GitBox
cammckenzie commented on PR #414: URL: https://github.com/apache/curator/pull/414#issuecomment-1109199154 @tisonkun The change looks fine to me. My only concern is that we're modifying the name / function of a public API. Perhaps we should leave the existing implementation of getOurPath and