[GitHub] curator pull request: CURATOR-71 do not log-and-throw

Github user madrob commented on the pull request: https://github.com/apache/curator/pull/31#issuecomment-51060899 The only ConnectionStateListener that I can find is a 30 line interface in curator-framework. Can you be more specific with where you're looking, I'm having some trouble

[jira] [Commented] (CURATOR-71) Error message in StandardLockInternalsDriver for retryable lock acquire error

[ https://issues.apache.org/jira/browse/CURATOR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084657#comment-14084657 ] ASF GitHub Bot commented on CURATOR-71: --- Github user madrob commented on the pull

[jira] [Commented] (CURATOR-67) Issue with default JSONInstanceSerializer for discovery service builder

[ https://issues.apache.org/jira/browse/CURATOR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084662#comment-14084662 ] ASF GitHub Bot commented on CURATOR-67: --- Github user madrob commented on a diff in

Re: Exception throwing

This is good. How do we get there? On Mon, Aug 4, 2014 at 9:36 AM, Jordan Zimmerman jor...@jordanzimmerman.com wrote: Just protect me from that exception. I agree with this. I’d like to see Curator move to unchecked exceptions everywhere. For “recoverable exceptions”, I’d like to see

Re: Exception throwing

I already have a placeholder version 3.0 in Jira: https://issues.apache.org/jira/browse/CURATOR/fixforversion/12326664/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-summary-panel We could start putting together a Curator 3.0 wish list and iterate. -JZ From: Mike Drob

[GitHub] curator pull request: CURATOR-67 defer creation of serializer

Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/30#discussion_r15782878 --- Diff: curator-x-discovery/src/test/java/org/apache/curator/x/discovery/details/TestServiceDiscoveryBuilder.java --- @@ -0,0 +1,68 @@ +/** +

[GitHub] curator pull request: CURATOR-71 do not log-and-throw

Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/31#issuecomment-51121406 Sorry, org.apache.curator.ConnectionState --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] curator pull request: CURATOR-71 do not log-and-throw

Github user madrob commented on the pull request: https://github.com/apache/curator/pull/31#issuecomment-51126572 Updated the PR to remove the first logging in ConnectionState. I think you're right about leaving the second one in, since it's covered by a boolean flag. --- If your

[jira] [Commented] (CURATOR-71) Error message in StandardLockInternalsDriver for retryable lock acquire error

[ https://issues.apache.org/jira/browse/CURATOR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085409#comment-14085409 ] ASF GitHub Bot commented on CURATOR-71: --- Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-67 defer creation of serializer

Github user madrob commented on the pull request: https://github.com/apache/curator/pull/30#issuecomment-51126770 Updated the javadoc. Left the test in the same package, but I guess I could add docs there too. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (CURATOR-67) Issue with default JSONInstanceSerializer for discovery service builder

[ https://issues.apache.org/jira/browse/CURATOR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085410#comment-14085410 ] ASF GitHub Bot commented on CURATOR-67: --- Github user madrob commented on the pull

CURATOR-33

Any more thoughts on CURATOR-33 (TreeCache) or do we think it’s ready to merge? -Jordan

Re: CURATOR-33

Is the latest merged into the CURATOR-33 branch? I wouldn't mind having a bit of play. The version I looked at last (a week or so ago) looked good. On Tue, Aug 5, 2014 at 12:50 PM, Jordan Zimmerman jor...@jordanzimmerman.com wrote: Any more thoughts on CURATOR-33 (TreeCache) or do we think