[GitHub] curator issue #198: [CURATOR-386] Allow listener to be passed in to Persiste...

2017-04-24 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/curator/pull/198 @akira sorry for the lately reply, I was waiting for another LGTM, the tests look good on my Mac, I'm going to merge the code now. --- If your project is set up for it, you can reply to this

[GitHub] curator issue #198: [CURATOR-386] Allow listener to be passed in to Persiste...

2017-03-27 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/curator/pull/198 Thanks @akira, the new patch looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] curator issue #198: [CURATOR-386] Allow listener to be passed in to Persiste...

2017-03-20 Thread akira
Github user akira commented on the issue: https://github.com/apache/curator/pull/198 @lvfangmin I updated the PR based on your feedback - moved the notifyListeners to the `processBackgroundCallback` callback (I squashed the commit with the previous one). --- If your project is set

[GitHub] curator issue #198: [CURATOR-386] Allow listener to be passed in to Persiste...

2017-02-10 Thread akira
Github user akira commented on the issue: https://github.com/apache/curator/pull/198 Ran tests locally: ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache Curator