[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-28 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/140#issuecomment-202669736 Looks OK to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-28 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/140#issuecomment-202669627 I updated the method doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-28 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/140#issuecomment-202668460 Looks like an OK short fix to me. We probably need to document the new contract (call waitForInitialCreate before calling setData) somewhere? --- If your project

[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-28 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/140#discussion_r57663793 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -317,6 +317,7 @@ public String

[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/140#discussion_r57663645 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -317,6 +317,7 @@ public String

[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup

2016-03-28 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/140#discussion_r57663597 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -317,6 +317,7 @@ public String