[GitHub] [cxf] andymc12 commented on pull request #697: [CXF-8346] TCK Changes for URI and hasEntity checks

2020-10-02 Thread GitBox
andymc12 commented on pull request #697: URL: https://github.com/apache/cxf/pull/697#issuecomment-702902483 @coheigea Sorry about that. I have fixes for the test cases proposed in #703. Can you take a look at them to verify that you and/or @reta are ok with the changes? Thanks

[GitHub] [cxf] andymc12 opened a new pull request #703: Fix systests to account for fix in CXF-8346

2020-10-02 Thread GitBox
andymc12 opened a new pull request #703: URL: https://github.com/apache/cxf/pull/703 This should resolve 4 errors/failures in systests that resulted from runtime changes in CXF-8346 / PR #697. The first change is to remove query parameters. These should need to be "replaced" as

[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
reta commented on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702802689 @coheigea done, https://ci-builds.apache.org/job/CXF/job/CXF-JDK8-PR/ This is an automated message from the Apache Git

[GitHub] [cxf] coheigea edited a comment on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
coheigea edited a comment on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702800627 Yes please do, I've actually made the change already to "Check "Enable Git validated merge support" and "Build pull requests to the repository" in your build config". Not

[GitHub] [cxf] coheigea commented on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
coheigea commented on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702800627 Yes please do, I've actually made the change already to "Check "Enable Git validated merge support" and "Build pull requests to the repository" in your build config". Not sure if

[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
reta commented on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702798069 @coheigea sorry, just realized we had a dedicated build previously just for PRs, I could clone https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, and name it like

[GitHub] [cxf] reta edited a comment on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
reta edited a comment on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702789543 > > > @reta For which CXF build on ci-builds should I make those changes in? @coheigea https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, this is out standard

[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
reta commented on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702789543 > > > @reta For which CXF build on ci-builds should I make those changes in? https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, this is out standard one, we could extend

[GitHub] [cxf] coheigea commented on pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

2020-10-02 Thread GitBox
coheigea commented on pull request #699: URL: https://github.com/apache/cxf/pull/699#issuecomment-702730919 @reta No objections from me, but the build is currently broken - so I'd prefer to make sure all tests are green before merging.

[GitHub] [cxf] coheigea commented on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
coheigea commented on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702729299 @reta For which CXF build on ci-builds should I make those changes in? This is an automated message from the Apache

[GitHub] [cxf] reta commented on pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

2020-10-02 Thread GitBox
reta commented on pull request #699: URL: https://github.com/apache/cxf/pull/699#issuecomment-702721737 @coheigea if you don't mind to take a look, pretty trivial change :) thanks! This is an automated message from the

[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes

2020-10-02 Thread GitBox
reta commented on pull request #698: URL: https://github.com/apache/cxf/pull/698#issuecomment-702721108 > > > @reta I think so - what do I need to change? thanks @coheigea , there are instructions on wiki:

JDK 16 EA build 18 is now available

2020-10-02 Thread Rory O'Donnell
Hi Andriy, OpenJDK 16 Early Access build 18**is now available at http://jdk.java.net/16 * These early-access , open-source builds are provided under the o GNU General Public License, versionĀ 2, with the Classpath Exception . *

[GitHub] [cxf] coheigea commented on pull request #697: [CXF-8346] TCK Changes for URI and hasEntity checks

2020-10-02 Thread GitBox
coheigea commented on pull request #697: URL: https://github.com/apache/cxf/pull/697#issuecomment-702553569 Hi @andymc12 , This change is causing quite a few system test failures, e.g. https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/85/#showFailuresLink Could you take a look?