[GitHub] [cxf] brevilo edited a comment on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

brevilo edited a comment on pull request #805: URL: https://github.com/apache/cxf/pull/805#issuecomment-851044948 Teamwork! Sounds great  @andymc12, feel free to cherry-pick my commit into a PR of your own or not, eventually substituting this PR. I don't care about

[GitHub] [cxf] andymc12 commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

andymc12 commented on pull request #807: URL: https://github.com/apache/cxf/pull/807#issuecomment-851036854 Hi @reta - I'm on holiday today and tomorrow, but I'll take a look when I get back. IIRC, MP Rest Client should take `@Priority` into account, but maybe it isn't tested in the

[GitHub] [cxf] andymc12 commented on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

andymc12 commented on pull request #805: URL: https://github.com/apache/cxf/pull/805#issuecomment-851036627 Hi @brevilo - I'm on holiday today and tomorrow, but I can look at adding a test case when I get back. Thanks! On Sun, May 30, 2021 at 10:56 AM brevilo ***@***.***> wrote:

[GitHub] [cxf] reta commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

reta commented on pull request #807: URL: https://github.com/apache/cxf/pull/807#issuecomment-851032575 @andymc12 mind please taking a look? Also, I've noticed `MicroProfileClientProviderFactory::createComparator` does not take `@Priority` into account for providers, it is not required by

[GitHub] [cxf] brevilo commented on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

brevilo commented on pull request #805: URL: https://github.com/apache/cxf/pull/805#issuecomment-851021421 Thanks for the pointer. Might be the better/quicker way to get the underlying issue resolved. Do you agree? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cxf] reta opened a new pull request #807: CXF-8532: @Priority support for ParamConverterProvider

reta opened a new pull request #807: URL: https://github.com/apache/cxf/pull/807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [cxf] rmannibucau commented on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

rmannibucau commented on pull request #805: URL: https://github.com/apache/cxf/pull/805#issuecomment-850997915 There are at https://issues.apache.org/jira/projects/CXF/issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cxf] brevilo commented on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

brevilo commented on pull request #805: URL: https://github.com/apache/cxf/pull/805#issuecomment-850978292 ~~Would it be better if I close this PR and turn it into an issue?~~ Nope, there are no public issues. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cxf] rmannibucau commented on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

rmannibucau commented on pull request #805: URL: https://github.com/apache/cxf/pull/805#issuecomment-850948345 @brevilo guess adding tests - security manager, javaagent visiting the classes and loading visited types - to harness it is the best way to ensure it works. side note: