Re: svn commit: r1291166 - in /cxf/trunk: rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/ rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/ rt/ws/security/src/ma

2012-02-21 Thread Colm O hEigeartaigh
Thanks, it looks good now. Colm. On Mon, Feb 20, 2012 at 10:57 AM, Freeman Fang wrote: > Hi Colm, > > Thanks for the input, will revise it accordingly. > > Freeman > > On 2012-2-20, at 下午6:06, Colm O hEigeartaigh wrote: > >> Hi Freeman, >> >> I'm -1 to the way you are configuring this patch. WSS

Re: svn commit: r1291166 - in /cxf/trunk: rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/ rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/ rt/ws/security/src/ma

2012-02-20 Thread Freeman Fang
Hi Colm, Thanks for the input, will revise it accordingly. Freeman On 2012-2-20, at 下午6:06, Colm O hEigeartaigh wrote: Hi Freeman, I'm -1 to the way you are configuring this patch. WSS10 and WSS11 are standard policies defined in the WS-SP 1.3 spec, and so it's not a good idea to add a custom

Re: svn commit: r1291166 - in /cxf/trunk: rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/ rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/ rt/ws/security/src/ma

2012-02-20 Thread Colm O hEigeartaigh
Hi Freeman, I'm -1 to the way you are configuring this patch. WSS10 and WSS11 are standard policies defined in the WS-SP 1.3 spec, and so it's not a good idea to add a custom policy for these. The best way to configure it is to define a (boolean) tag in SecurityConstants so that it can be set as