[GitHub] gyoetam opened a new pull request #466: fix: handle connectionRequestTimeout in AsyncHTTPConduitFactory

2018-10-24 Thread GitBox 
gyoetam opened a new pull request #466: fix: handle connectionRequestTimeout in 
AsyncHTTPConduitFactory
URL: https://github.com/apache/cxf/pull/466
 
 
   Motivation: if connections are contended towards a slow target, it may make 
sense
   to set connectionTimeout and connectionRequestTimeout to values much lower 
than
   the receiveTimeout. Expected client behavior is to receive an error if a 
connection
   does not become available within connectionRequestTimeout. Current behavior 
however
   is that the error is only received after up to receiveTimeout has passed, 
when a
   current request to the target has finished and the connection is released or 
returned
   to the pool.
   
   Fix: instead of only checking expired leases when a connection becomes 
available,
   periodically check them in the same thread that checks idle connections as
   well. This makes sure that an error is returned to the client after
   a maximum of connectionRequestTimeout + selectTimeout.
   
   As a side effect, PoolingNHttpClientConnectionManager logs a debug level 
message
   at every selectTimeout interval - this should be suppressed by the logging 
framework.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Andrey Redko 
+1, thanks Dan!

Best Regards,
Andriy Redko

On Wed, Oct 24, 2018, 3:35 PM Daniel Kulp  wrote:

> It’s been over two months since we last release a 3.2.x.  Thus, it’s
> time.   We’ve fixed a bunch of bugs, fixed some performance regressions,
> added a few new features, etc…
>
> Tags:
> CXF:
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> <
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> >
> XJC:
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> <
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> >
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
>
>
> Here is my +1.
>
> --
> Daniel Kulp
> dk...@apache.org  - http://dankulp.com/blog <
> http://dankulp.com/blog>
> Talend Community Coder - http://talend.com 
>

[VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Daniel Kulp 
It’s been over two months since we last release a 3.2.x.  Thus, it’s time.   
We’ve fixed a bunch of bugs, fixed some performance regressions, added a few 
new features, etc…

Tags:
CXF: 
https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
 

XJC: 
https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
 



Staging repo:
https://repository.apache.org/content/repositories/orgapachecxf-1132/


Here is my +1.

-- 
Daniel Kulp
dk...@apache.org  - http://dankulp.com/blog 

Talend Community Coder - http://talend.com

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread David Karlsen 
Great news - is there any chance at all to get
https://issues.apache.org/jira/browse/CXF-7852 backported into 3.2?

Den ons. 24. okt. 2018 kl. 21:35 skrev Daniel Kulp :

> It’s been over two months since we last release a 3.2.x.  Thus, it’s
> time.   We’ve fixed a bunch of bugs, fixed some performance regressions,
> added a few new features, etc…
>
> Tags:
> CXF:
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> <
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> >
> XJC:
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> <
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> >
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
>
>
> Here is my +1.
>
> --
> Daniel Kulp
> dk...@apache.org  - http://dankulp.com/blog <
> http://dankulp.com/blog>
> Talend Community Coder - http://talend.com 
>


-- 
--
David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Freeman Fang 
+1

Thanks!
－
Freeman(Yue) Fang

Red Hat, Inc. 
FuseSource is now part of Red Hat



> On Oct 25, 2018, at 3:35 AM, Daniel Kulp  wrote:
> 
> It’s been over two months since we last release a 3.2.x.  Thus, it’s time.   
> We’ve fixed a bunch of bugs, fixed some performance regressions, added a few 
> new features, etc…
> 
> Tags:
> CXF: 
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
>  
> 
> XJC: 
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
>  
> 
> 
> 
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
> 
> 
> Here is my +1.
> 
> -- 
> Daniel Kulp
> dk...@apache.org  - http://dankulp.com/blog 
> 
> Talend Community Coder - http://talend.com

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Andy McCright 
+1

Thanks!

Andy

On Wed, Oct 24, 2018 at 7:53 PM Jeff Genender  wrote:

> +1
>
> Jeff
>
> > On Oct 24, 2018, at 1:35 PM, Daniel Kulp  wrote:
> >
> > It’s been over two months since we last release a 3.2.x.  Thus, it’s
> time.   We’ve fixed a bunch of bugs, fixed some performance regressions,
> added a few new features, etc…
> >
> > Tags:
> > CXF:
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> <
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> >
> > XJC:
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> <
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> >
> >
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/orgapachecxf-1132/
> >
> >
> > Here is my +1.
> >
> > --
> > Daniel Kulp
> > dk...@apache.org  - http://dankulp.com/blog <
> http://dankulp.com/blog>
> > Talend Community Coder - http://talend.com 
>
>

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Francois Papon 
+1 (non-binding)

Thanks!

regards,

François Papon
fpa...@apache.org

Le 24/10/2018 à 23:35, Daniel Kulp a écrit :
> It’s been over two months since we last release a 3.2.x.  Thus, it’s time.   
> We’ve fixed a bunch of bugs, fixed some performance regressions, added a few 
> new features, etc…
>
> Tags:
> CXF: 
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
>  
> 
> XJC: 
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
>  
> 
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
>
>
> Here is my +1.
>

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Jeff Genender 
+1

Jeff

> On Oct 24, 2018, at 1:35 PM, Daniel Kulp  wrote:
> 
> It’s been over two months since we last release a 3.2.x.  Thus, it’s time.   
> We’ve fixed a bunch of bugs, fixed some performance regressions, added a few 
> new features, etc…
> 
> Tags:
> CXF: 
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
>  
> 
> XJC: 
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
>  
> 
> 
> 
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
> 
> 
> Here is my +1.
> 
> -- 
> Daniel Kulp
> dk...@apache.org  - http://dankulp.com/blog 
> 
> Talend Community Coder - http://talend.com

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Jean-Baptiste Onofré 
+1 (non binding)

Quickly tested on Karaf with the examples.

Regards
JB

On 24/10/2018 21:35, Daniel Kulp wrote:
> It’s been over two months since we last release a 3.2.x.  Thus, it’s time.   
> We’ve fixed a bunch of bugs, fixed some performance regressions, added a few 
> new features, etc…
> 
> Tags:
> CXF: 
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
>  
> 
> XJC: 
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
>  
> 
> 
> 
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
> 
> 
> Here is my +1.
>

Re: [VOTE] CXF 3.2.7 and xic-utils 3.2.3

2018-10-24 Thread Alessio Soldano 
+1
Thanks!

On Wed, Oct 24, 2018 at 9:35 PM Daniel Kulp  wrote:

> It’s been over two months since we last release a 3.2.x.  Thus, it’s
> time.   We’ve fixed a bunch of bugs, fixed some performance regressions,
> added a few new features, etc…
>
> Tags:
> CXF:
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> <
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=7e83e9f7c5f448cbbc8ce5675f4814144270aef7
> >
> XJC:
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> <
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=tag;h=0acc9ea783a88ff70711c1f1f1b925ce7ff75ef8
> >
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachecxf-1132/
>
>
> Here is my +1.
>
> --
> Daniel Kulp
> dk...@apache.org  - http://dankulp.com/blog <
> http://dankulp.com/blog>
> Talend Community Coder - http://talend.com 
>

[GitHub] amarkevich commented on issue #465: StringUtils: lazy Pattern evaluation

2018-10-24 Thread GitBox 
amarkevich commented on issue #465: StringUtils: lazy Pattern evaluation
URL: https://github.com/apache/cxf/pull/465#issuecomment-432541205
 
 
   I will recheck this method usage; some cases can be switched to String.split 
fastpath way


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] amarkevich closed pull request #465: StringUtils: lazy Pattern evaluation

2018-10-24 Thread GitBox 
amarkevich closed pull request #465: StringUtils: lazy Pattern evaluation
URL: https://github.com/apache/cxf/pull/465
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/main/java/org/apache/cxf/common/util/StringUtils.java 
b/core/src/main/java/org/apache/cxf/common/util/StringUtils.java
index 762b017714a..1a964e16ce5 100644
--- a/core/src/main/java/org/apache/cxf/common/util/StringUtils.java
+++ b/core/src/main/java/org/apache/cxf/common/util/StringUtils.java
@@ -29,13 +29,14 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import java.util.function.Predicate;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import java.util.stream.Stream;
 
 public final class StringUtils {
-public static final Map PATTERN_MAP = new HashMap<>();
+private static final Map PATTERN_MAP = new HashMap<>();
 static {
 String patterns[] = {"/", " ", ":", ",", ";", "=", "\\.", "\\+"};
 for (String p : patterns) {
@@ -51,13 +52,13 @@ private StringUtils() {
 return split(s, regex, 0);
 }
 public static String[] split(String s, String regex, int limit) {
-Pattern p = PATTERN_MAP.getOrDefault(regex, Pattern.compile(regex));
-return p.split(s, limit);
+return getPattern(regex).split(s, limit);
 }
-
 public static Stream splitAsStream(String s, String regex) {
-Pattern p = PATTERN_MAP.getOrDefault(regex, Pattern.compile(regex));
-return p.splitAsStream(s);
+return getPattern(regex).splitAsStream(s);
+}
+static Pattern getPattern(String regex) {
+return Optional.ofNullable(PATTERN_MAP.get(regex)).orElseGet(() -> 
Pattern.compile(regex));
 }
 
 public static boolean isFileExist(String file) {
diff --git a/core/src/test/java/org/apache/cxf/common/util/StringUtilsTest.java 
b/core/src/test/java/org/apache/cxf/common/util/StringUtilsTest.java
index a346e9635c3..74191de93e6 100644
--- a/core/src/test/java/org/apache/cxf/common/util/StringUtilsTest.java
+++ b/core/src/test/java/org/apache/cxf/common/util/StringUtilsTest.java
@@ -73,13 +73,19 @@ public void testGetPartsWithManySpaces() throws Exception {
 @Test
 public void testSplitWithDot() throws Exception {
 String str = "a.b.c";
-String[] parts = StringUtils.split(str, "\\.", -1);
+String[] parts = StringUtils.split(str, "\\.");
 assertEquals(3, parts.length);
 assertEquals("a", parts[0]);
 assertEquals("b", parts[1]);
 assertEquals("c", parts[2]);
 }
 
+@Test
+public void testGetPattern() throws Exception {
+assertSame(StringUtils.getPattern("\\."), 
StringUtils.getPattern("\\."));
+assertNotSame(StringUtils.getPattern("123"), 
StringUtils.getPattern("123"));
+}
+
 @Test
 public void testGetFound() throws Exception {
 String regex = "velocity-\\d+\\.\\d+\\.jar";


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services