[GitHub] [cxf] amarkevich opened a new pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
amarkevich opened a new pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cxf] coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534#discussion_r271700489 ## File path:

[GitHub] [cxf] coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534#discussion_r271700489 ## File path:

[GitHub] [cxf] coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534#discussion_r271703024 ## File path:

[GitHub] [cxf] coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
coheigea commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534#discussion_r271702719 ## File path:

Dynamic JAX-RS filters (per request/response)

2019-04-03 Thread Andrei Shakirin
Hi, Currently JAX-RS filters are bound to exchange endpoint in ClientProviderFactory and ServerProviderFactory and filter chain is always the same for all processing messages. In some use cases (security) it would be useful to activate filters dynamically on message level, that different

[GitHub] [cxf] reta commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks

2019-04-03 Thread GitBox
reta commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks URL: https://github.com/apache/cxf/pull/529#issuecomment-479663732 Thanks a lot @rmannibucau, @coheigea do you have any concerns? Thanks guys.

[GitHub] [cxf] rmannibucau commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks

2019-04-03 Thread GitBox
rmannibucau commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks URL: https://github.com/apache/cxf/pull/529#issuecomment-479632076 Looks good, worse case a default method would solve the model api issue. It can happen since cdi enables to switch

Re: Dynamic JAX-RS filters (per request/response)

2019-04-03 Thread Andriy Redko
Hi Andrei, I would be curious to understand a bit regarding the use case(s). Is it going to be driven by presence of some headers fe? Or something else? Like f.e. each message is inspected, and depending on some criteria, the different filter chains are being constructed? Could you share a

[GitHub] [cxf] amarkevich opened a new pull request #535: cxf-rt-rs-security-jose: fix PVS-Studio errors/warnings

2019-04-03 Thread GitBox
amarkevich opened a new pull request #535: cxf-rt-rs-security-jose: fix PVS-Studio errors/warnings URL: https://github.com/apache/cxf/pull/535 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cxf] davidkarlsen commented on issue #533: Drop @PreMatching - no need for it

2019-04-03 Thread GitBox
davidkarlsen commented on issue #533: Drop @PreMatching - no need for it URL: https://github.com/apache/cxf/pull/533#issuecomment-479564134 @coheigea This is an automated message from the Apache Git Service. To respond to

[GitHub] [cxf] reta edited a comment on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks

2019-04-03 Thread GitBox
reta edited a comment on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks URL: https://github.com/apache/cxf/pull/529#issuecomment-479593978 @rmannibucau Converted `SpringAopClassHelper` to `SpringClassUnwrapper`, so now `ClassHelper` is completely driven by

[GitHub] [cxf] reta commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks

2019-04-03 Thread GitBox
reta commented on issue #529: CXF-8009: CXF should not rely on ClassUtils for CGLIB proxy checks URL: https://github.com/apache/cxf/pull/529#issuecomment-479593978 @rmannibucau Converted `SpringAopClassHelper` to `SpringClassUnwrapper`, so now `ClassHelper` is completely driven by

[GitHub] [cxf] davidkarlsen edited a comment on issue #531: add client digest interceptor

2019-04-03 Thread GitBox
davidkarlsen edited a comment on issue #531: add client digest interceptor URL: https://github.com/apache/cxf/pull/531#issuecomment-479701659 @coheigea I had missed calling proceed() which is added now and the test passes (although there is not a matching server-side filter configured in

[GitHub] [cxf] davidkarlsen commented on issue #531: add client digest interceptor

2019-04-03 Thread GitBox
davidkarlsen commented on issue #531: add client digest interceptor URL: https://github.com/apache/cxf/pull/531#issuecomment-479701659 @coheigea I had missed calling proceed(). I have an alternative implementation which looks more similar to the jws stuff and wraps the output stream in

[GitHub] [cxf] amarkevich merged pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
amarkevich merged pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cxf] amarkevich commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
amarkevich commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534#discussion_r271713276 ## File path:

[GitHub] [cxf] amarkevich commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference'

2019-04-03 Thread GitBox
amarkevich commented on a change in pull request #534: cxf-rt-rs-security-oauth2: fix 'Potential null dereference' URL: https://github.com/apache/cxf/pull/534#discussion_r271714902 ## File path: