Re: [VOTE] Apache CXF 3.4.1 and 3.3.8

2020-11-03 Thread Alexey Markevich
+1 On 11/4/20, Jean-Baptiste Onofre wrote: > +1 (non binding) > > Slight note: Karaf 4.3.0 doesn’t provide the jetty feature anymore (used by > cxf-http-jetty one). For "transition" purpose, I’m re-adding this feature in > Karaf 4.3.1 (that I will release soon). I will propose a CXF PR to

Re: [VOTE] Apache CXF 3.4.1 and 3.3.8

2020-11-03 Thread Jean-Baptiste Onofre
+1 (non binding) Slight note: Karaf 4.3.0 doesn’t provide the jetty feature anymore (used by cxf-http-jetty one). For "transition" purpose, I’m re-adding this feature in Karaf 4.3.1 (that I will release soon). I will propose a CXF PR to leverage capability and updated feature. Regards JB >

Re: [VOTE] Apache CXF 3.4.1 and 3.3.8

2020-11-03 Thread Jeff Genender
+1 Jeff > On Nov 3, 2020, at 2:30 PM, Daniel Kulp wrote: > > > This is a vote to release CXF 3.3.8 and 3.4.1. We’ve fixed over 20 JIRA > issues and it’s been over 2 months since the last set of releases. > > Staging repos: >

[GitHub] [cxf] reta merged pull request #719: CXF-8356: JAXRS Multipart-Handling broken for InputStream/Datasource parameters

2020-11-03 Thread GitBox
reta merged pull request #719: URL: https://github.com/apache/cxf/pull/719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [VOTE] Apache CXF 3.4.1 and 3.3.8

2020-11-03 Thread Andy McCright
+1 Thanks! On Tue, Nov 3, 2020 at 4:00 PM Freeman Fang wrote: > +1(binding) > > Thanks Dan! > Freeman > > On Tue, Nov 3, 2020 at 4:30 PM Daniel Kulp wrote: > > > > > This is a vote to release CXF 3.3.8 and 3.4.1. We’ve fixed over 20 JIRA > > issues and it’s been over 2 months since the last

Re: [VOTE] Apache CXF 3.4.1 and 3.3.8

2020-11-03 Thread Freeman Fang
+1(binding) Thanks Dan! Freeman On Tue, Nov 3, 2020 at 4:30 PM Daniel Kulp wrote: > > This is a vote to release CXF 3.3.8 and 3.4.1. We’ve fixed over 20 JIRA > issues and it’s been over 2 months since the last set of releases. > > Staging repos: >

Re: [VOTE] Apache CXF 3.4.1 and 3.3.8

2020-11-03 Thread Andrey Redko
+1, thanks a lot Dan! Best Regards, Andriy Redko On Tue, Nov 3, 2020, 4:30 PM Daniel Kulp wrote: > > This is a vote to release CXF 3.3.8 and 3.4.1. We’ve fixed over 20 JIRA > issues and it’s been over 2 months since the last set of releases. > > Staging repos: >

[GitHub] [cxf] davidkarlsen closed pull request #717: Upgrade boot and spring

2020-11-03 Thread GitBox
davidkarlsen closed pull request #717: URL: https://github.com/apache/cxf/pull/717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cxf] reta commented on pull request #717: Upgrade boot and spring

2020-11-03 Thread GitBox
reta commented on pull request #717: URL: https://github.com/apache/cxf/pull/717#issuecomment-721138096 @davidkarlsen that is correct, thanks @amarkevich, we have reported the regression (https://github.com/spring-projects/spring-framework/issues/25987) which should be fixed in next

[GitHub] [cxf] coheigea commented on pull request #717: Upgrade boot and spring

2020-11-03 Thread GitBox
coheigea commented on pull request #717: URL: https://github.com/apache/cxf/pull/717#issuecomment-721142679 @davidkarlsen I already merged this update to master yesterday This is an automated message from the Apache Git

[GitHub] [cxf] amarkevich commented on pull request #717: Upgrade boot and spring

2020-11-03 Thread GitBox
amarkevich commented on pull request #717: URL: https://github.com/apache/cxf/pull/717#issuecomment-720329639 Spring version update reverted: https://github.com/apache/cxf/commit/70fef6f5a78bb69548628a4380ac4abb98404dc9

[GitHub] [cxf] reta commented on pull request #718: [CXF-8361] Added support for jakarta NS in AnnotationHandlerChainBuilder

2020-11-03 Thread GitBox
reta commented on pull request #718: URL: https://github.com/apache/cxf/pull/718#issuecomment-720858753 Thanks for the PR, @ropalka , could you please add a test cases for the change to `AnnotationHandlerChainBuilderTest`, thank you

[GitHub] [cxf] reta edited a comment on pull request #718: [CXF-8361] Added support for jakarta NS in AnnotationHandlerChainBuilder

2020-11-03 Thread GitBox
reta edited a comment on pull request #718: URL: https://github.com/apache/cxf/pull/718#issuecomment-720858753 Thanks for the PR, @ropalka , could you please add test cases for the change to `AnnotationHandlerChainBuilderTest`, thank you

[GitHub] [cxf] davidkarlsen opened a new pull request #717: Upgrade boot and spring

2020-11-03 Thread GitBox
davidkarlsen opened a new pull request #717: URL: https://github.com/apache/cxf/pull/717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cxf] ashakirin commented on a change in pull request #713: CXF-8359: fixed mask for XML elements containing attributes

2020-11-03 Thread GitBox
ashakirin commented on a change in pull request #713: URL: https://github.com/apache/cxf/pull/713#discussion_r516340812 ## File path: rt/features/logging/src/main/java/org/apache/cxf/ext/logging/MaskSensitiveHelper.java ## @@ -70,15 +71,19 @@ public String

[GitHub] [cxf] ropalka opened a new pull request #718: [CXF-8361] Added support for jakarta NS in AnnotationHandlerChainBuilder

2020-11-03 Thread GitBox
ropalka opened a new pull request #718: URL: https://github.com/apache/cxf/pull/718 Fixes https://issues.apache.org/jira/browse/CXF-8361 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cxf] faucct commented on pull request #690: InputStream should not be closed prematurely

2020-11-03 Thread GitBox
faucct commented on pull request #690: URL: https://github.com/apache/cxf/pull/690#issuecomment-720270394 I don't think I remember the whole context, but the problem was that in case of `MediaType.MULTIPART_FORM_DATA_TYPE` the message body was also a stream and was being consumed twice.

[GitHub] [cxf] reta opened a new pull request #719: CXF-8356: JAXRS Multipart-Handling broken for InputStream/Datasource parameters

2020-11-03 Thread GitBox
reta opened a new pull request #719: URL: https://github.com/apache/cxf/pull/719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cxf] coheigea commented on pull request #690: InputStream should not be closed prematurely

2020-11-03 Thread GitBox
coheigea commented on pull request #690: URL: https://github.com/apache/cxf/pull/690#issuecomment-720265307 What's the context behind this pull request? Can you create a JIRA describing the problem? This is an automated