[GitHub] [cxf] reta commented on a change in pull request #850: [CXF-8596]:Fix infinite loop in FaultOutInterceptor

[GitBox]

reta commented on a change in pull request #850:
URL: https://github.com/apache/cxf/pull/850#discussion_r707878616



##
File path: 
core/src/main/java/org/apache/cxf/interceptor/FaultOutInterceptor.java
##
@@ -81,6 +82,15 @@ public void handleMessage(Message message) {
 
 MessagePartInfo part = fi.getFirstMessagePart();
 DataBinding db = service.getDataBinding();
+boolean faultDetail = cause instanceof SOAPFaultException
+&& ((SOAPFaultException)cause).getFault().hasDetail();
+if (faultDetail) {
+//the fault detail is already set and we don't need to write
+//Writes the SoapFaultException to detail will go into an 
infinite loop because
+//SoapFaultException's cause field is itself

Review comment:
   I am wondering if we should specifically check for the loop in 
`SoapFaultException`, following the `getCause()` chain? It seems like otherwise 
we are cutting off `if (isDOMSupported(db)) {` branch altogether in some cases 
(not sure how important it is to be fair).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on pull request #847: [CXF-8594]:Fix regular expression parameter with non-capturing group …

[GitBox]

reta commented on pull request #847:
URL: https://github.com/apache/cxf/pull/847#issuecomment-918761533


   Thanks @jimma , I think you could merge it, right? Or you prefer me to merge 
and backport it? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] jimma commented on pull request #847: [CXF-8594]:Fix regular expression parameter with non-capturing group …

[GitBox]

jimma commented on pull request #847:
URL: https://github.com/apache/cxf/pull/847#issuecomment-918751717


   @reta  Sure. All tests are passed, and it's ready to merge. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on pull request #847: [CXF-8594]:Fix regular expression parameter with non-capturing group …

[GitBox]

reta commented on pull request #847:
URL: https://github.com/apache/cxf/pull/847#issuecomment-918748856


   @jimma oh sorry, I meant - merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] jimma commented on pull request #847: [CXF-8594]:Fix regular expression parameter with non-capturing group …

[GitBox]

jimma commented on pull request #847:
URL: https://github.com/apache/cxf/pull/847#issuecomment-918726243


   @reta  what do you mean by integrated ?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Releases next week?

[Andrey Redko]

Hey Dan,

For 3.5.0 we are still waiting for xmlschema and neethi releases (both have
SNAPSHOT versions right now), so it make take longer to clear the path out.
Thanks.

Best Regards,
Andriy Redko

On Mon, Sep 13, 2021, 3:08 PM Daniel Kulp  wrote:

> I guess the question is:  Which releases?
>
> 3.4.5 and 3.3.12 are a certain YES!
>
> The question I have is whether 3.5.0 is ready for release next week or
> should we wait another couple weeks to double check the Java17 stuff
> assuming java17 release happens tomorrow as planned.
>
> Dan
>
>
>
> > On Sep 13, 2021, at 11:48 AM, Colm O hEigeartaigh 
> wrote:
> >
> > I believe we are well overdue getting new releases out, how does early
> > next week sound?
> >
> > Colm.
>
> --
> Daniel Kulp
> dk...@apache.org  - http://dankulp.com/blog <
> http://dankulp.com/blog>
> Talend - http://talend.com 
>

Re: Releases next week?

[Daniel Kulp]

I guess the question is:  Which releases?

3.4.5 and 3.3.12 are a certain YES!

The question I have is whether 3.5.0 is ready for release next week or should 
we wait another couple weeks to double check the Java17 stuff assuming java17 
release happens tomorrow as planned.

Dan



> On Sep 13, 2021, at 11:48 AM, Colm O hEigeartaigh  wrote:
> 
> I believe we are well overdue getting new releases out, how does early
> next week sound?
> 
> Colm.

-- 
Daniel Kulp
dk...@apache.org  - http://dankulp.com/blog 

Talend - http://talend.com 

Re: Releases next week?

[Andriy Redko]

Certainly +1, thanks Colm!

Best Regards,
Andriy Redko

COh> I believe we are well overdue getting new releases out, how does early
COh> next week sound?

COh> Colm.

[GitHub] [cxf] reta edited a comment on pull request #847: [CXF-8594]:Fix regular expression parameter with non-capturing group …

[GitBox]

reta edited a comment on pull request #847:
URL: https://github.com/apache/cxf/pull/847#issuecomment-918447803


   @jimma this one could be integrated, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on pull request #847: [CXF-8594]:Fix regular expression parameter with non-capturing group …

[GitBox]

reta commented on pull request #847:
URL: https://github.com/apache/cxf/pull/847#issuecomment-918447803


   @jimma this one could be integrated, right @jimma ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Releases next week?

[Jean-Baptiste Onofre]

+1

It sounds good to me.

Regards
JB

> Le 13 sept. 2021 à 17:56, Freeman Fang  a écrit :
> 
> +1
> 
> Thanks!
> Freeman
> 
> On Mon, Sep 13, 2021 at 11:49 AM Colm O hEigeartaigh 
> wrote:
> 
>> I believe we are well overdue getting new releases out, how does early
>> next week sound?
>> 
>> Colm.
>> 

Re: Releases next week?

[Freeman Fang]

+1

Thanks!
Freeman

On Mon, Sep 13, 2021 at 11:49 AM Colm O hEigeartaigh 
wrote:

> I believe we are well overdue getting new releases out, how does early
> next week sound?
>
> Colm.
>

Releases next week?

[Colm O hEigeartaigh]

I believe we are well overdue getting new releases out, how does early
next week sound?

Colm.