[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266065151 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266064793 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266057931 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266057276 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/FNFunctions.scala