jadams-tresys commented on a change in pull request #135: Show different error
message for OOM
URL: https://github.com/apache/incubator-daffodil/pull/135#discussion_r233458999
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Parser.scala
##########
@@ -271,7 +271,7 @@ class ChoiceParser(ctxt: RuntimeData, val childParsers:
Vector[Parser])
case t: Throwable => {
if (pBefore != null) {
markLeakCausedByException = true
- if (!t.isInstanceOf[SchemaDefinitionDiagnosticBase] &&
!t.isInstanceOf[UnsuppressableException]) {
+ if (!t.isInstanceOf[SchemaDefinitionDiagnosticBase] &&
!t.isInstanceOf[UnsuppressableException] && !t.isInstanceOf[OutOfMemoryError]) {
Review comment:
Most recent push should address the java.lang.Error check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
