[jira] [Commented] (DAFFODIL-1885) Initiators are not being inherited from parent choices
[
https://issues.apache.org/jira/browse/DAFFODIL-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347593#comment-16347593
]
Michael Beckerle commented on DAFFODIL-1885:
You need a bigger example to illustrate what is going wrong here. Nothing
inherits initiators other than from the default format.
I claim the above schema is equivalent to (removing group ref)
{code}
... this is where the next thing that must have an initiator would appear
{code}
I can simplify the above to:
{code}
... more elements sequences or choices would go here. All must have
dfdl:initiator properties
{code}
You see that the names of the inner elements no longer make sense. They're not
children of the outer choice.
> Initiators are not being inherited from parent choices
> --
>
> Key: DAFFODIL-1885
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1885
> Project: Daffodil
> Issue Type: Bug
> Components: Compatibility, Front End
>Affects Versions: 2.1.0
>Reporter: Josh Adams
>Assignee: Josh Adams
>Priority: Major
>
> This is a bug that is currently effecting the compatibility with the
> IBM4690-TLOG schema project.
> In the IBM4690-TLOG schemas there is a parent choice with
> dfdl:initiatedContent="yes" that contains groups of choices. The child
> choices define an initiator, but the initiator does not seem to be getting
> passed down the the elements contained within the choice inside the child
> choice (3rd level choice), causing the following SDE:
> Schema Definition Error: Enclosing group has initiatedContent='yes', but
> initiator is not defined.
>
> Here is a simplified schema as an example:
> {code:java}
> ...
>
>
>
>
>
>
>
>
>
>
> ...{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (DAFFODIL-1886) Delimited parsing with occursCountKind="implicit" with separators is not handling missing optional elements correctly
Josh Adams created DAFFODIL-1886:
Summary: Delimited parsing with occursCountKind="implicit" with
separators is not handling missing optional elements correctly
Key: DAFFODIL-1886
URL: https://issues.apache.org/jira/browse/DAFFODIL-1886
Project: Daffodil
Issue Type: Bug
Components: Compatibility, Front End
Affects Versions: 2.1.0
Reporter: Josh Adams
Assignee: Josh Adams
This bug currently prevents the IBM4690-TLOG schema project from working.
Example schema:
{code:java}
{code}
This schema should be able to parse the following scenarios:
1:2:3 -> a=1, b=2, c=3
1:2: -> a=1, b=2
1::3 -> a=1, c=3
1:: -> a=1
Currently scenarios 1,2 and 4 work as expected, but scenario 3 ends up parsing
as just a=1 and b and c are just skipped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (DAFFODIL-1885) Initiators are not being inherited from parent choices
Josh Adams created DAFFODIL-1885:
Summary: Initiators are not being inherited from parent choices
Key: DAFFODIL-1885
URL: https://issues.apache.org/jira/browse/DAFFODIL-1885
Project: Daffodil
Issue Type: Bug
Components: Compatibility, Front End
Affects Versions: 2.1.0
Reporter: Josh Adams
Assignee: Josh Adams
This is a bug that is currently effecting the compatibility with the
IBM4690-TLOG schema project.
In the IBM4690-TLOG schemas there is a parent choice with
dfdl:initiatedContent="yes" that contains groups of choices. The child choices
define an initiator, but the initiator does not seem to be getting passed down
the the elements contained within the choice inside the child choice (3rd level
choice), causing the following SDE:
Schema Definition Error: Enclosing group has initiatedContent='yes', but
initiator is not defined.
Here is a simplified schema as an example:
{code:java}
...
...{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (DAFFODIL-1881) Prepare 2.1.0 release
[ https://issues.apache.org/jira/browse/DAFFODIL-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence reassigned DAFFODIL-1881: Assignee: Steve Lawrence > Prepare 2.1.0 release > - > > Key: DAFFODIL-1881 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1881 > Project: Daffodil > Issue Type: Bug >Reporter: Steve Lawrence >Assignee: Steve Lawrence >Priority: Major > Fix For: 2.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (DAFFODIL-1876) Improve performance regression due to FormatInfo changes
[ https://issues.apache.org/jira/browse/DAFFODIL-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Thompson closed DAFFODIL-1876. --- Pulled latest updates from incubator-daffodil repository and verified the specified commit, ee4177b4c9bf84af2af19d8c9f67f283e233105e, was included. Reviewed updated files to determine the effected tests. Executed the entire SBT test suite. Verified that the effected tests executed successfully. Nightly test run executed successfully. Comparison with the FormatInfo commit (a1d881), showed performance gains across all data format tests with some exceptions. Some of these could be due to normal run-to-run deviation. There were no nato-stanag tests listed in this comparison due to these test being broken at the time. The comparison to the pre- FormatInfo commit (401761) showed that performance has not been regained to pre-FormatInfo commit values across all format tests. Most significant are the army-drss and nato-stanag tests which needs further investigation. Also note that for some tests there is a significant performance increase from the 2.0.0 baseline and in some there is still a significant performance decrease. Closing this ticket and created JIRA ticket DAFFODIL-1883 to identify the specific data formats that need further performance regression investigation. > Improve performance regression due to FormatInfo changes > > > Key: DAFFODIL-1876 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1876 > Project: Daffodil > Issue Type: Improvement > Components: Back End, Middle End >Affects Versions: 2.1.0 >Reporter: Michael Beckerle >Assignee: Dave Thompson >Priority: Major > Fix For: 2.1.0 > > > FormatInfo changes introduced significant performance degradation. > Changes are needed to win back this performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DAFFODIL-1884) Regression in bitOrder changing
Steve Lawrence created DAFFODIL-1884: Summary: Regression in bitOrder changing Key: DAFFODIL-1884 URL: https://issues.apache.org/jira/browse/DAFFODIL-1884 Project: Daffodil Issue Type: Bug Reporter: Steve Lawrence Assignee: Michael Beckerle Fix For: 2.1.0 test_bitOrderOVC1 in ./daffodil-test/src/test/scala-new/edu/illinois/ncsa/daffodil/section00/general/TestUnparserGeneral2.scala currently fails. It appears to be a regression with recent changes to how bitOrder works, but was not discovered because the test is in scala-new. This test should be fixed and moved into the scala directory since the scala-new directory is no longer used and ignored. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DAFFODIL-1883) Investigate remaining performance regression issues
Dave Thompson created DAFFODIL-1883: --- Summary: Investigate remaining performance regression issues Key: DAFFODIL-1883 URL: https://issues.apache.org/jira/browse/DAFFODIL-1883 Project: Daffodil Issue Type: Bug Components: Performance Affects Versions: 2.1.0 Reporter: Dave Thompson Fix For: 2.2.0 While verifying JIRA ticket DAFFODIL-1876, found that although the majority of the performance degradation from the FormatInfo changes (commit a1d881) has been recovered, there is still performance regression on several data format tests. The most significant performance regression occurs with formats army-drss, asterix and nato-stanag tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (DAFFODIL-1739) Implement 'packed' and 'bcd'
[ https://issues.apache.org/jira/browse/DAFFODIL-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Thompson closed DAFFODIL-1739. --- Pulled latest updates from incubator-daffodil repository and verified the specified commit, 8d9aadab07a2f422dfae527b3a4d1cb4047a6efa was included. Reviewed updated files to determine the effected tests. Verified that the effected tests executed successfully with the exception of referenced test "length_delimited_12_05". This test was still in scala-debug folder and when executed it failed. Talked with Josh A. and he said that it failed due needing support for delimited parsing of non ISO-8859-1 encodings which is not currently implemented. The issue is addressed by DAFFODIL-1541. As we were investigating I asked about another test, simple_type_properties_binary_number_13_01, that was in both the scala and scala-debug test files. Josh removed the entry from the scala-debug test file. Verified that the test was removed for scala-debug in commit 11d36b21e1abb7fc6fd26f7aa10cab3827f53546. > Implement 'packed' and 'bcd' > > > Key: DAFFODIL-1739 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1739 > Project: Daffodil > Issue Type: New Feature > Components: DFDL Language >Reporter: Elizabeth Fahl >Assignee: Dave Thompson >Priority: Major > Fix For: 2.1.0 > > > Implement 'packed' and 'bcd' and for binaryNumberRep and binaryCalendarRep. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jadams-tresys closed pull request #32: Removed working test from scala-debug
jadams-tresys closed pull request #32: Removed working test from scala-debug
URL: https://github.com/apache/incubator-daffodil/pull/32
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/daffodil-test-ibm1/src/test/scala-debug/edu/illinois/ncsa/daffodil/IBMTests2.scala
b/daffodil-test-ibm1/src/test/scala-debug/edu/illinois/ncsa/daffodil/IBMTests2.scala
index 9742ec156..7d418c9e7 100644
---
a/daffodil-test-ibm1/src/test/scala-debug/edu/illinois/ncsa/daffodil/IBMTests2.scala
+++
b/daffodil-test-ibm1/src/test/scala-debug/edu/illinois/ncsa/daffodil/IBMTests2.scala
@@ -72,7 +72,6 @@ class IBMTestsThatThrow {
@Test def test_simple_type_properties_text_number_13_01() {
runner2.runOneTest("simple_type_properties_text_number_13_01") } // DFDL-452
text number advanced props
@Test def test_simple_type_properties_text_number_13_03() {
runner2.runOneTest("simple_type_properties_text_number_13_03") } // DFDL-452
textStandardBase (base 16)
- @Test def test_simple_type_properties_binary_number_13_01() {
runner2.runOneTest("simple_type_properties_binary_number_13_01") } //
DAFFODIL-1541 Need support for handling delimited data with encoding other than
ISO-8859-1
@Test def test_simple_type_properties_text_boolean_13_03() {
runner2.runOneTest("simple_type_properties_text_boolean_13_03") } // DFDL-462
boolean type
@Test def test_simple_type_properties_bin_boolean_13_01() {
runner2.runOneTest("simple_type_properties_bin_boolean_13_01") } // DFDL-461
boolean type
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jadams-tresys commented on issue #32: Removed working test from scala-debug
jadams-tresys commented on issue #32: Removed working test from scala-debug URL: https://github.com/apache/incubator-daffodil/pull/32#issuecomment-361921494 I could have sworn that I pushed rebase & merge, let me try again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] stevedlawrence commented on issue #32: Removed working test from scala-debug
stevedlawrence commented on issue #32: Removed working test from scala-debug URL: https://github.com/apache/incubator-daffodil/pull/32#issuecomment-361921104 Josh, did you mean to close this? Looks like this was never merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
