Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-02-13 Thread Piyush Sharma
> On Feb. 13, 2017, 10:41 p.m., Matthew Hayes wrote: > > Ship It! Sorry I thought that meant I was supposed to click on ship it and so I did ! I am a bit new to the way it works here ! Hope that won't be an issue. Sorry again. - Piyush

Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-02-13 Thread Piyush Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55110/#review165410 --- Ship it! Ship It! - Piyush Sharma On Jan. 17, 2017, 9:52

Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-02-13 Thread Matthew Hayes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55110/#review165399 --- Ship it! Ship It! - Matthew Hayes On Jan. 17, 2017, 9:52

Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-01-31 Thread Matthew Hayes
> On Feb. 1, 2017, 7:46 a.m., Matthew Hayes wrote: > > datafu-pig/src/test/java/datafu/test/pig/PigTests.java, line 62 > > > > > > Instead of updating and restoring the user.dir I think it would be > > better to

Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-01-17 Thread Piyush Sharma
> On Jan. 2, 2017, 9:29 a.m., Eyal Allweil wrote: > > Hi Piyush, > > > > Thank you for your patch! It looks to me that it works fine - I ran our > > tests on Ubuntu, both from Eclipse and from the command line. > > > > I have two comments, one "real" and one just a typo: > > > > 1) From

Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-01-16 Thread Eyal Allweil
> On Jan. 2, 2017, 11:29 a.m., Eyal Allweil wrote: > > Hi Piyush, > > > > Thank you for your patch! It looks to me that it works fine - I ran our > > tests on Ubuntu, both from Eclipse and from the command line. > > > > I have two comments, one "real" and one just a typo: > > > > 1) From

Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.

2017-01-02 Thread Piyush Sharma
> On Jan. 2, 2017, 9:29 a.m., Eyal Allweil wrote: > > Hi Piyush, > > > > Thank you for your patch! It looks to me that it works fine - I ran our > > tests on Ubuntu, both from Eclipse and from the command line. > > > > I have two comments, one "real" and one just a typo: > > > > 1) From