Re: [PATCH] Fix mappings.

2012-12-11 Thread mar...@redhat.com
thanks! ACK & PUSHED I wonder if we need to introduce a new state to the API Instance states [1]... 'STOPPED' is probably not the best thing to return when the instance is actually in an error/unknown state - I'll add this for discussion, marios [1] http://deltacloud.apache.org/instance-states

[PATCH] Fix mappings.

2012-12-11 Thread Ian Main
UNKNOWN mispeeled and add error state. Signed-off-by: Ian Main --- server/lib/deltacloud/drivers/openstack/openstack_driver.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/lib/deltacloud/drivers/openstack/openstack_driver.rb b/server/lib/deltacloud/drivers/opens

Re: [PATCH] CIMI - tests - incorporate other provider testing

2012-12-11 Thread David Lutterkort
On Tue, 2012-12-11 at 18:09 -0500, rla...@redhat.com wrote: > From: Ronelle Landy > > --- > tests/cimi/test_helper.rb | 23 +-- > tests/config.yaml | 18 +++--- > 2 files changed, 20 insertions(+), 21 deletions(-) > > diff --git a/tests/cimi/test_help

Re: DTACLOUD-379 using Marios's 409 solution.

2012-12-11 Thread David Lutterkort
On Tue, 2012-12-11 at 17:27 -0500, jvl...@redhat.com wrote: > DTACLOUD-379 using Marios's 409 solution. > ACK to this; stylistically, the two patches should be squashed into one, since after applying 1/2 triggering this error will cause a server error because of a missing template. Also, the com

[PATCH 2/2] CIMI tests: make cleanup of machines work

2012-12-11 Thread lutter
From: David Lutterkort --- tests/cimi/test_helper.rb | 42 -- 1 files changed, 20 insertions(+), 22 deletions(-) diff --git a/tests/cimi/test_helper.rb b/tests/cimi/test_helper.rb index 025a705..45ff6a3 100644 --- a/tests/cimi/test_helper.rb +++ b/tests

[PATCH 1/2] CIMI tests: some fixes for part4

2012-12-11 Thread lutter
From: David Lutterkort * restore getting the volume after creating it, since not all servers return a body from the create request (see fe30257e) * add XML namespace to inline XML * accept 201 and 202 as response from create request --- tests/cimi/part4_test.rb | 27 +++--

[PATCH] CIMI - tests - incorporate other provider testing

2012-12-11 Thread rlandy
From: Ronelle Landy --- tests/cimi/test_helper.rb | 23 +-- tests/config.yaml | 18 +++--- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/tests/cimi/test_helper.rb b/tests/cimi/test_helper.rb index 025a705..ad74cd2 100644 --- a/tests/

CIMI - tests - incorporate other provider testing

2012-12-11 Thread rlandy
Config.yaml and test_helper.rb changes to use the provider information added for the Deltacloud API tests.

[jira] [Updated] (DTACLOUD-379) Executing /DELETE on a template used by an active instance throws 500 error

2012-12-11 Thread Joseph J. VLcek (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph J. VLcek updated DTACLOUD-379: - Attachment: 0002-DTACLOUD-379-using-Marios-s-409-solution.patch 0001-Pro

DTACLOUD-379 using Marios's 409 solution.

2012-12-11 Thread jvlcek
DTACLOUD-379 using Marios's 409 solution.

[PATCH 1/2] Proposed fix for DTACLOUD-379

2012-12-11 Thread jvlcek
From: marios https://issues.apache.org/jira/browse/DTACLOUD-379 Signed-off-by: marios TrackedAt: http://tracker-mfojtik.rhcloud.com/patch/6e465c4a530f4715cc11a2db14b84a1c349e513b --- server/lib/deltacloud/drivers/exceptions.rb | 8 server/lib/deltacloud/drivers/rhevm/rhevm_dr

[PATCH 2/2] DTACLOUD-379 using Marios's 409 solution.

2012-12-11 Thread jvlcek
From: Joe VLcek --- server/lib/deltacloud/collections/base.rb | 4 ++ server/lib/deltacloud/helpers/deltacloud_helper.rb | 1 + server/views/errors/409.html.haml | 47 ++ server/views/errors/409.xml.haml | 11 + 4 files change

[jira] [Resolved] (DTACLOUD-381) CIMI: attaching a volume to a machine and deleting volumes are not working

2012-12-11 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy resolved DTACLOUD-381. Resolution: Fixed Fixed in deltacloud commit version fe30257ecc0d17b8fa300300cdc9e2276513

[jira] [Closed] (DTACLOUD-381) CIMI: attaching a volume to a machine and deleting volumes are not working

2012-12-11 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy closed DTACLOUD-381. -- Closing issue as fixed - see comments above. Tests for volume delete will be added with cleanup

[jira] [Commented] (DTACLOUD-393) Starting deltacloud server with native frontend, pointng at mock driver, errors out

2012-12-11 Thread Marios Andreou (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529083#comment-13529083 ] Marios Andreou commented on DTACLOUD-393: - fix pushed as commit # 6d8fc5579fde1c

[PATCH core] CIMI: More database access optimization

2012-12-11 Thread mfojtik
From: Michal Fojtik * Reduce queries for Provider using INNER JOIN * Get rid of 'context' variable in database helpers * Don't query database twice when entity is created Signed-off-by: Michal fojtik --- server/lib/cimi/helpers/database_helper.rb | 31 +++--- server/lib

Re: DC's use of CIMI extensions

2012-12-11 Thread Doug Davis
The "properties" are really meant to be used by clients as a spot to put any random data that only it knows how to interpret. So, asking a client to put a piece of data in there that the server is to then use would go against that pattern. A better approach would be to define an extension top-l

[jira] [Created] (DTACLOUD-396) Random order of XML elements in CIMI (MRI 1.8)

2012-12-11 Thread Michal Fojtik (JIRA)
Michal Fojtik created DTACLOUD-396: -- Summary: Random order of XML elements in CIMI (MRI 1.8) Key: DTACLOUD-396 URL: https://issues.apache.org/jira/browse/DTACLOUD-396 Project: DeltaCloud Iss

Re: [PATCH core 2/2] CIMI: Moved helper methods out of db.rb to separe helper file

2012-12-11 Thread Michal Fojtik
On 12/10, David Lutterkort wrote: > I needed to make a small change: Yes, sorry for that. I found it when I get home, but you was faster :) -- Michal > > On Mon, 2012-12-10 at 11:11 +0100, mfoj...@redhat.com wrote: > > diff --git a/server/lib/cimi/helpers/database_helper.rb > > b/server/lib/

Re: DC's use of CIMI extensions

2012-12-11 Thread Michal Fojtik
On 12/10, Doug Davis wrote: > > All, > CIMI says: Each resource in the CIMI model has an attribute called > "properties." Consumers, when creating or updating a resource, may store > any name/value pair in the "properties" attribute. CIMI Providers shall > store and return these values to the C

[PATCH 2/2] Server tests - fixes openstack driver instances test - broken build

2012-12-11 Thread marios
From: marios https://travis-ci.org/mifo/deltacloud/jobs/3591100 Signed-off-by: marios --- server/tests/drivers/openstack/instances_test.rb | 34 +--- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/server/tests/drivers/openstack/instances_test.rb b/server/t