RE: [PATCH] DTACLOUD-462 - a GET for an instance can fail while a different instance is being destroyed.

2013-02-15 Thread Koper, Dies
I can imagine this kind of issue could occur for more providers and more cases. As for the fgcp, in many of the methods I get a list first of resource ids and then make subsequent calls for each to retrieve all the details I need. Although deleting with fgcp is an instant operation so it's not lik

Re: [PATCH core 3/4] Core: Make DeltacloudLogger compatible with Ruby Logger

2013-02-15 Thread David Lutterkort
On Fri, 2013-02-15 at 11:36 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > This patch will make our DeltacloudLogger more compatible > wit the default Ruby 'Logger' class. ACK David

Re: [PATCH] DTACLOUD-462 - a GET for an instance can fail while a different instance is being destroyed.

2013-02-15 Thread David Lutterkort
On Fri, 2013-02-15 at 14:51 -0800, David Lutterkort wrote: > What happens when somebody requests /api/instances while an instance is > being destroyed ? The fix you have for the single-instance case is spot > on, but we must also guard against tripping over this when listing all > instances. And D

Re: [PATCH core 2/4] CIMI: If API_VERBOSE is enabled, log into Deltacloud logger

2013-02-15 Thread David Lutterkort
On Fri, 2013-02-15 at 11:36 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > This patch will make sure that logs produced by Sequel (SQL logs) > will go to DeltacloudLogger instead of default Ruby Logger. > > The reason is that user can set the '-L/--log' option and redirect > all logs

Re: [PATCH core 1/4] Core: Added 'lib/initializers' directory

2013-02-15 Thread David Lutterkort
On Fri, 2013-02-15 at 11:36 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Before this patch, we used to initialize stuff like database > or mock directories in random places in source code. > > This patch should make all initialization happen in one place. ACK. Bringing some order

Re: [PATCH core 4/4] Tests: Use 'initializers' in all our tests.

2013-02-15 Thread David Lutterkort
On Fri, 2013-02-15 at 11:36 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > This patch will make possible to run our unit-tests without > initializing the Deltacloud.configure classes, because we already > do that in initializers. > > For CIMI tests, this will make sure the database d

[jira] [Commented] (DTACLOUD-475) Cannot connect to Deltacloud server started on Fedora 18 from a machine other than the host

2013-02-15 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579602#comment-13579602 ] David Lutterkort commented on DTACLOUD-475: --- Do you have anything interesting

Re: [PATCH] DTACLOUD-462 - a GET for an instance can fail while a different instance is being destroyed.

2013-02-15 Thread David Lutterkort
On Fri, 2013-02-15 at 15:43 -0500, jvl...@redhat.com wrote: > From: Joe VLcek ACK with a couple of comments: I would rewrite the commit message in the following way RHEV-M: avoid failure of GET instance details A backtrace was sporadically produced for a GET /ap

[jira] [Created] (DTACLOUD-485) RHEVm - Make sure we handle any new status added.

2013-02-15 Thread Joseph J. VLcek (JIRA)
Joseph J. VLcek created DTACLOUD-485: Summary: RHEVm - Make sure we handle any new status added. Key: DTACLOUD-485 URL: https://issues.apache.org/jira/browse/DTACLOUD-485 Project: DeltaCloud

DTACLOUD-462 - a GET for an instance can fail while a different instance is being destroyed.

2013-02-15 Thread jvlcek
This patch addresses JIRA DTACLOUD-462. The Indication: A backtrace was produced from a GET /api/instance/ The Problem: If a different instance is being destroyed during a GET for a different instance a backtrace is produced. This is because a query for all instances (vms) was being done. The li

[PATCH] DTACLOUD-462 - a GET for an instance can fail while a different instance is being destroyed.

2013-02-15 Thread jvlcek
From: Joe VLcek --- server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb index 65ba26d..9212c26 100644 --- a

[jira] [Commented] (DTACLOUD-462) RHEVM calling GET /api/instances/instance_id after the instance is stopped, errors out

2013-02-15 Thread Joseph J. VLcek (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579491#comment-13579491 ] Joseph J. VLcek commented on DTACLOUD-462: -- Patch sent for review. See tracker:

[jira] [Created] (DTACLOUD-484) RHEVm Need to handle GET for instances while some could be being destroyed.

2013-02-15 Thread Joseph J. VLcek (JIRA)
Joseph J. VLcek created DTACLOUD-484: Summary: RHEVm Need to handle GET for instances while some could be being destroyed. Key: DTACLOUD-484 URL: https://issues.apache.org/jira/browse/DTACLOUD-484

Re: [VOTE] Release Apache Deltacloud 1.1.1, rc2

2013-02-15 Thread David Lutterkort
On Wed, 2013-02-13 at 17:23 +0100, Michal Fojtik wrote: > I am very pleased to announce the availability of RC2 for Deltacloud > 1.1.1. The release candidate is available at > http://people.apache.org/~mfojtik/deltacloud/1.1.1rc2/ > > Please vote on the release candidate by Saturday 0900 EST (New

Re: [VOTE] Release Apache Deltacloud 1.1.1, rc2

2013-02-15 Thread mar...@redhat.com
On 13/02/13 18:23, Michal Fojtik wrote: > I am very pleased to announce the availability of RC2 for Deltacloud > 1.1.1. The release candidate is available at > http://people.apache.org/~mfojtik/deltacloud/1.1.1rc2/ > > Please vote on the release candidate by Saturday 0900 EST (New York, US > East

buckets_test.rb - adding check to cleanup for whether the collection is supported

2013-02-15 Thread rlandy
This patch fixes the error we were seeing when running deltacloud/tests/deltacloud aagainst providers that don't support the buckets collection. Please review and push if ACK'able. Thanks!

[PATCH 2/2] Tests: buckets_test.rb - adding check to cleanup for whether the collection is supported

2013-02-15 Thread rlandy
From: Ronelle Landy --- tests/deltacloud/buckets_test.rb | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/deltacloud/buckets_test.rb b/tests/deltacloud/buckets_test.rb index 3cff7f5..02f517b 100644 --- a/tests/deltacloud/buckets_test.rb +++ b/tests/de

[jira] [Commented] (DTACLOUD-462) RHEVM calling GET /api/instances/instance_id after the instance is stopped, errors out

2013-02-15 Thread Joseph J. VLcek (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579230#comment-13579230 ] Joseph J. VLcek commented on DTACLOUD-462: -- This Jira is rooted in multiple iss

[jira] [Created] (DTACLOUD-483) Digitalocean driver: No create_image op advertised

2013-02-15 Thread Ronelle Landy (JIRA)
Ronelle Landy created DTACLOUD-483: -- Summary: Digitalocean driver: No create_image op advertised Key: DTACLOUD-483 URL: https://issues.apache.org/jira/browse/DTACLOUD-483 Project: DeltaCloud

[jira] [Updated] (DTACLOUD-481) Digitalocean driver: Can't delete an STOPPED instance - delete op advertized on a RUNNING instance only

2013-02-15 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy updated DTACLOUD-481: --- Description: Note that the only op returned for a STOPPED instance below is /start: >> cu

[jira] [Created] (DTACLOUD-482) Digitalocean driver: Required to pass image_id, realm_is and hwp_id to create an instance - missing any errors out

2013-02-15 Thread Ronelle Landy (JIRA)
Ronelle Landy created DTACLOUD-482: -- Summary: Digitalocean driver: Required to pass image_id, realm_is and hwp_id to create an instance - missing any errors out Key: DTACLOUD-482 URL: https://issues.apache.org/ji

[jira] [Created] (DTACLOUD-481) Digitalocean driver: Can't delete an instance - No delete op returned for STOPPED instance

2013-02-15 Thread Ronelle Landy (JIRA)
Ronelle Landy created DTACLOUD-481: -- Summary: Digitalocean driver: Can't delete an instance - No delete op returned for STOPPED instance Key: DTACLOUD-481 URL: https://issues.apache.org/jira/browse/DTACLOUD-481

Re: sinatra docs

2013-02-15 Thread Michal Fojtik
On 02/15, Koper, Dies wrote: Thanks for reporting this! This was a MRI 1.8 issue. Should be fixed now. I pushed new version to rubygems, so executing 'gem update sinatra-rabbit' or 'bundle' should fix it :) -- Michal > Hi Michal, > > FYI, I was just experimenting with the online Sinatra docs

Re: [PATCH] FGCP: copied image size into InstanceProfile's :storage. Allows cimi /disks to work

2013-02-15 Thread Michal Fojtik
On 02/15, di...@fast.au.fujitsu.com wrote: ACK. > From: Dies Koper > > --- > server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb > b/server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb >

[PATCH] FGCP: copied image size into InstanceProfile's :storage. Allows cimi /disks to work

2013-02-15 Thread diesk
From: Dies Koper --- server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb b/server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb index 5cf957a..af61fe9 100644 --- a/server/lib/deltacloud/drivers/fg

Not closed tags issues

2013-02-15 Thread Michal Fojtik
Hi, Many users of Deltacloud are reporting not closed tags after update or after the fresh install. This issue is caused by the new HAML (4.0) gem, that introduced several backward compatibility issues. While this issue is currently fixed in the GIT master, it might hit users of the old versions

Re: Introducing 'initializers'

2013-02-15 Thread Michal Fojtik
On 02/15, mfoj...@redhat.com wrote: Also recorded here: http://tracker.deltacloud.org/set/318 > Hi, > > This patch is something like a 'cleanup' in the way how we initialize > things when Deltacloud server is starting up. > > Right now, these things are 'initialized' during server boot: > > 1

RE: [PATCH] CIMI: system and system_template support for mock driver. Just GET for now, no subcollections

2013-02-15 Thread Koper, Dies
GET on /cimi/system_templates returns the following: d:\projects>curl --user mockuser:mockpassword "http://localhost:3001/cimi/system_templates/template1?format=xml"; http://schemas.dmtf.org/cimi/1"; resourceURI="http://schemas.dmtf.org/cimi/1/SystemTemplate";> http://localhost:3001/cimi/system_

[PATCH core 4/4] Tests: Use 'initializers' in all our tests.

2013-02-15 Thread mfojtik
From: Michal Fojtik This patch will make possible to run our unit-tests without initializing the Deltacloud.configure classes, because we already do that in initializers. For CIMI tests, this will make sure the database directory exists. Signed-off-by: Michal fojtik --- server/tests/cimi/coll

[PATCH core 1/4] Core: Added 'lib/initializers' directory

2013-02-15 Thread mfojtik
From: Michal Fojtik Before this patch, we used to initialize stuff like database or mock directories in random places in source code. This patch should make all initialization happen in one place. Signed-off-by: Michal fojtik --- server/config.ru | 65 +---

[PATCH core 2/4] CIMI: If API_VERBOSE is enabled, log into Deltacloud logger

2013-02-15 Thread mfojtik
From: Michal Fojtik This patch will make sure that logs produced by Sequel (SQL logs) will go to DeltacloudLogger instead of default Ruby Logger. The reason is that user can set the '-L/--log' option and redirect all logs into a file. In that case, this patch will make sure that SQL logs are sav

[PATCH core 3/4] Core: Make DeltacloudLogger compatible with Ruby Logger

2013-02-15 Thread mfojtik
From: Michal Fojtik This patch will make our DeltacloudLogger more compatible wit the default Ruby 'Logger' class. Signed-off-by: Michal fojtik --- server/lib/sinatra/rack_logger.rb | 59 +++ 1 file changed, 35 insertions(+), 24 deletions(-) diff --git a/se

Introducing 'initializers'

2013-02-15 Thread mfojtik
Hi, This patch is something like a 'cleanup' in the way how we initialize things when Deltacloud server is starting up. Right now, these things are 'initialized' during server boot: 1. Mock directory is created and populated (this happen in mock driver) 2. Database file and schema is created (db

[PATCH] CIMI: system and system_template support for mock driver. Just GET for now, no subcollections

2013-02-15 Thread diesk
From: Dies Koper --- server/lib/cimi/collections/system_templates.rb| 72 server/lib/cimi/collections/systems.rb | 198 + server/lib/cimi/models.rb | 2 + server/lib/cimi/models/system.rb | 68 +++ se