Re: [PATCH] rename vsp to networkPort

2013-02-19 Thread Martha Chumo
Yea, the error was in the create method for networkPort, so I could not write a post method for networkPort for the webapp. On Wed, Feb 20, 2013 at 3:45 AM, David Lutterkort wrote: > On Mon, 2013-02-18 at 17:05 +0300, martha.c.ch...@gmail.com wrote: > > From: NjeriChelimo > > ACK & pushed. > >

Re: [PATCH 2/2] renaming vsp to network and removing CIMI client vsp view files

2013-02-19 Thread Martha Chumo
This patch is totally wrong. i somehow changed vsp -> network, which is an error. Marios had raised this on irc. On Wed, Feb 20, 2013 at 3:40 AM, David Lutterkort wrote: > On Mon, 2013-02-18 at 15:27 +0300, martha.c.ch...@gmail.com wrote: > > From: NjeriChelimo > > > > --- > > clients/cimi/app

RE: [PATCH] CIMI: system and system_template support for mock driver, with unit tests. Just GET for now, no subcollections

2013-02-19 Thread Koper, Dies
Hi David, > > +set :capability, lambda { |t| true } > > Is this intentional/still needed to avoid the problems that you were > seeing ? If it's meant to stay here, it needs a big FIXME comment; > without a proper capability check, system_templates will be advertised > for any driver. I'll ch

Re: [PATCH] CIMI: system and system_template support for mock driver, with unit tests. Just GET for now, no subcollections

2013-02-19 Thread David Lutterkort
On Tue, 2013-02-19 at 13:59 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper ACK, with a few comments and suggestions for changes before commit: > diff --git a/server/lib/cimi/collections/system_templates.rb > b/server/lib/cimi/collections/system_templates.rb > new file mode 100644 >

[PATCH 3/4] Encapsulate the test for whether we need a DB in Deltacloud::need_database?

2013-02-19 Thread lutter
From: David Lutterkort --- server/lib/deltacloud_rack.rb | 4 server/lib/initialize.rb | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/server/lib/deltacloud_rack.rb b/server/lib/deltacloud_rack.rb index 32ff4e8..dbf51fc 100644 --- a/server/lib/deltacloud_rack.

[PATCH 4/4] * tests/test_helper.rb: run all initializers under the test environment

2013-02-19 Thread lutter
From: David Lutterkort This makes it possible to run individual tests again --- server/tests/test_helper.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/tests/test_helper.rb b/server/tests/test_helper.rb index ff16de4..8d8073f 100644 --- a/server/tests/test_he

Make running individual tests possible again

2013-02-19 Thread lutter
The various changes concerning initializers broke running individual tests (e.g., with 'ruby ./tests/cimi/model/machine_spec.rb' These patches shuffle things around so that that works again. David

[PATCH 2/4] * lib/cimi/helpers/database_helper.rb (test_environment?): remove, unused

2013-02-19 Thread lutter
From: David Lutterkort --- server/lib/cimi/helpers/database_helper.rb | 4 1 file changed, 4 deletions(-) diff --git a/server/lib/cimi/helpers/database_helper.rb b/server/lib/cimi/helpers/database_helper.rb index 05fdd81..7e5f99a 100644 --- a/server/lib/cimi/helpers/database_helper.rb +++

[PATCH 1/4] Make configured frontends available as method on Deltacloud

2013-02-19 Thread lutter
From: David Lutterkort --- server/config.ru | 2 +- server/lib/deltacloud_rack.rb | 7 ++- server/lib/initializers/frontend_initialize.rb | 7 --- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/server/config.ru b/server/confi

[jira] [Updated] (DTACLOUD-471) Need to cleanly skip CIMI Resource Metadata tests for unsupported capabilities

2013-02-19 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy updated DTACLOUD-471: --- Attachment: 0003-CIMI-Tests-cleanly-skip-CIMI-Resource-Metadata-tests.patch > Need to c

[jira] [Resolved] (DTACLOUD-471) Need to cleanly skip CIMI Resource Metadata tests for unsupported capabilities

2013-02-19 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy resolved DTACLOUD-471. Resolution: Fixed Sent a patch to skip rmd tests for providers that don't support the rmd

Re: [PATCH] rename vsp to networkPort

2013-02-19 Thread David Lutterkort
On Mon, 2013-02-18 at 17:05 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK & pushed. I assume there's some more work connected to this rename for the webapp. It's unfortunate that we do not have any unit tests for network_ports ... somebody should write them. David

Re: [PATCH 2/2] renaming vsp to network and removing CIMI client vsp view files

2013-02-19 Thread David Lutterkort
On Mon, 2013-02-18 at 15:27 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/app.rb|4 > clients/cimi/lib/entities.rb |3 --- > server/lib/cimi/models/network_port.rb | 34 > > 3 file

Re: [PATCH 1/2] changed routing_group to forwarding_group

2013-02-19 Thread David Lutterkort
On Mon, 2013-02-18 at 15:27 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK and pushed. David

Re: [PATCH] CIMI webapp: creating new volume configs

2013-02-19 Thread David Lutterkort
On Wed, 2013-02-13 at 13:08 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/lib/entities/volume_configuration.rb | 20 ++ > clients/cimi/views/machine_templates/index.haml| 12 > .../cimi/views/volume_configurations/index.haml|

Re: [PATCH] routes and view files for forwarding_groups and forwarding_group_templates

2013-02-19 Thread David Lutterkort
On Wed, 2013-02-13 at 13:08 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo This seems to be mostly the same as the 3 patches you sent previously (and that we neglected to commit); if there is anything that you'd like to commit on top of them, please rebase/resend the patch. David

Re: [PATCH] CIMI Webapp - Creating volume_images

2013-02-19 Thread David Lutterkort
On Wed, 2013-02-13 at 13:08 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/lib/entities/volume_image.rb | 21 + > clients/cimi/views/volume_images/index.haml | 26 ++ > 2 files changed, 47 insertions(+) When I

Re: [PATCH 3/3] DTACLOUD_404 Added view file for machine disks

2013-02-19 Thread David Lutterkort
On Tue, 2013-01-22 at 11:39 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK & pushed. One comment: > diff --git a/clients/cimi/lib/entities/machine.rb > b/clients/cimi/lib/entities/machine.rb > index 941f738..2708e4b 100644 > --- a/clients/cimi/lib/entities/machine.rb > +++ b/cl

Re: [PATCH 2/3] DTACLOUD-409 added forward_group view files and forward_group.rb to entities

2013-02-19 Thread David Lutterkort
On Tue, 2013-01-22 at 11:39 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK & pushed David

Re: [PATCH 1/3] DTACLOUD-409: added forward_group_template view files and forward_group_template.rb to entities

2013-02-19 Thread David Lutterkort
On Tue, 2013-01-22 at 11:39 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/app.rb|1 + > clients/cimi/lib/entities.rb |1 + > .../cimi/lib/entities/forwarding_group_template.rb | 30 > +++

Re: [PATCH core 7/7] CIMI: Print warning for pending migrations

2013-02-19 Thread David Lutterkort
On Tue, 2013-02-19 at 10:10 +0100, Michal Fojtik wrote: > > * do we really need a separate deltacloud-db-upgrade script rather > > than just the rake task ? I don't have an issue with requiring > > that people have rake on their prod systems (what's good enough > > for

[PATCH 1/3] CIMI: Tests - minor changes to support other providers

2013-02-19 Thread rlandy
From: Ronelle Landy --- tests/cimi/part5_test.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cimi/part5_test.rb b/tests/cimi/part5_test.rb index 566ef26..8f2eea2 100644 --- a/tests/cimi/part5_test.rb +++ b/tests/cimi/part5_test.rb @@ -79,7 +79,7 @@ class Man

[PATCH 3/3] CIMI - Tests - cleanly skip CIMI Resource Metadata tests for unsupported capabilities DTACLOUD-471

2013-02-19 Thread rlandy
From: Ronelle Landy --- tests/cimi/rmd3_test.rb | 53 ++--- tests/cimi/rmd4_test.rb | 147 +++- tests/cimi/test_helper.rb | 21 +++ 3 files changed, 130 insertions(+), 91 deletions(-) diff --git a/tests/cimi/rmd3_test.rb b/tests/c

[PATCH 2/3] Tests: buckets_test.rb - adding check to cleanup for whether the collection is supported

2013-02-19 Thread rlandy
From: Ronelle Landy --- tests/deltacloud/buckets_test.rb | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/deltacloud/buckets_test.rb b/tests/deltacloud/buckets_test.rb index 3cff7f5..02f517b 100644 --- a/tests/deltacloud/buckets_test.rb +++ b/tests/de

[jira] [Closed] (DTACLOUD-473) Creating an instance in RHEVM 3.0 using Deltacloud ruby client errors out

2013-02-19 Thread Joseph J. VLcek (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph J. VLcek closed DTACLOUD-473. Resolution: Cannot Reproduce I've investigated and I'm wondering if this might be a "cock

Re: [PATCH 1/2] Deltacloud OpenStack driver - remap 'regions' to 'providers' DTACLOUD-488

2013-02-19 Thread Michal Fojtik
On 02/19, mar...@redhat.com wrote: > On 19/02/13 18:54, Michal Fojtik wrote: > > On 02/19, mar...@redhat.com wrote: > > > > ACK, some minor coding/formatting hints inline :) > > > > -- Michal > > > >> From: marios > >> > >> https://issues.apache.org/jira/browse/DTACLOUD-488 > >> > >> Signed-o

Re: [PATCH 1/2] Deltacloud OpenStack driver - remap 'regions' to 'providers' DTACLOUD-488

2013-02-19 Thread mar...@redhat.com
On 19/02/13 18:54, Michal Fojtik wrote: > On 02/19, mar...@redhat.com wrote: > > ACK, some minor coding/formatting hints inline :) > > -- Michal > >> From: marios >> >> https://issues.apache.org/jira/browse/DTACLOUD-488 >> >> Signed-off-by: marios >> --- >> .../drivers/openstack/openstack_d

Re: [PATCH 2/2] Deltacloud - remove unused 'resource_types' attribute from Realm model part of DTACLOUD-488 https://issues.apache.org/jira/browse/DTACLOUD-488

2013-02-19 Thread Michal Fojtik
On 02/19, mar...@redhat.com wrote: ACK -- Michal > From: marios > > API-Change: remove unused 'resource_types' attribute from Realm > > Signed-off-by: marios > --- > server/lib/deltacloud/models/realm.rb | 7 --- > server/views/realms/index.html.haml | 2 -- > server/views/realms/sh

Re: [PATCH 1/2] Deltacloud OpenStack driver - remap 'regions' to 'providers' DTACLOUD-488

2013-02-19 Thread Michal Fojtik
On 02/19, mar...@redhat.com wrote: ACK, some minor coding/formatting hints inline :) -- Michal > From: marios > > https://issues.apache.org/jira/browse/DTACLOUD-488 > > Signed-off-by: marios > --- > .../drivers/openstack/openstack_driver.rb | 114 > +++-- > 1 fil

[jira] [Commented] (DTACLOUD-477) Openstack provider: Realms id not correctly reported from GET /api/instance/Instance_id

2013-02-19 Thread Marios Andreou (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581430#comment-13581430 ] Marios Andreou commented on DTACLOUD-477: - I believe this issue is linked to and

[jira] [Updated] (DTACLOUD-488) Openstack driver - re-map regions to providers rather than realms

2013-02-19 Thread Marios Andreou (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Andreou updated DTACLOUD-488: Attachment: 0002-Deltacloud-remove-unused-resource_types-attribute-fr.patch

[PATCH 2/2] Deltacloud - remove unused 'resource_types' attribute from Realm model part of DTACLOUD-488 https://issues.apache.org/jira/browse/DTACLOUD-488

2013-02-19 Thread marios
From: marios API-Change: remove unused 'resource_types' attribute from Realm Signed-off-by: marios --- server/lib/deltacloud/models/realm.rb | 7 --- server/views/realms/index.html.haml | 2 -- server/views/realms/show.html.haml| 4 server/views/realms/show.xml.haml | 3 ---

[PATCH 1/2] Deltacloud OpenStack driver - remap 'regions' to 'providers' DTACLOUD-488

2013-02-19 Thread marios
From: marios https://issues.apache.org/jira/browse/DTACLOUD-488 Signed-off-by: marios --- .../drivers/openstack/openstack_driver.rb | 114 +++-- 1 file changed, 58 insertions(+), 56 deletions(-) diff --git a/server/lib/deltacloud/drivers/openstack/openstack_driver.rb

DTACLOUD-488 Openstack Regions to Deltacloud Providers

2013-02-19 Thread marios
Patches also available at http://tracker.deltacloud.org/set/328 Comments/explanation is on the JIRA ticket at https://issues.apache.org/jira/browse/DTACLOUD-488 marios

[jira] [Created] (DTACLOUD-488) Openstack driver - re-map regions to providers rather than realms

2013-02-19 Thread Marios Andreou (JIRA)
Marios Andreou created DTACLOUD-488: --- Summary: Openstack driver - re-map regions to providers rather than realms Key: DTACLOUD-488 URL: https://issues.apache.org/jira/browse/DTACLOUD-488 Project: De

[jira] [Updated] (DTACLOUD-470) CIMI: creating networks returing 412.

2013-02-19 Thread Marios Andreou (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Andreou updated DTACLOUD-470: Attachment: 0001-Restore-mock-network-operations-removed-by-commit-d4.patch Attached patc

[PATCH] Restore mock network operations removed by commit d4d8e38897152671a2f99edeab95c3a146a231cf

2013-02-19 Thread marios
From: marios part of DTACLOUD-470 https://issues.apache.org/jira/browse/DTACLOUD-470 Signed-off-by: marios --- server/lib/cimi/models/network.rb | 12 ++--- server/lib/deltacloud/drivers/mock/mock_client.rb | 14 ++ .../drivers/mock/mock_driver_cimi_methods.rb | 52

DTACLOUD-470

2013-02-19 Thread marios
tracked at http://tracker.deltacloud.org/set/327 This is the first of the commits restoring the removed (cimi) mock network operations that were removed by commit d4d8e38897152671a2f99edeab95c3a146a231cf This patch only includes networks because of an anticipated conflict with tracker set 322 th

Basic RHEV networking support

2013-02-19 Thread jprovazn
Hi, this patch depends on Marios' "Network API Models - RFC" patchset. It should not be pushed into repo, its purpose is to better understand RHEV network possibilities before deciding next steps. This patch implements listing of logical networks for RHEV. Network create/destroy actions is not som

Re: [PATCH core] Core: Fixed latest 'excon' which breaks the VCR fixtures

2013-02-19 Thread mar...@redhat.com
ACK On 19/02/13 13:12, mfoj...@redhat.com wrote: > From: Michal Fojtik > > The 'excon' was updated it 0.17.0 which ultimately breaks > the VCR fixtures we are using (rake test:drivers:google). > > Saying that we don't want to update it in gemspec should > fix this issue. > > Signed-off-by: Mic

[PATCH core] Mock:Cleanup in MockDriver code

2013-02-19 Thread mfojtik
From: Michal Fojtik - Removed obsoleted 'requires' (yaml, base64, etc) - REALMS moved to 'realms' method - @@METRICS_NAMES moved to Metric model - Revamped 'filter_on' methods - Next 'id' generation moved to separate method a lot of small changes ... - Improved collection filtering filter() metho

Re: [PATCH core 4/8] Core: Added possibility to run filter_on with multiple attrs

2013-02-19 Thread Michal Fojtik
On 02/18, David Lutterkort wrote: > On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > > From: Michal Fojtik > > > > So instead of writing: > > > > instances = filter_on instances, :id, opts > > instances = filter_on instances, :realm_id, opts > > instances = filter_on instances, :st

Re: [PATCH] cimi frontend initializers

2013-02-19 Thread Michal Fojtik
On 02/19, martha.c.ch...@gmail.com wrote: ACK. ;-) > From: NjeriChelimo > > --- > clients/cimi/init.rb |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/clients/cimi/init.rb b/clients/cimi/init.rb > index 9492b0b..92f32d6 100644 > --- a/clients/cimi/init.rb > +++ b/clients/cimi/in

[PATCH core] Core: Fixed latest 'excon' which breaks the VCR fixtures

2013-02-19 Thread mfojtik
From: Michal Fojtik The 'excon' was updated it 0.17.0 which ultimately breaks the VCR fixtures we are using (rake test:drivers:google). Saying that we don't want to update it in gemspec should fix this issue. Signed-off-by: Michal fojtik --- server/deltacloud-core.gemspec | 2 +- 1 file chang

Re: Launching the CIMI webclient

2013-02-19 Thread Martha Chumo
Sent out that fix. On Tue, Feb 19, 2013 at 1:24 PM, Michal Fojtik wrote: > On 02/18, David Lutterkort wrote: > > This was broken recently by initializers and Martha should have fix for > this now :) > > -- Michal > > > Hi, > > > > I just tried to launch the CIMI webclient from a git checkout,

[PATCH] cimi frontend initializers

2013-02-19 Thread martha . c . chumo
From: NjeriChelimo --- clients/cimi/init.rb |2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/cimi/init.rb b/clients/cimi/init.rb index 9492b0b..92f32d6 100644 --- a/clients/cimi/init.rb +++ b/clients/cimi/init.rb @@ -28,4 +28,6 @@ require 'entities' $:.unshift File.join('..',

Re: Launching the CIMI webclient

2013-02-19 Thread Michal Fojtik
On 02/18, David Lutterkort wrote: This was broken recently by initializers and Martha should have fix for this now :) -- Michal > Hi, > > I just tried to launch the CIMI webclient from a git checkout, following > the instructions in clients/cimi/README.md > > When I run './bin/start -u "http

Re: A couple fixes related to initializers

2013-02-19 Thread Michal Fojtik
On 02/18, lut...@redhat.com wrote: > > There was a typo in the mock initializer, and the Rakefile needed updating ACK to serie. -- Michal -- Michal Fojtik Deltacloud API, CloudForms

Re: [PATCH] FGCP: added error handling to exclude resources that were deleted in the middle of a GET operation

2013-02-19 Thread Michal Fojtik
On 02/19, di...@fast.au.fujitsu.com wrote: ACK. (minor nit: can you make the commit message a bit shorter? :-) -- Michal > From: Dies Koper > > --- > server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb | 136 > -- > 1 file changed, 77 insertions(+), 59 deletions(-) > >

Re: [PATCH] FGCP: added unit tests for storage_volumes and fixed error with unknown id

2013-02-19 Thread Michal Fojtik
On 02/19, di...@fast.au.fujitsu.com wrote: ACK > From: Dies Koper > > --- > server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb | 3 + > ...st_0002_must_return_list_of_storage_volumes.yml | 207 > + > ...t_0003_must_allow_to_filter_storage_volumes.yml | 118 >

[ANNOUNCE]: Deltacloud Community Call #12

2013-02-19 Thread mar...@redhat.com
The Twelfth Deltacloud Community call will be held today: Tuesday, 19th February 2013 @ 1500 CET (Central Europe, Berlin, Prague) (for other timezones see): http://www.timeanddate.com/worldclock/meetingdetails.html?year=2013&month=2&day=19&hour=14&min=0&sec=0&p1=680&p2=204&p3=179&p4=224&p5=170&p6

[ANNOUNCE] Apache Deltacloud 1.1.1

2013-02-19 Thread Michal Fojtik
I am pleased to announce the general availability of Apache Deltacloud 1.1.1. The release can be found at [1] (may take a day/two before the mirrors [2] catch up). Details about all the changes in this release are at [3]. The deltacloud-core server and client ruby gems are now available on rubyg

[VOTE][RESULT] release deltacloud 1.1.1, rc2

2013-02-19 Thread Michal Fojtik
The vote for releasing Deltacloud v 1.1.1 rc2 ended in four +1, no 0 or -1. Thus, the release of Deltacloud 1.1.1 rc2 is approved. A separate mail will follow with the announcement and links to the release location. -- Michal -- Michal Fojtik Deltacloud API, CloudForms

Re: [PATCH core 7/7] CIMI: Print warning for pending migrations

2013-02-19 Thread Michal Fojtik
On 02/18, David Lutterkort wrote: > This strikes me as more clever than it needs to be: > * we should exit(1) if there are pending migrations - there's no > point in starting the server otherwise. Yes, makes sense to me. > * can't deltacloud-db-upgrade just blindly run >

Re: [PATCH core 1/8] Core: Fix rake mock:fixtures:reset tasks to cleanup correct dir

2013-02-19 Thread Michal Fojtik
On 02/18, David Lutterkort wrote: > On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > > From: Michal Fojtik > > > > > > Signed-off-by: Michal fojtik > > ACK, though I prefer the patch I sent for this, since it relies on the > initializers doing their thing rather than redoing it i