Re: RFC: Separate CIMI (de)serialization from server functionality (rev 3)

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 17:33 -0700, lut...@redhat.com wrote: > This is the third take on splitting server-side functionality out of our > models. As in previous attempts, CIMI::Model is now solely concerned with > (se)serialization, whereas CIMI::Service does all the actual server-side > functionali

[PATCH 14/14] CIMI: remove unused model methods

2013-03-13 Thread lutter
From: David Lutterkort Collection.all and Resource.all_uri do not make sense any more since they ultimately depend on find, which is now a service method. --- server/lib/cimi/models/collection.rb | 6 -- server/lib/cimi/models/resource.rb | 6 -- 2 files changed, 12 deletions(-) diff

[PATCH 13/14] CIMI: a very simple test of volume creation

2013-03-13 Thread lutter
From: David Lutterkort --- server/tests/cimi/collections/volumes_test.rb | 42 +++ 1 file changed, 42 insertions(+) create mode 100644 server/tests/cimi/collections/volumes_test.rb diff --git a/server/tests/cimi/collections/volumes_test.rb b/server/tests/cimi/collectio

[PATCH 11/14] * server/lib/cimi/service/machine_template.rb (delete!): fix 500 error

2013-03-13 Thread lutter
From: David Lutterkort The method was simply busted. Now also allows deletion of nonexisting templates --- server/lib/cimi/service/machine_template.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/lib/cimi/service/machine_template.rb b/server/lib/cimi/service/mac

[PATCH 09/14] CIMI: Use CIMI::Service namespace in Rabbit collections

2013-03-13 Thread lutter
From: Michal Fojtik Signed-off-by: Michal fojtik TrackedAt: http://tracker.deltacloud.org/patch/4f61366999285c2dfbc497bdc0581c8b657d9191 --- server/lib/cimi/collections/address_templates.rb | 8 ++--- server/lib/cimi/collections/addresses.rb | 8 ++--- server/lib/cimi/collections

[PATCH 12/14] CIMI::Model::Schema::Ref: do not support looking up the referenced object

2013-03-13 Thread lutter
From: David Lutterkort This now depends on service objects and can therefore not be used from models --- server/lib/cimi/models/schema.rb | 14 -- 1 file changed, 14 deletions(-) diff --git a/server/lib/cimi/models/schema.rb b/server/lib/cimi/models/schema.rb index b6651a7..5a2049b

[PATCH 10/14] CIMI: make ResourceMetadata work with the Model/Service split

2013-03-13 Thread lutter
From: David Lutterkort Extension attributes now need to be mentioned twice: in the model class they are declared like any other attribute. In the service class, resource metadata can be added using metadata attr_name, :type => TYPE, :constraints => PROC --- server/lib/cimi/models/cloud_entry_

[PATCH 07/14] CIMI: Added Service::Base#parse method

2013-03-13 Thread lutter
From: Michal Fojtik Make possible to call .parse on Service models from Rabbit collections. Signed-off-by: Michal fojtik TrackedAt: http://tracker.deltacloud.org/patch/a16895d3bb6ab3596fb77fee96d041e01c3a1747 --- server/lib/cimi/service/base.rb | 7 +++ 1 file changed, 7 insertions(+) di

[PATCH 06/14] CIMI: Migrated MachineImage to services

2013-03-13 Thread lutter
From: Michal Fojtik Signed-off-by: Michal fojtik TrackedAt: http://tracker.deltacloud.org/patch/ac7d8b3fe7354da3cb2d29400632bfe36694556d --- server/lib/cimi/collections/machine_images.rb | 6 ++-- server/lib/cimi/models/machine_image.rb | 28 --- server/lib/cimi/service.rb

[PATCH 05/14] CIMI: Apply $filter and $select in Base#list

2013-03-13 Thread lutter
From: Michal Fojtik No need to have ugly chained methods in collections. Signed-off-by: Michal fojtik TrackedAt: http://tracker.deltacloud.org/patch/c2417e1f3383ae4a76e1d40d04440daed149bf95 --- server/lib/cimi/collections/machines.rb | 2 +- server/lib/cimi/service/base.rb | 2 +- 2 f

[PATCH 02/14] CIMI (schema): properly generate and track embedded collection classes

2013-03-13 Thread lutter
From: David Lutterkort --- server/lib/cimi/models/schema.rb | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/server/lib/cimi/models/schema.rb b/server/lib/cimi/models/schema.rb index b4e9377..9c27c6f 100644 --- a/server/lib/cimi/models/schema.rb +++ b/server/lib/cimi/mo

[PATCH 01/14] CIMI Models: rename hash in DSL to hash_map

2013-03-13 Thread lutter
From: David Lutterkort Since 'hash' is used for putting objects into Hash, overriding it as a class method causes surprises when a class is used as a hash key. --- server/lib/cimi/models/base.rb| 2 +- server/lib/cimi/models/schema.rb | 2 +- server/lib/cimi/models/system_te

[PATCH 04/14] CIMI: split models into model and service objects

2013-03-13 Thread lutter
From: David Lutterkort The current CIMI::Model classes address two concerns: * serialization/deserialization of CIMI objects * interaction with the current driver and the DB This patch splits these two concerns into two separate class hierarchies: CIMI::Model for (de)serialization and CIMI:

[PATCH 03/14] DB Entity: make sure we instantiate the correct subclass

2013-03-13 Thread lutter
From: David Lutterkort We only ever instantiated Database::Entity, but never any of its subclasses. We now keep a map of CIMI::Model => Database::Entity subclass and call new on the appropriate subclass of Entity. --- server/lib/db/entity.rb | 17 - 1 file changed, 16 insertions(

RFC: Separate CIMI (de)serialization from server functionality (rev 3)

2013-03-13 Thread lutter
This is the third take on splitting server-side functionality out of our models. As in previous attempts, CIMI::Model is now solely concerned with (se)serialization, whereas CIMI::Service does all the actual server-side functionality. FWIW, the unit and blackbox tests all pass for me with this pa

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread jvlcek
On 03/13/2013 01:41 PM, David Lutterkort wrote: > On Wed, 2013-03-13 at 08:50 -0400, jvlcek wrote: >> On 03/12/2013 06:26 PM, David Lutterkort wrote: >>> On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote: From: Joe VLcek This is required to better describe recent changes >>

CIMI - Tests - extended machine scenarios part 2 and plan corrections

2013-03-13 Thread rlandy
- Removed deltaclou specific part 5 and ^ in previous plan revision - Restarting a machine test included

[PATCH] CIMI - Tests - extended machine scenarios part 2 and plan corrections

2013-03-13 Thread rlandy
From: Ronelle Landy --- tests/cimi/machex2_test.rb | 95 ++ tests/cimi/plan/scMachEx.xml | 611 +++ tests/cimi/plan/scRMD_rev2.xml | 619 3 files changed, 1325 insertions(+), 0 deletions(-) create mode 10

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 08:50 -0400, jvlcek wrote: > On 03/12/2013 06:26 PM, David Lutterkort wrote: > > On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote: > >> From: Joe VLcek > >> > >> This is required to better describe recent changes > >> for parameterizing recording and provider config

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 10:05 +1100, Koper, Dies wrote: > I've been wondering something about this re-recording. > In the fgcp unit tests I have ' :record => :new_episodes' in default cassette > options. > The first time I run new tests, it does a recording. If I want to rerecord, I > delete the re

[VOTE] Release Apache Deltacloud 1.1.2, rc1

2013-03-13 Thread Michal Fojtik
I am very pleased to announce the availability of RC1 for Deltacloud 1.1.1. The release candidate is available at http://people.apache.org/~mfojtik/deltacloud/1.1.2rc1/ Please vote on the release candidate by Saturday 0900 EST (New York, US East Coast, UTC -5 hours) KEYS: http://www.apache.org/di

Re: coloured dots

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 20:57 +1100, Koper, Dies wrote: > Hi Michal, > > I tried adding the following to Gemfile but it made no difference. > > platforms :mswin do > gem 'win32console' > end > > However, when I run the tests directly (i.e. ruby > tests\cimi\collections\system_templates_test.rb),

[jira] [Closed] (DTACLOUD-407) CIMI ForwardingGroups broken link

2013-03-13 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy closed DTACLOUD-407. -- Closing JIRA as fixed in deltacloud commit version: 56c1c7f56a99b83169c7cb945f4c746ece549cf1

[jira] [Commented] (DTACLOUD-484) RHEVm Need to handle GET for instances while some could be being destroyed.

2013-03-13 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601227#comment-13601227 ] Ronelle Landy commented on DTACLOUD-484: waiting for new rbovirt gem to be avail

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread jvlcek
On 03/13/2013 08:50 AM, jvlcek wrote: > On 03/12/2013 06:26 PM, David Lutterkort wrote: >> On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote: >>> From: Joe VLcek >>> >>> This is required to better describe recent changes >>> for parameterizing recording and provider configuration >>> of c

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread jvlcek
On 03/13/2013 09:14 AM, Koper, Dies wrote: > Hi Joe, > > Thanks, that explanation seems to match what I was thinking. > >> new HTTP requests will be made.Which according to my understanding is >> the safer approach. > Safe because of what? > With ' :record => :new_episodes', when a fixture is accid

[jira] [Closed] (DTACLOUD-361) fgcp: return actual IP address instead of dummy when creating new address

2013-03-13 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy closed DTACLOUD-361. -- Closing issue as fixed (before) deltacloud commit version: 56c1c7f56a99b83169c7cb945f4c746ece549

[jira] [Closed] (DTACLOUD-489) More verbose reporting of internal server errors

2013-03-13 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy closed DTACLOUD-489. -- Closing issue as fixed in deltacloud commit version: 56c1c7f56a99b83169c7cb945f4c746ece549cf1

[jira] [Closed] (DTACLOUD-343) Can't pass realm id when creating a new machine via the CIMI API

2013-03-13 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy closed DTACLOUD-343. -- Fixed in deltacloud commit version: 56c1c7f56a99b83169c7cb945f4c746ece549cf1 realm is now correc

Re: Deltacloud Community Call #15 - 13th Feburary 2013 (today)

2013-03-13 Thread Michal Fojtik
On 03/13, Michal Fojtik wrote: The hangout link: https://plus.google.com/hangouts/_/83def17f90f65d72f955f3b4920b092b771a06cc?authuser=0&hl=en -- Michal > On 03/12, mar...@redhat.com wrote: > > Hi, > > There will be a small change in agenda for today. Since marios can't join > this time, I'l

[jira] [Closed] (DTACLOUD-241) floppyinject silently fails on RHEVM

2013-03-13 Thread Ronelle Landy (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ronelle Landy closed DTACLOUD-241. -- Closing this JIRA out - RHEVM has started to use vmpayload by default - also noting that this is

RE: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread Koper, Dies
Hi Joe, Thanks, that explanation seems to match what I was thinking. > new HTTP requests will be made.Which according to my understanding is > the safer approach. Safe because of what? With ' :record => :new_episodes', when a fixture is accidentally deleted, it will try to connect to the endpoi

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread jvlcek
On 03/12/2013 07:05 PM, Koper, Dies wrote: > I've been wondering something about this re-recording. > In the fgcp unit tests I have ' :record => :new_episodes' in default cassette > options. > The first time I run new tests, it does a recording. If I want to rerecord, I > delete the relevant fixt

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread jvlcek
On 03/12/2013 06:26 PM, David Lutterkort wrote: > On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote: >> From: Joe VLcek >> >> This is required to better describe recent changes >> for parameterizing recording and provider configuration >> of credentials and resources to avoid having to ed

Re: [PATCH core 2/2] core: views got modified due to tilt template changes

2013-03-13 Thread Michal Fojtik
On 03/13, Francesco Vollero wrote: NAK, but you are on the good way :-) There are still some places where we do use instance variables in views. Also you should check the 'non-standard' operations in Rabbit collections as they don't use 'show()' and 'index()' helpers everytime (for example instan

[PATCH core 2/2] core: views got modified due to tilt template changes

2013-03-13 Thread Francesco Vollero
Signed-off-by: Francesco Vollero --- server/views/addresses/index.xml.haml | 2 +- server/views/addresses/show.xml.haml | 18 +++ server/views/buckets/index.xml.haml | 2 +- server/views/buckets/show.xml.haml| 12 ++--- server/views/hardware_profiles/

[PATCH core 1/2] core: pass the locals properly due to tilt template changes

2013-03-13 Thread Francesco Vollero
Signed-off-by: Francesco Vollero --- server/lib/deltacloud/helpers/deltacloud_helper.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/lib/deltacloud/helpers/deltacloud_helper.rb b/server/lib/deltacloud/helpers/deltacloud_helper.rb index af14041..b794560 100644 -

RE: rake test:cimi and test:drivers:mock failing

2013-03-13 Thread Koper, Dies
Hi Michal, You are right, that was it. Thanks. Regards, Dies Koper > -Original Message- > From: Michal Fojtik [mailto:mfoj...@redhat.com] > Sent: Wednesday, 13 March 2013 7:38 PM > To: dev@deltacloud.apache.org > Subject: Re: rake test:cimi and test:drivers:mock failing > > On 03/13, K

RE: coloured dots

2013-03-13 Thread Koper, Dies
Hi Michal, I tried adding the following to Gemfile but it made no difference. platforms :mswin do gem 'win32console' end However, when I run the tests directly (i.e. ruby tests\cimi\collections\system_templates_test.rb), words like PASSED and FAILED are coloured (even without the Gemfile chang

Re: rake test:cimi and test:drivers:mock failing

2013-03-13 Thread Michal Fojtik
On 03/13, Koper, Dies wrote: I suspect this has to do something with the recent namespacing fixes I pushed for models. Before we had 'InstanceAddress', now we have 'Deltacloud::InstanceAddress'. This fix a bug when you mount DC into Rails application and you have the 'InstanceAddress' model in t

Re: coloured dots

2013-03-13 Thread Michal Fojtik
On 03/13, Koper, Dies wrote: Hi Dies, I'm very sorry about this. I haven't thought about Windows console. I think you can resolve it by simply removing the 'turn' gem: $ gem uninstall turn Then tests should work as usual, without this fancy formatting. Another solution would be to add 'w32cons

Re: Deltacloud Community Call #15 - 13th Feburary 2013 (today)

2013-03-13 Thread Michal Fojtik
On 03/12, mar...@redhat.com wrote: Hi, There will be a small change in agenda for today. Since marios can't join this time, I'll take the lead. And since I'm not soo confident about the CIMI blackbox tests, I'll speak about the new awesome superb deltacloud-client and its ability to use Deltaclou

RE: [PATCH] added Template subcollections to SystemTemplate

2013-03-13 Thread Koper, Dies
I had some required changes stashed, which caused issue 2. Unfortunately they didn't affect the error in issue 3, and doesn't clear up question 1. Regards, Dies Koper > -Original Message- > From: Koper, Dies [mailto:di...@fast.au.fujitsu.com] > Sent: Wednesday, 13 March 2013 5:26 PM > To