On Sat, 2013-02-09 at 22:51 +1100, Koper, Dies wrote:
> > As a general comment, try adding as little of the System* objects in one
> > patch as possible, again, to make reviewing easier. I haven't looked in
> > detail if that makes sense here or not, but it would be nice if it did,
> > and there's
Thanks!
> > +++ b/server/lib/cimi/collections/system_templates.rb
>
> Nothing wrong with what you did here, but I am wondering if there is
> anything we can do to reduce this sort of boilerplate. Most of our
> collections look exactly the same ...
I was planning to suggest the same, after I conf
On Fri, 2013-02-08 at 22:44 +1100, di...@fast.au.fujitsu.com wrote:
> From: Dies Koper
You killed yourself with debug prints; I'll point the exact place out
below. But I also have a couple more comments.
> diff --git a/server/lib/cimi/collections/addresses.rb
> b/server/lib/cimi/collections/add
On Fri, 2013-02-08 at 19:13 +0200, mar...@redhat.com wrote:
> Hi Dies:
>
> On 08/02/13 14:10, Koper, Dies wrote:
> > This is a work in progress. At the moment I'm not making any progress
> > though:
> >
>
> unfortunately the patch won't apply - I think you need to rebase it and
> send again. I c
Hi Dies:
On 08/02/13 14:10, Koper, Dies wrote:
> This is a work in progress. At the moment I'm not making any progress
> though:
>
unfortunately the patch won't apply - I think you need to rebase it and
send again. I couldn't spot the problem from a visual inspection - but
there's a lot of code
This is a work in progress. At the moment I'm not making any progress
though:
When listing systems or system templates, I get the following trace:
>> Listening on localhost:3001, CTRL+C to stop
list(#) called.
system_template#self.find called
reached mock's system_templates with opts:
env#
dir: /
