Re: Renaming @ViewRef config property?

2013-12-05 Thread Thomas Andraschko
More opinions about this? 2013/10/7 Thomas Andraschko andraschko.tho...@gmail.com +1 Romain IMO it's nicer to read but it's not up to me. 2013/10/4 Romain Manni-Bucau rmannibu...@gmail.com I didnt use viewref enough to say but typically it is boring to need to write name in

Re: Renaming @ViewRef config property?

2013-12-05 Thread Mark Struberg
andraschko.tho...@gmail.com To: dev@deltaspike.apache.org Cc: Sent: Thursday, 5 December 2013, 15:49 Subject: Re: Renaming @ViewRef config property? More opinions about this? 2013/10/7 Thomas Andraschko andraschko.tho...@gmail.com +1 Romain IMO it's nicer to read but it's

Renaming @ViewRef config property?

2013-10-03 Thread Thomas Andraschko
Hi, currently @ViewRef has only one property called config. So the current usage is: @ViewRef(config = Views.Logout.class) What about renaming it to value? - @ViewRef(Views.Logout.class) Regards, Thomas

Re: Renaming @ViewRef config property?

2013-10-03 Thread Bruno Leonardo Gonçalves
+1 -- Bruno Leonardo Gonçalves 2013/10/3 Thomas Andraschko andraschko.tho...@gmail.com Hi, currently @ViewRef has only one property called config. So the current usage is: @ViewRef(config = Views.Logout.class) What about renaming it to value? - @ViewRef(Views.Logout.class) Regards,

Re: Renaming @ViewRef config property?

2013-10-03 Thread Gerhard Petracek
-0.5 for now once we add more, you get the same and it would be not that expressive. that was the reason for changing it (compared to codi). regards, gerhard 2013/10/3 Thomas Andraschko andraschko.tho...@gmail.com Hi, currently @ViewRef has only one property called config. So the current

Re: Renaming @ViewRef config property?

2013-10-03 Thread Romain Manni-Bucau
+1, same for @ConfigProperty btw Le 3 oct. 2013 20:49, Gerhard Petracek gerhard.petra...@gmail.com a écrit : -0.5 for now once we add more, you get the same and it would be not that expressive. that was the reason for changing it (compared to codi). regards, gerhard 2013/10/3 Thomas

Re: Renaming @ViewRef config property?

2013-10-03 Thread Thomas Andraschko
@Gerhard: Are there any expected properties on @ViewRef in the future? 2013/10/3 Romain Manni-Bucau rmannibu...@gmail.com +1, same for @ConfigProperty btw Le 3 oct. 2013 20:49, Gerhard Petracek gerhard.petra...@gmail.com a écrit : -0.5 for now once we add more, you get the same and it

Re: Renaming @ViewRef config property?

2013-10-03 Thread Gerhard Petracek
hi thomas, yes - we had something in codi and we might add something like the payload in bv. regards, gerhard 2013/10/3 Thomas Andraschko andraschko.tho...@gmail.com @Gerhard: Are there any expected properties on @ViewRef in the future? 2013/10/3 Romain Manni-Bucau rmannibu...@gmail.com

Re: Renaming @ViewRef config property?

2013-10-03 Thread Romain Manni-Bucau
If config is the unique mandatory attr it should be value imo Le 3 oct. 2013 22:39, Gerhard Petracek gerhard.petra...@gmail.com a écrit : hi thomas, yes - we had something in codi and we might add something like the payload in bv. regards, gerhard 2013/10/3 Thomas Andraschko

Re: Renaming @ViewRef config property?

2013-10-03 Thread Gerhard Petracek
-0.5 (instead of -1), because i used value in codi back then and there is nothing wrong with it. however, that was one of the lessons learned from using it in projects and explaining it in trainings for almost three years. what we have right now just reflects the feedback. regards, gerhard

Re: Renaming @ViewRef config property?

2013-10-03 Thread Romain Manni-Bucau
I didnt use viewref enough to say but typically it is boring to need to write name in configproperty each time while you know what it is. Moreover for viewref, config doesnt sound really right, metadata or marker sounds as right as config depending where you are coming from. Well this doesnt hold