Re: InterceptorStrategy?

2018-04-24 Thread Romain Manni-Bucau
I get it but it means we add a layer on top of interceptor for pluggability. This is actually built in in CDI so not really needed. Also the hierarchy point is fine but should be per type of strategy and therefore we dont need a generic one in the api. As a user if i use DS and an interceptor,

Re: InterceptorStrategy?

2018-04-24 Thread Gerhard Petracek
a concrete example: @Transactional -> @Interceptor is on TransactionalInterceptor whereas InterceptorStrategy is the marker interface for the strategies (and not the interceptor) - in this case TransactionStrategy. (to quickly get an overview of all interceptor-strategies you just need to open

Re: InterceptorStrategy?

2018-04-24 Thread Romain Manni-Bucau
Hmm not sure i get it, annotations are hard to browse in IDE? Is it what it addresses? Le 24 avr. 2018 21:10, "Gerhard Petracek" a écrit : > hi romain, > > not really. 1 interceptor could have n strategies as candidates (e.g. see > TransactionStrategy for which we provide

Re: InterceptorStrategy?

2018-04-24 Thread Gerhard Petracek
hi romain, not really. 1 interceptor could have n strategies as candidates (e.g. see TransactionStrategy for which we provide multiple implementations out-of-the-box). that's the whole concept. the marker interfaces is just to find all strategies in a project easily. we have it since 02/2011

Re: InterceptorStrategy?

2018-04-24 Thread Romain Manni-Bucau
Le 24 avr. 2018 19:18, "Gerhard Petracek" a écrit : it was always just a marker-interface to list all interceptor-strategies easily. But if it is just interceptors, doesnt @Interceptor fulfills that already? My only concern is exposing it in api to user where it is

Re: InterceptorStrategy?

2018-04-24 Thread Gerhard Petracek
it was always just a marker-interface to list all interceptor-strategies easily. regards, gerhard 2018-04-24 13:47 GMT+02:00 Thomas Andraschko : > basically +1 > but its still used currently > > > 2018-04-23 11:46 GMT+02:00 Romain Manni-Bucau

Re: InterceptorStrategy?

2018-04-24 Thread Thomas Andraschko
basically +1 but its still used currently 2018-04-23 11:46 GMT+02:00 Romain Manni-Bucau : > Hi guys, > > Do we still need InterceptorStrategy? > > If not, can we deprecate it and remove it from our built-in interceptors? > > Romain Manni-Bucau > @rmannibucau

[jira] [Commented] (DELTASPIKE-1315) EntityRepository should offer an findOptionalBy

2018-04-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449687#comment-16449687 ] ASF subversion and git services commented on DELTASPIKE-1315: - Commit

[jira] [Updated] (DELTASPIKE-1339) Add support for dynamic interceptor binding, added via Extension

2018-04-24 Thread Thomas Andraschko (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko updated DELTASPIKE-1339: -- Description: JCache does something simliar to: public @interface

[jira] [Updated] (DELTASPIKE-1339) Add support for dynamic interceptor binding, added via Extension

2018-04-24 Thread Thomas Andraschko (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko updated DELTASPIKE-1339: -- Description: JCache something simliar to: public @interface CachedResult