Re: [DISCUSS] PR Based Contributor Workflow

All, I've taken the input from Mark and applied it to the changes. Please review at your convenience. Assuming we're still settled on the change, I can push this week. (e.g. since most people already voted +1 I'd like to get a nod from Mark that he's good with the changes). John On Wed, Jul

Re: [DISCUSS] PR Based Contributor Workflow

Mark, Good points. On Wed, Jul 27, 2016 at 4:54 AM Mark Struberg wrote: > We should add a section that the person who applies the PR to our > canonical repo have to verify that the PR only contains commits from the > contributor himself. He basically needs to make

Re: [DISCUSS] PR Based Contributor Workflow

@mark: +1 regards, gerhard 2016-07-27 10:53 GMT+02:00 Mark Struberg : > We should add a section that the person who applies the PR to our > canonical repo have to verify that the PR only contains commits from the > contributor himself. He basically needs to make

Re: [DISCUSS] PR Based Contributor Workflow

We should add a section that the person who applies the PR to our canonical repo have to verify that the PR only contains commits from the contributor himself. He basically needs to make sure that the contributor doesn't ship too much in the pull request (and thus trashing our code provenance

Re: [DISCUSS] PR Based Contributor Workflow

+1 PRs are much easier to work with, imo. On Sun, Jul 24, 2016 at 1:40 AM, Christian Kaltepoth wrote: > Hey John, > > Great work! > > +1 ;) > > Christian > > 2016-07-23 18:14 GMT+02:00 Daniel Cunha : > > > Hi John, > > > > Greate job. I think that

Re: [DISCUSS] PR Based Contributor Workflow

Hey John, Great work! +1 ;) Christian 2016-07-23 18:14 GMT+02:00 Daniel Cunha : > Hi John, > > Greate job. I think that we really need to have that. It's much more easy > and cool to work with PR. > Easy way to review, easy way to fix changes, the contributor does not