[ 
https://issues.apache.org/jira/browse/DELTASPIKE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856870#comment-13856870
 ] 

Christian Kaltepoth commented on DELTASPIKE-479:
------------------------------------------------

@ [~gpetracek]:

I totally agree with you that we need more tests that verify behavior in EAR 
packaging scenarios.

But I think that your EAR test doesn't cover the most interesting case. You are 
basically just adding the WAR from the standard test into an EAR file. I think 
it would be more useful to test the "skinny WAR" packaging scenario which means 
that all the libraries aren't in {{/WEB-INF/lib}} but in the EAR's {{lib}} 
directory. There seem to be some class loading related problems in this case. 
See DELTASPIKE-362, DELTASPIKE-386, etc. for examples.

Perhaps we could look for a way to simplify creating tests that run both 
packaging scenarios? Perhaps we could automatically create an EAR with a skinny 
WAR from a Shrinkwrap WebArchive? It would be great to have a very simply way 
to create such tests without the need to create three classes and manually 
repackaging.

Thoughts?

> add tests with simple ear-packaging
> -----------------------------------
>
>                 Key: DELTASPIKE-479
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-479
>             Project: DeltaSpike
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 0.5
>            Reporter: Gerhard Petracek
>             Fix For: 0.6
>
>
> for all tests with war-file deployments, we should also add a test which 
> packages the war-file into an ear-file. that's the minimum we should 
> safeguard with our tests.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to