Hey John,

basically I agree with you. Placing literals in the same package as the
qualifier makes things much more clear.

However, up to now we followed the "literal" sub-package pattern everywhere
(AFAIK). I also used it in the Servlet module [1] because I saw that other
modules did it this way. So I would prefer to be consistent and keep using
the literal package like we do it in other places.

Christian


[1]
https://github.com/apache/deltaspike/tree/master/deltaspike/modules/servlet/api/src/main/java/org/apache/deltaspike/servlet/api



2013/12/18 John D. Ament <john.d.am...@gmail.com>

> Hi all,
>
> Any reason we have a package just for literals?
>
> I guess it makes sense for the repackaged core CDI literals, but for
> literals for our own qualifiers, why not just package them in the same
> package as the qualifier?  IMHO it makes it easier to understand where
> they came from.
>
> John
>



-- 
Christian Kaltepoth
Blog: http://blog.kaltepoth.de/
Twitter: http://twitter.com/chkal
GitHub: https://github.com/chkal

Reply via email to