Re: Optimizing the integration tests

2014-02-07 Thread Christian Kaltepoth
Hey Ron, thanks for sharing these details. I created a separate arquillian.xml file for AS7 and JBoss. https://github.com/apache/deltaspike/commit/ce875fde3fe5421c6d12bd43019fedaee8af5923 I guess this setup should work fine now. Christian 2014-02-04 10:18 GMT+01:00 Ron Smeral

Re: Optimizing the integration tests

2014-02-04 Thread Ron Smeral
Christian, I just found out, that adding protocol type=Servlet 3.0 / to the container element in arquillian.xml only configures (does not select) an already selected protocol. If no protocol is selected using defaultProtocol, then the container's default is used. And the default for AS7 is,

Re: Optimizing the integration tests

2014-02-02 Thread Gerhard Petracek
@christian: locally i've tested the owb-, weld- and some build-managed-profiles with the defaultProtocol you removed and everything is working on my machine. - please provide further details. regards, gerhard 2014-02-01 Christian Kaltepoth christ...@kaltepoth.de: @Ron @Jason The

Re: Optimizing the integration tests

2014-02-01 Thread Christian Kaltepoth
@Ron @Jason The defaultProtocol was only used in a single arquillian.xml file of the 8 different ones we had before. I had to remove it because the plain Weld + OWB integration tests started to fail with it (at least for me) for some reason. Christian 2014-01-31 Jason Porter

Re: Optimizing the integration tests

2014-01-31 Thread Ron Smeral
Hi Christian, I see you recently removed defaultProtocol from arquillian.xml. Is there any reason not to have it there? The now default JMX protocol seems to be causing test stability issues, I can't succesfully run for example the Data module tests. I'm not sure why this happens. Have you

Re: Optimizing the integration tests

2014-01-31 Thread Jason Porter
The JMX protocol for Wildfly / AS is horrible and for any sort of application or framework the servlet adaptor should be used. Yes, it's a little slower, but it will give you the full environment you're used to using when you develop. On Fri, Jan 31, 2014 at 1:59 PM, Ron Smeral

Re: Optimizing the integration tests

2014-01-24 Thread Christian Kaltepoth
Hey Gerhard, yeah, I wasn't aware that the Glassfish jobs have already been added. But Wildfly is still missing. Christian 2014/1/24 Gerhard Petracek gerhard.petra...@gmail.com hi christian, the jenkins-jobs should be in place already. regards, gerhard 2014/1/24 Christian Kaltepoth

Re: Optimizing the integration tests

2014-01-23 Thread Christian Kaltepoth
Hey all, I pushed out all the changes of the build-managed integration test Maven profiles which I suggested. You can now run the integration test suite against the different containers like this: $ mvn clean install -Ptomee-build-managed $ mvn clean install -Pjbossas-build-managed-7 $ mvn

Re: Optimizing the integration tests

2014-01-07 Thread Ron Smeral
Hi Christian, the test-utils is in the parent/code/pom.xml as a dependency, but then still, to get to the arquillian.xml file in the test-utils.jar, it would need to be unpacked using e.g. dependency:unpack plugin goal. Regarding basedir, because POMs are merged in Maven to form the

Re: Optimizing the integration tests

2014-01-07 Thread Christian Kaltepoth
Hey Ron, I don't think unpacking is necessary. If arquillian.xml is located in deltaspike/test-utils/src/main/resources, it will be on the classpath for all integration tests. That's basically the setup we are using for Rewrite since quite some time and it is working fine. See [1]. I guess you

Re: Optimizing the integration tests

2014-01-06 Thread Christian Kaltepoth
Hey Ron, I don't think we will have to copy arquillian.xml using the resources-plugin. If we add it to src/main/resources of the test-utils module, it will be on the test classpath for all other modules. I think this should work fine. Regarding the testsuite root directory. I think we could use

Re: Optimizing the integration tests

2014-01-03 Thread Gerhard Petracek
@christian: +1 (@as7: sounds like a missing cleanup, like it's done for tomee) regards, gerhard 2014/1/3 Christian Kaltepoth christ...@kaltepoth.de Hey Ron, yeah, there are differences between arquillian.xml files. But why? I don't see any reason for having different arquillian.xml files