Re: Hotfix release 1.5.4

[Christian Kaltepoth]

+1 for 1.5.4

2016-02-17 20:29 GMT+01:00 Thomas Andraschko :

> not sure - both 1.5.4 and 1.5.3.1 are just bugfix versions.
>
> 2016-02-17 20:24 GMT+01:00 Jason Porter :
>
> > Though would this be better as 1.5.3.1?
> >
> > On Wednesday, February 17, 2016, Jason Porter 
> > wrote:
> >
> > > +1
> > >
> > > On Wednesday, February 17, 2016, Gerhard Petracek <
> gpetra...@apache.org
> > > > wrote:
> > >
> > >> short addition:
> > >> i would start with the release in ~24h.
> > >>
> > >> regards,
> > >> gerhard
> > >>
> > >>
> > >>
> > >> 2016-02-17 16:44 GMT+01:00 Thomas Andraschko <
> > andraschko.tho...@gmail.com
> > >> >:
> > >>
> > >> > Hi,
> > >> >
> > >> > i already talked to gerhard and i need a hotfix release with
> > >> > https://issues.apache.org/jira/browse/DELTASPIKE-1078
> > >> >
> > >> > it will also contain
> > >> > https://issues.apache.org/jira/browse/DELTASPIKE-1074
> > >> >
> > >> > if anyone would like to fix a issue for this release, please let me
> > >> know.
> > >> >
> > >> > Regards,
> > >> > Thomas
> > >> >
> > >>
> > >
> > >
> > > --
> > > Sent from Gmail Mobile
> > >
> >
> >
> > --
> > Sent from Gmail Mobile
> >
>



-- 
Christian Kaltepoth
Blog: http://blog.kaltepoth.de/
Twitter: http://twitter.com/chkal
GitHub: https://github.com/chkal

Re: Hotfix release 1.5.4

[Thomas Andraschko]

not sure - both 1.5.4 and 1.5.3.1 are just bugfix versions.

2016-02-17 20:24 GMT+01:00 Jason Porter :

> Though would this be better as 1.5.3.1?
>
> On Wednesday, February 17, 2016, Jason Porter 
> wrote:
>
> > +1
> >
> > On Wednesday, February 17, 2016, Gerhard Petracek  > > wrote:
> >
> >> short addition:
> >> i would start with the release in ~24h.
> >>
> >> regards,
> >> gerhard
> >>
> >>
> >>
> >> 2016-02-17 16:44 GMT+01:00 Thomas Andraschko <
> andraschko.tho...@gmail.com
> >> >:
> >>
> >> > Hi,
> >> >
> >> > i already talked to gerhard and i need a hotfix release with
> >> > https://issues.apache.org/jira/browse/DELTASPIKE-1078
> >> >
> >> > it will also contain
> >> > https://issues.apache.org/jira/browse/DELTASPIKE-1074
> >> >
> >> > if anyone would like to fix a issue for this release, please let me
> >> know.
> >> >
> >> > Regards,
> >> > Thomas
> >> >
> >>
> >
> >
> > --
> > Sent from Gmail Mobile
> >
>
>
> --
> Sent from Gmail Mobile
>

Re: Hotfix release 1.5.4

[Jason Porter]

Though would this be better as 1.5.3.1?

On Wednesday, February 17, 2016, Jason Porter 
wrote:

> +1
>
> On Wednesday, February 17, 2016, Gerhard Petracek  > wrote:
>
>> short addition:
>> i would start with the release in ~24h.
>>
>> regards,
>> gerhard
>>
>>
>>
>> 2016-02-17 16:44 GMT+01:00 Thomas Andraschko > >:
>>
>> > Hi,
>> >
>> > i already talked to gerhard and i need a hotfix release with
>> > https://issues.apache.org/jira/browse/DELTASPIKE-1078
>> >
>> > it will also contain
>> > https://issues.apache.org/jira/browse/DELTASPIKE-1074
>> >
>> > if anyone would like to fix a issue for this release, please let me
>> know.
>> >
>> > Regards,
>> > Thomas
>> >
>>
>
>
> --
> Sent from Gmail Mobile
>


-- 
Sent from Gmail Mobile

Re: Hotfix release 1.5.4

[Jason Porter]

+1

On Wednesday, February 17, 2016, Gerhard Petracek 
wrote:

> short addition:
> i would start with the release in ~24h.
>
> regards,
> gerhard
>
>
>
> 2016-02-17 16:44 GMT+01:00 Thomas Andraschko  >:
>
> > Hi,
> >
> > i already talked to gerhard and i need a hotfix release with
> > https://issues.apache.org/jira/browse/DELTASPIKE-1078
> >
> > it will also contain
> > https://issues.apache.org/jira/browse/DELTASPIKE-1074
> >
> > if anyone would like to fix a issue for this release, please let me know.
> >
> > Regards,
> > Thomas
> >
>


-- 
Sent from Gmail Mobile

Re: Hotfix release 1.5.4

[Gerhard Petracek]

short addition:
i would start with the release in ~24h.

regards,
gerhard



2016-02-17 16:44 GMT+01:00 Thomas Andraschko :

> Hi,
>
> i already talked to gerhard and i need a hotfix release with
> https://issues.apache.org/jira/browse/DELTASPIKE-1078
>
> it will also contain
> https://issues.apache.org/jira/browse/DELTASPIKE-1074
>
> if anyone would like to fix a issue for this release, please let me know.
>
> Regards,
> Thomas
>

Re: Hotfix release 1.5.4

[John D. Ament]

Probably best to roll this ASAP.
On Feb 17, 2016 1:13 PM, "Thomas Andraschko" 
wrote:

> Hi,
>
> i already talked to gerhard and i need a hotfix release with
> https://issues.apache.org/jira/browse/DELTASPIKE-1078
>
> it will also contain
> https://issues.apache.org/jira/browse/DELTASPIKE-1074
>
> if anyone would like to fix a issue for this release, please let me know.
>
> Regards,
> Thomas
>

Hotfix release 1.5.4

[Thomas Andraschko]

Hi,

i already talked to gerhard and i need a hotfix release with
https://issues.apache.org/jira/browse/DELTASPIKE-1078

it will also contain
https://issues.apache.org/jira/browse/DELTASPIKE-1074

if anyone would like to fix a issue for this release, please let me know.

Regards,
Thomas

Hotfix release 1.5.4

[Thomas Andraschko]

Hi,

i already talked to gerhard and i need a hotfix release with
https://issues.apache.org/jira/browse/DELTASPIKE-1078

it will also contain
https://issues.apache.org/jira/browse/DELTASPIKE-1074

if anyone would like to fix a issue for this release, please let me know.

Regards,
Thomas

[jira] [Resolved] (DELTASPIKE-1074) Severe problem in setUrlParam() (windowhandler.js)

[Thomas Andraschko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Andraschko resolved DELTASPIKE-1074.
---
Resolution: Fixed

> Severe problem in setUrlParam() (windowhandler.js)
> --
>
> Key: DELTASPIKE-1074
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1074
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: JSF-Module
>Affects Versions: 1.5.3
>Reporter: Sean Flanigan
>Assignee: Thomas Andraschko
> Fix For: 1.5.4
>
>
> I noticed a potential problem with the URI manipulation while reviewing 
> https://github.com/apache/deltaspike/commit/323c7d38e9d949385eb9d90c47e8971548ab5ed4
>  :
> > {{a.href = uri.replace('?&', '?').replace('&&', '&');}}
> I think it's only safe to coalesce multiple '&'s in the query part (after 
> '?), not in the path path (before '?'). In the path part, '&'s are just 
> characters, not parameter delimiters.
> Also, it's possible that the URI could be like this:
>   {{?&&=1234&&&}}
> with more than two ampersands in a row, perhaps at the beginning of the query 
> string.
> (Attn: [~tandraschko])
> EDIT: It looks like [this 
> commit|https://github.com/apache/deltaspike/commit/323c7d38e9d949385eb9d90c47e8971548ab5ed4]
>  has totally broken {{setUrlParam()}}, because 
> {{dswh.utils.generateRequestToken()}} generates {{requestToken}} as a number, 
> but {{setUrlParam()}} now assumes that {{parameterValue}} is a string, and 
> tries to call {{replace()}} on it. This leads to errors like this:
> http://localhost:49178/zanata/javax.faces.resource/deltaspike/windowhandler.js.seam
>  10:413 Uncaught TypeError: b.replace is not a function
> I think this wasn't discovered in earlier testing because 
> {{windowhandler.js}} seems to be aggressively cached. I had some trouble 
> convincing Chrome to reload {{windowhandler.js}}. 
> If possible, I would suggest including a hash value in the URL generated by 
> {{}} and {{windowhandler.html}}, eg something like {{ type="text/javascript" 
> src="/javax.faces.resource/windowhandler.js?hash=871623874619283469">}},
>  where the hash is generated from the contents of {{windowhandler.js}}, to 
> allow aggressive caching without risk of missing changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1074) Severe problem in setUrlParam() (windowhandler.js)

[Thomas Andraschko (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150626#comment-15150626
 ] 

Thomas Andraschko commented on DELTASPIKE-1074:
---

About the caching:
the caching of resources is up the JSF implementation.
There is a config for each implementation to set the cache control.
If you would like to add a hash, you can do this via a custom ResourceHandler.

I fixed the other bugs you mentioned.
Could you please give it try? We would like to do a hotfix release ASAP.

> Severe problem in setUrlParam() (windowhandler.js)
> --
>
> Key: DELTASPIKE-1074
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1074
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: JSF-Module
>Affects Versions: 1.5.3
>Reporter: Sean Flanigan
>Assignee: Thomas Andraschko
> Fix For: 1.5.4
>
>
> I noticed a potential problem with the URI manipulation while reviewing 
> https://github.com/apache/deltaspike/commit/323c7d38e9d949385eb9d90c47e8971548ab5ed4
>  :
> > {{a.href = uri.replace('?&', '?').replace('&&', '&');}}
> I think it's only safe to coalesce multiple '&'s in the query part (after 
> '?), not in the path path (before '?'). In the path part, '&'s are just 
> characters, not parameter delimiters.
> Also, it's possible that the URI could be like this:
>   {{?&&=1234&&&}}
> with more than two ampersands in a row, perhaps at the beginning of the query 
> string.
> (Attn: [~tandraschko])
> EDIT: It looks like [this 
> commit|https://github.com/apache/deltaspike/commit/323c7d38e9d949385eb9d90c47e8971548ab5ed4]
>  has totally broken {{setUrlParam()}}, because 
> {{dswh.utils.generateRequestToken()}} generates {{requestToken}} as a number, 
> but {{setUrlParam()}} now assumes that {{parameterValue}} is a string, and 
> tries to call {{replace()}} on it. This leads to errors like this:
> http://localhost:49178/zanata/javax.faces.resource/deltaspike/windowhandler.js.seam
>  10:413 Uncaught TypeError: b.replace is not a function
> I think this wasn't discovered in earlier testing because 
> {{windowhandler.js}} seems to be aggressively cached. I had some trouble 
> convincing Chrome to reload {{windowhandler.js}}. 
> If possible, I would suggest including a hash value in the URL generated by 
> {{}} and {{windowhandler.html}}, eg something like {{ type="text/javascript" 
> src="/javax.faces.resource/windowhandler.js?hash=871623874619283469">}},
>  where the hash is generated from the contents of {{windowhandler.js}}, to 
> allow aggressive caching without risk of missing changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DELTASPIKE-1078) Request binding throws exception when using forwards

[Thomas Andraschko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Andraschko resolved DELTASPIKE-1078.
---
Resolution: Fixed

> Request binding throws exception when using forwards
> 
>
> Key: DELTASPIKE-1078
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1078
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Servlet-Module
>Affects Versions: 1.5.3
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
> Fix For: 1.5.4
>
>
>  java.lang.IllegalStateException: There is already an instance bound to this 
> thread.
>   at 
> org.apache.deltaspike.servlet.impl.produce.RequestResponseHolder.bind(RequestResponseHolder.java:62)
>   at 
> org.apache.deltaspike.servlet.impl.produce.RequestResponseHolderListener.requestInitialized(RequestResponseHolderListener.java:33)
> This occurs e.g. if Tomcat Form Auth is used because:
> 1) visit someUrl.xhtml; Tomcat fires #requestInitialized
> 2) user isn't logged id; Tomcat sends an forward to login.xhtml and fires 
> #requestInitialized again
> 3) DS throws the exception
> 4) #requestDestroyed is called



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DELTASPIKE-1078) Request binding throws exception when using forwards

[Thomas Andraschko (JIRA)]

Thomas Andraschko created DELTASPIKE-1078:
-

 Summary: Request binding throws exception when using forwards
 Key: DELTASPIKE-1078
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1078
 Project: DeltaSpike
  Issue Type: Bug
  Components: Servlet-Module
Affects Versions: 1.5.3
Reporter: Thomas Andraschko
Assignee: Thomas Andraschko
 Fix For: 1.5.4


 java.lang.IllegalStateException: There is already an instance bound to this 
thread.
at 
org.apache.deltaspike.servlet.impl.produce.RequestResponseHolder.bind(RequestResponseHolder.java:62)
at 
org.apache.deltaspike.servlet.impl.produce.RequestResponseHolderListener.requestInitialized(RequestResponseHolderListener.java:33)


This occurs e.g. if Tomcat Form Auth is used because:

1) visit someUrl.xhtml; Tomcat fires #requestInitialized
2) user isn't logged id; Tomcat sends an forward to login.xhtml and fires 
#requestInitialized again
3) DS throws the exception
4) #requestDestroyed is called





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (DELTASPIKE-1074) Severe problem in setUrlParam() (windowhandler.js)

[Thomas Andraschko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Andraschko updated DELTASPIKE-1074:
--
Fix Version/s: (was: 1.6.0)
   1.5.4

> Severe problem in setUrlParam() (windowhandler.js)
> --
>
> Key: DELTASPIKE-1074
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1074
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: JSF-Module
>Affects Versions: 1.5.3
>Reporter: Sean Flanigan
>Assignee: Thomas Andraschko
> Fix For: 1.5.4
>
>
> I noticed a potential problem with the URI manipulation while reviewing 
> https://github.com/apache/deltaspike/commit/323c7d38e9d949385eb9d90c47e8971548ab5ed4
>  :
> > {{a.href = uri.replace('?&', '?').replace('&&', '&');}}
> I think it's only safe to coalesce multiple '&'s in the query part (after 
> '?), not in the path path (before '?'). In the path part, '&'s are just 
> characters, not parameter delimiters.
> Also, it's possible that the URI could be like this:
>   {{?&&=1234&&&}}
> with more than two ampersands in a row, perhaps at the beginning of the query 
> string.
> (Attn: [~tandraschko])
> EDIT: It looks like [this 
> commit|https://github.com/apache/deltaspike/commit/323c7d38e9d949385eb9d90c47e8971548ab5ed4]
>  has totally broken {{setUrlParam()}}, because 
> {{dswh.utils.generateRequestToken()}} generates {{requestToken}} as a number, 
> but {{setUrlParam()}} now assumes that {{parameterValue}} is a string, and 
> tries to call {{replace()}} on it. This leads to errors like this:
> http://localhost:49178/zanata/javax.faces.resource/deltaspike/windowhandler.js.seam
>  10:413 Uncaught TypeError: b.replace is not a function
> I think this wasn't discovered in earlier testing because 
> {{windowhandler.js}} seems to be aggressively cached. I had some trouble 
> convincing Chrome to reload {{windowhandler.js}}. 
> If possible, I would suggest including a hash value in the URL generated by 
> {{}} and {{windowhandler.html}}, eg something like {{ type="text/javascript" 
> src="/javax.faces.resource/windowhandler.js?hash=871623874619283469">}},
>  where the hash is generated from the contents of {{windowhandler.js}}, to 
> allow aggressive caching without risk of missing changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)