Re: CI for Weld2 error

2018-06-07 Thread Mark Struberg
I tried a few Weld2 versions and all are hit by it.

I now dug into the CDI spec archive and found an old bug from 2016
https://issues.jboss.org/browse/CDI-627

A backward incompatible (and thus void) change was introduced in the 
alternatives in beans.xml handling in CDI-1.2.
We reverted and fixed the wording in CDI-2.0 again. 
But it seems that Weld-2 still follows the broken (illegal and void regarding 
to JCP rules) CDI-1.2 spec wording.

I'd say we could try to rewrite our tests to avoid this scenario but I have 
honestly no clue how!
We cannot use @Priority as we could not run on EE6 anymore. And the test is 
actually correct - it's reallly a Weld bug!

LieGrue,
strub


> Am 08.06.2018 um 02:28 schrieb John D. Ament :
> 
> What versions of weld 2 have you tried?
> 
> On Thu, Jun 7, 2018, 5:11 PM Mark Struberg 
> wrote:
> 
>> Hi!
>> 
>> I've tried to fix the CI for Weld2, but it seems that there is nothing
>> wrong with DeltaSpike but a bug in Weld2 regarding alternatives in
>> beans.xml if they get disabled via ProcessAnnotatedType#veto(). Weld 1 and
>> Weld3 both work perfectly fine, as does various OWB versions.
>> 
>> What to do?
>> 
>> LieGrue,
>> strub



Re: CI for Weld2 error

2018-06-07 Thread John D. Ament
What versions of weld 2 have you tried?

On Thu, Jun 7, 2018, 5:11 PM Mark Struberg 
wrote:

> Hi!
>
> I've tried to fix the CI for Weld2, but it seems that there is nothing
> wrong with DeltaSpike but a bug in Weld2 regarding alternatives in
> beans.xml if they get disabled via ProcessAnnotatedType#veto(). Weld 1 and
> Weld3 both work perfectly fine, as does various OWB versions.
>
> What to do?
>
> LieGrue,
> strub


[jira] [Commented] (DELTASPIKE-1257) Research why BOM isn't working right in a release

2018-06-07 Thread Mark Struberg (JIRA)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505379#comment-16505379
 ] 

Mark Struberg commented on DELTASPIKE-1257:
---

Seems like. And yes it's already on Maven.central. 
Just need to send out the ANN mail still. 

> Research why BOM isn't working right in a release
> -
>
> Key: DELTASPIKE-1257
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1257
> Project: DeltaSpike
>  Issue Type: Task
>Affects Versions: 1.8.0
>Reporter: John D. Ament
>Assignee: John D. Ament
>Priority: Major
> Fix For: 1.8.2
>
>
> https://lists.apache.org/thread.html/655162d82786d1201c2b33a20d82db8a36a642d0d9afc20042584b0d@%3Cdev.deltaspike.apache.org%3E
> Something causes the release to work incorrectly with the BOM not inheriting 
> from DS parent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


CI for Weld2 error

2018-06-07 Thread Mark Struberg
Hi!

I've tried to fix the CI for Weld2, but it seems that there is nothing wrong 
with DeltaSpike but a bug in Weld2 regarding alternatives in beans.xml if they 
get disabled via ProcessAnnotatedType#veto(). Weld 1 and Weld3 both work 
perfectly fine, as does various OWB versions.

What to do?

LieGrue,
strub