[GitHub] deltaspike pull request #:

[johnament]

Github user johnament commented on the pull request:


https://github.com/apache/deltaspike/commit/b9bc748e79d60fa1de5b2556c53aee24519cf596#commitcomment-18146939
  
In deltaspike/parent/code/pom.xml:
In deltaspike/parent/code/pom.xml on line 1808:
A


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] deltaspike pull request #:

[bartoszmajsak]

Github user bartoszmajsak commented on the pull request:


https://github.com/apache/deltaspike/commit/b9bc748e79d60fa1de5b2556c53aee24519cf596#commitcomment-18146741
  
In deltaspike/parent/code/pom.xml:
In deltaspike/parent/code/pom.xml on line 1808:
Are you testing against IBM JDK? If not remove `.blue.` and save yourself 
two hours :) I was just fighting with some odd `xerces` classloading issues 
without realizing that `blue` is for IBM JDK, as [announced 
here](http://blog.payara.fish/introducing-payara-blue), while being on OpenJDK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (DELTASPIKE-1181) Implement tests for Payara

[John D. Ament (JIRA)]

John D. Ament created DELTASPIKE-1181:
-

 Summary: Implement tests for Payara
 Key: DELTASPIKE-1181
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1181
 Project: DeltaSpike
  Issue Type: Task
Reporter: John D. Ament
 Fix For: 1.7.2






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] GitHub PR Builder

[John D. Ament]

Yes, sorry, I wasn't clear.  If you rebase their commit then it has a
tendency to not close the PR which is when you need "This closes #123"

John

On Wed, Jul 6, 2016 at 6:21 AM Daniel Cunha  wrote:

> Hi John,
>
> When we're following the steps presented by asg-git, the PR is marked like
> merged.
> For example:
> https://github.com/apache/deltaspike/pull/57
>
> The steps:
>
> https://issues.apache.org/jira/browse/DELTASPIKE-1180?focusedCommentId=15361289=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15361289
>
>
> On Wed, Jul 6, 2016 at 6:50 AM, John D. Ament 
> wrote:
>
> > Short answer is you can't.  You need to pull the branch and push to our
> > master.  You need to make the commit message include the "This closes
> #123"
> > line to make github know to close it.  Or ask the requestor to close it.
> >
> > There is an open git-dual POC from infra.  Last I looked, it wasn't doing
> > well.  May be worth raising to the board?
> >
> > John
> >
> > On Wed, Jul 6, 2016 at 4:44 AM Thomas Andraschko <
> > andraschko.tho...@gmail.com> wrote:
> >
> > > +1
> > >
> > > Stupid question but how can i merge PRs from github?
> > > The last PRs from georgekankava
> > > <
> > >
> >
> https://github.com/apache/deltaspike/issues?q=is%3Apr+is%3Aopen+author%3Ageorgekankava
> > > >
> > > are looking good.
> > >
> > > 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth  >:
> > >
> > > > I think such build jobs are very valuable. So +1 for them.
> > > >
> > > >
> > > >
> > > > 2016-07-06 4:06 GMT+02:00 John D. Ament :
> > > >
> > > > > Hey guys
> > > > >
> > > > > We've been getting a few more PRs over github.  Its IMHO easier to
> > > merge
> > > > > those instead of patches in JIRA tickets.
> > > > >
> > > > > I went ahead and created a PR build job.  When someone raises a PR
> > > > against
> > > > > us in github, it will trigger a build.  Right now that build only
> > runs
> > > > OWB
> > > > > 1.6.x, but I think it would be good to get more tests in there.
> Say
> > > one
> > > > > embedded container and one full container?
> > > > >
> > > > > What do others think? Useful? Not useful?
> > > > >
> > > > > John
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Christian Kaltepoth
> > > > Blog: http://blog.kaltepoth.de/
> > > > Twitter: http://twitter.com/chkal
> > > > GitHub: https://github.com/chkal
> > > >
> > >
> >
>
>
>
> --
> Daniel Cunha
> https://twitter.com/dvlc_
> http://www.tomitribe.com
> http://www.tomitribe.io
>

Re: [DISCUSS] Tests for Payara?

[Daniel Cunha]

+1

On Wed, Jul 6, 2016 at 7:13 AM, Gerhard Petracek  wrote:

> back then it worked with v4.1, however, v4.1.1 failed.
>
> regards,
> gerhard
>
>
>
> 2016-07-06 11:58 GMT+02:00 John D. Ament :
>
> > The glassfish one doesn't work on Payara?
> >
> > John
> >
> > On Wed, Jul 6, 2016 at 5:56 AM Gerhard Petracek 
> > wrote:
> >
> > > i asked them already (last year), however, they have(/had) an issue
> with
> > > their arquillian-adapter.
> > >
> > > regards,
> > > gerhard
> > >
> > >
> > >
> > > 2016-07-06 11:42 GMT+02:00 John D. Ament :
> > >
> > > > Hey guys
> > > >
> > > > Should we setup jenkins jobs/build profiles to test against Payara?
> > > Seems
> > > > like it may be useful.
> > > >
> > > > John
> > > >
> > >
> >
>



-- 
Daniel Cunha
https://twitter.com/dvlc_
http://www.tomitribe.com
http://www.tomitribe.io

Re: [DISCUSS] GitHub PR Builder

[Daniel Cunha]

Hi John,

When we're following the steps presented by asg-git, the PR is marked like
merged.
For example:
https://github.com/apache/deltaspike/pull/57

The steps:
https://issues.apache.org/jira/browse/DELTASPIKE-1180?focusedCommentId=15361289=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15361289


On Wed, Jul 6, 2016 at 6:50 AM, John D. Ament  wrote:

> Short answer is you can't.  You need to pull the branch and push to our
> master.  You need to make the commit message include the "This closes #123"
> line to make github know to close it.  Or ask the requestor to close it.
>
> There is an open git-dual POC from infra.  Last I looked, it wasn't doing
> well.  May be worth raising to the board?
>
> John
>
> On Wed, Jul 6, 2016 at 4:44 AM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > +1
> >
> > Stupid question but how can i merge PRs from github?
> > The last PRs from georgekankava
> > <
> >
> https://github.com/apache/deltaspike/issues?q=is%3Apr+is%3Aopen+author%3Ageorgekankava
> > >
> > are looking good.
> >
> > 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth :
> >
> > > I think such build jobs are very valuable. So +1 for them.
> > >
> > >
> > >
> > > 2016-07-06 4:06 GMT+02:00 John D. Ament :
> > >
> > > > Hey guys
> > > >
> > > > We've been getting a few more PRs over github.  Its IMHO easier to
> > merge
> > > > those instead of patches in JIRA tickets.
> > > >
> > > > I went ahead and created a PR build job.  When someone raises a PR
> > > against
> > > > us in github, it will trigger a build.  Right now that build only
> runs
> > > OWB
> > > > 1.6.x, but I think it would be good to get more tests in there.  Say
> > one
> > > > embedded container and one full container?
> > > >
> > > > What do others think? Useful? Not useful?
> > > >
> > > > John
> > > >
> > >
> > >
> > >
> > > --
> > > Christian Kaltepoth
> > > Blog: http://blog.kaltepoth.de/
> > > Twitter: http://twitter.com/chkal
> > > GitHub: https://github.com/chkal
> > >
> >
>



-- 
Daniel Cunha
https://twitter.com/dvlc_
http://www.tomitribe.com
http://www.tomitribe.io

Re: [DISCUSS] Tests for Payara?

[Gerhard Petracek]

back then it worked with v4.1, however, v4.1.1 failed.

regards,
gerhard



2016-07-06 11:58 GMT+02:00 John D. Ament :

> The glassfish one doesn't work on Payara?
>
> John
>
> On Wed, Jul 6, 2016 at 5:56 AM Gerhard Petracek 
> wrote:
>
> > i asked them already (last year), however, they have(/had) an issue with
> > their arquillian-adapter.
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2016-07-06 11:42 GMT+02:00 John D. Ament :
> >
> > > Hey guys
> > >
> > > Should we setup jenkins jobs/build profiles to test against Payara?
> > Seems
> > > like it may be useful.
> > >
> > > John
> > >
> >
>

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

[Thomas Andraschko]

Great! :)

2016-07-06 11:48 GMT+02:00 John D. Ament :

> Yeah, tests weren't working :-)
>
> But good news, the Weld2 profile is working now.  I suppose that this issue
> was weld specific.
>
> John
>
> On Wed, Jul 6, 2016 at 4:40 AM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > Oh sorry, you already made it ApplicationScoped with your second commit
> :)
> >
> > 2016-07-06 10:40 GMT+02:00 Thomas Andraschko <
> andraschko.tho...@gmail.com
> > >:
> >
> > > Hi John,
> > >
> > > thanks for fixing it.
> > > The current solution will be very slow and we should make
> > > DelegateManualInvocationHandler and InterceptManualInvocationHandler
> > > ApplicationScoped.
> > > It would be still great if you could compare the performance e.g. for
> > > 10.000 calls with our old code (with static) vs
> > > ApplicationScoped+BeanProvider.
> > >
> > > 2016-07-06 4:12 GMT+02:00 John D. Ament :
> > >
> > >> I ended up pushing a second commit which I think will make things
> > better.
> > >> But still not 100% sure.  The problem is that the static invocation
> > >> handler
> > >> was holding a reference to InterceptorLookup, which gets lost between
> > >> container boots (or even, if there are multiple bean managers around
> for
> > >> some reason).
> > >>
> > >> On Tue, Jul 5, 2016 at 9:42 PM John D. Ament 
> > >> wrote:
> > >>
> > >> > Hi @Thomas and others
> > >> >
> > >> > This was a tricky one but I think I got it.  Don't have a good test
> > for
> > >> it
> > >> > yet.
> > >> >
> > >> > Basically, in the case of web profile tests, we didn't see this as
> an
> > >> > issue as the classloader gets cleared, so its not a problem.
> > >> >
> > >> > However, if you test proxy based classes in an SE environment, the
> > >> static
> > >> > reference to the contextual instance may be loaded incorrectly.  In
> > >> those
> > >> > situations, we need to make sure its cleared.
> > >> >
> > >> > I removed the static reference.  I'm concerned about the performance
> > >> > implications.  Do you see any reason to not use an app scoped bean
> > here
> > >> > instead of dependent?  I wouldn't consider this done, as the
> dependent
> > >> bean
> > >> > still leaks.
> > >> >
> > >> > John
> > >> >
> > >> >
> > >> > On Tue, Jul 5, 2016 at 9:37 PM  wrote:
> > >> >
> > >> >> Repository: deltaspike
> > >> >> Updated Branches:
> > >> >>   refs/heads/master 81b390e29 -> bc8c82e5b
> > >> >>
> > >> >>
> > >> >> DELTASPIKE-1179 Don't use a static reference to a contextual bean,
> in
> > >> the
> > >> >> case of beans being reloaded by multiple deployments.
> > >> >>
> > >> >>
> > >> >> Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo
> > >> >> Commit:
> > >> http://git-wip-us.apache.org/repos/asf/deltaspike/commit/bc8c82e5
> > >> >> Tree:
> > http://git-wip-us.apache.org/repos/asf/deltaspike/tree/bc8c82e5
> > >> >> Diff:
> > http://git-wip-us.apache.org/repos/asf/deltaspike/diff/bc8c82e5
> > >> >>
> > >> >> Branch: refs/heads/master
> > >> >> Commit: bc8c82e5b68fb1d888fa6bac7494ed9870dca80d
> > >> >> Parents: 81b390e
> > >> >> Author: John D. Ament 
> > >> >> Authored: Tue Jul 5 21:36:41 2016 -0400
> > >> >> Committer: John D. Ament 
> > >> >> Committed: Tue Jul 5 21:37:07 2016 -0400
> > >> >>
> > >> >>
> > --
> > >> >>  .../proxy/impl/invocation/DelegateManualInvocationHandler.java | 6
> > >> +++---
> > >> >>  .../impl/invocation/InterceptManualInvocationHandler.java  | 6
> > >> +++---
> > >> >>  .../apache/deltaspike/test/testcontrol/uc003/TestSuite.java| 3
> > ---
> > >> >>  3 files changed, 6 insertions(+), 9 deletions(-)
> > >> >>
> > --
> > >> >>
> > >> >>
> > >> >>
> > >> >>
> > >>
> >
> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/bc8c82e5/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> > >> >>
> > --
> > >> >> diff --git
> > >> >>
> > >>
> >
> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> > >> >>
> > >>
> >
> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> > >> >> index d247253..a4911f7 100644
> > >> >> ---
> > >> >>
> > >>
> >
> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> > >> >> +++
> > >> >>
> > >>
> >
> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> > >> >> @@ -18,6 +18,7 @@
> > >> >>   */
> > >> >>  package 

Re: [DISCUSS] Tests for Payara?

[Thomas Andraschko]

+1 :)

2016-07-06 11:55 GMT+02:00 Gerhard Petracek :

> i asked them already (last year), however, they have(/had) an issue with
> their arquillian-adapter.
>
> regards,
> gerhard
>
>
>
> 2016-07-06 11:42 GMT+02:00 John D. Ament :
>
> > Hey guys
> >
> > Should we setup jenkins jobs/build profiles to test against Payara?
> Seems
> > like it may be useful.
> >
> > John
> >
>

Re: [DISCUSS] Tests for Payara?

[Gerhard Petracek]

i asked them already (last year), however, they have(/had) an issue with
their arquillian-adapter.

regards,
gerhard



2016-07-06 11:42 GMT+02:00 John D. Ament :

> Hey guys
>
> Should we setup jenkins jobs/build profiles to test against Payara?  Seems
> like it may be useful.
>
> John
>

Re: [DISCUSS] GitHub PR Builder

[John D. Ament]

Short answer is you can't.  You need to pull the branch and push to our
master.  You need to make the commit message include the "This closes #123"
line to make github know to close it.  Or ask the requestor to close it.

There is an open git-dual POC from infra.  Last I looked, it wasn't doing
well.  May be worth raising to the board?

John

On Wed, Jul 6, 2016 at 4:44 AM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> +1
>
> Stupid question but how can i merge PRs from github?
> The last PRs from georgekankava
> <
> https://github.com/apache/deltaspike/issues?q=is%3Apr+is%3Aopen+author%3Ageorgekankava
> >
> are looking good.
>
> 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth :
>
> > I think such build jobs are very valuable. So +1 for them.
> >
> >
> >
> > 2016-07-06 4:06 GMT+02:00 John D. Ament :
> >
> > > Hey guys
> > >
> > > We've been getting a few more PRs over github.  Its IMHO easier to
> merge
> > > those instead of patches in JIRA tickets.
> > >
> > > I went ahead and created a PR build job.  When someone raises a PR
> > against
> > > us in github, it will trigger a build.  Right now that build only runs
> > OWB
> > > 1.6.x, but I think it would be good to get more tests in there.  Say
> one
> > > embedded container and one full container?
> > >
> > > What do others think? Useful? Not useful?
> > >
> > > John
> > >
> >
> >
> >
> > --
> > Christian Kaltepoth
> > Blog: http://blog.kaltepoth.de/
> > Twitter: http://twitter.com/chkal
> > GitHub: https://github.com/chkal
> >
>

Re: [DISCUSS] Tests for Payara?

[Romain Manni-Bucau]

+1


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Wordpress Blog
 | Github  |
LinkedIn  | Tomitriber
 | JavaEE Factory


2016-07-06 11:42 GMT+02:00 John D. Ament :

> Hey guys
>
> Should we setup jenkins jobs/build profiles to test against Payara?  Seems
> like it may be useful.
>
> John
>

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

[John D. Ament]

Yeah, tests weren't working :-)

But good news, the Weld2 profile is working now.  I suppose that this issue
was weld specific.

John

On Wed, Jul 6, 2016 at 4:40 AM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> Oh sorry, you already made it ApplicationScoped with your second commit :)
>
> 2016-07-06 10:40 GMT+02:00 Thomas Andraschko  >:
>
> > Hi John,
> >
> > thanks for fixing it.
> > The current solution will be very slow and we should make
> > DelegateManualInvocationHandler and InterceptManualInvocationHandler
> > ApplicationScoped.
> > It would be still great if you could compare the performance e.g. for
> > 10.000 calls with our old code (with static) vs
> > ApplicationScoped+BeanProvider.
> >
> > 2016-07-06 4:12 GMT+02:00 John D. Ament :
> >
> >> I ended up pushing a second commit which I think will make things
> better.
> >> But still not 100% sure.  The problem is that the static invocation
> >> handler
> >> was holding a reference to InterceptorLookup, which gets lost between
> >> container boots (or even, if there are multiple bean managers around for
> >> some reason).
> >>
> >> On Tue, Jul 5, 2016 at 9:42 PM John D. Ament 
> >> wrote:
> >>
> >> > Hi @Thomas and others
> >> >
> >> > This was a tricky one but I think I got it.  Don't have a good test
> for
> >> it
> >> > yet.
> >> >
> >> > Basically, in the case of web profile tests, we didn't see this as an
> >> > issue as the classloader gets cleared, so its not a problem.
> >> >
> >> > However, if you test proxy based classes in an SE environment, the
> >> static
> >> > reference to the contextual instance may be loaded incorrectly.  In
> >> those
> >> > situations, we need to make sure its cleared.
> >> >
> >> > I removed the static reference.  I'm concerned about the performance
> >> > implications.  Do you see any reason to not use an app scoped bean
> here
> >> > instead of dependent?  I wouldn't consider this done, as the dependent
> >> bean
> >> > still leaks.
> >> >
> >> > John
> >> >
> >> >
> >> > On Tue, Jul 5, 2016 at 9:37 PM  wrote:
> >> >
> >> >> Repository: deltaspike
> >> >> Updated Branches:
> >> >>   refs/heads/master 81b390e29 -> bc8c82e5b
> >> >>
> >> >>
> >> >> DELTASPIKE-1179 Don't use a static reference to a contextual bean, in
> >> the
> >> >> case of beans being reloaded by multiple deployments.
> >> >>
> >> >>
> >> >> Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo
> >> >> Commit:
> >> http://git-wip-us.apache.org/repos/asf/deltaspike/commit/bc8c82e5
> >> >> Tree:
> http://git-wip-us.apache.org/repos/asf/deltaspike/tree/bc8c82e5
> >> >> Diff:
> http://git-wip-us.apache.org/repos/asf/deltaspike/diff/bc8c82e5
> >> >>
> >> >> Branch: refs/heads/master
> >> >> Commit: bc8c82e5b68fb1d888fa6bac7494ed9870dca80d
> >> >> Parents: 81b390e
> >> >> Author: John D. Ament 
> >> >> Authored: Tue Jul 5 21:36:41 2016 -0400
> >> >> Committer: John D. Ament 
> >> >> Committed: Tue Jul 5 21:37:07 2016 -0400
> >> >>
> >> >>
> --
> >> >>  .../proxy/impl/invocation/DelegateManualInvocationHandler.java | 6
> >> +++---
> >> >>  .../impl/invocation/InterceptManualInvocationHandler.java  | 6
> >> +++---
> >> >>  .../apache/deltaspike/test/testcontrol/uc003/TestSuite.java| 3
> ---
> >> >>  3 files changed, 6 insertions(+), 9 deletions(-)
> >> >>
> --
> >> >>
> >> >>
> >> >>
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/bc8c82e5/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> >>
> --
> >> >> diff --git
> >> >>
> >>
> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> >>
> >>
> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> >> index d247253..a4911f7 100644
> >> >> ---
> >> >>
> >>
> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> >> +++
> >> >>
> >>
> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> >> @@ -18,6 +18,7 @@
> >> >>   */
> >> >>  package org.apache.deltaspike.proxy.impl.invocation;
> >> >>
> >> >> +import org.apache.deltaspike.core.api.provider.BeanProvider;
> >> >>  import org.apache.deltaspike.proxy.spi.DeltaSpikeProxy;
> >> >>
> >> >>  import java.lang.reflect.InvocationHandler;
> >> >> @@ -32,11 +33,10 @@ import javax.enterprise.inject.Typed;
> >> >>  @Typed
> >> >>  public class 

[DISCUSS] Tests for Payara?

[John D. Ament]

Hey guys

Should we setup jenkins jobs/build profiles to test against Payara?  Seems
like it may be useful.

John

Re: [DISCUSS] GitHub PR Builder

[Thomas Andraschko]

+1

Stupid question but how can i merge PRs from github?
The last PRs from georgekankava

are looking good.

2016-07-06 8:54 GMT+02:00 Christian Kaltepoth :

> I think such build jobs are very valuable. So +1 for them.
>
>
>
> 2016-07-06 4:06 GMT+02:00 John D. Ament :
>
> > Hey guys
> >
> > We've been getting a few more PRs over github.  Its IMHO easier to merge
> > those instead of patches in JIRA tickets.
> >
> > I went ahead and created a PR build job.  When someone raises a PR
> against
> > us in github, it will trigger a build.  Right now that build only runs
> OWB
> > 1.6.x, but I think it would be good to get more tests in there.  Say one
> > embedded container and one full container?
> >
> > What do others think? Useful? Not useful?
> >
> > John
> >
>
>
>
> --
> Christian Kaltepoth
> Blog: http://blog.kaltepoth.de/
> Twitter: http://twitter.com/chkal
> GitHub: https://github.com/chkal
>

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

[Thomas Andraschko]

Oh sorry, you already made it ApplicationScoped with your second commit :)

2016-07-06 10:40 GMT+02:00 Thomas Andraschko :

> Hi John,
>
> thanks for fixing it.
> The current solution will be very slow and we should make
> DelegateManualInvocationHandler and InterceptManualInvocationHandler
> ApplicationScoped.
> It would be still great if you could compare the performance e.g. for
> 10.000 calls with our old code (with static) vs
> ApplicationScoped+BeanProvider.
>
> 2016-07-06 4:12 GMT+02:00 John D. Ament :
>
>> I ended up pushing a second commit which I think will make things better.
>> But still not 100% sure.  The problem is that the static invocation
>> handler
>> was holding a reference to InterceptorLookup, which gets lost between
>> container boots (or even, if there are multiple bean managers around for
>> some reason).
>>
>> On Tue, Jul 5, 2016 at 9:42 PM John D. Ament 
>> wrote:
>>
>> > Hi @Thomas and others
>> >
>> > This was a tricky one but I think I got it.  Don't have a good test for
>> it
>> > yet.
>> >
>> > Basically, in the case of web profile tests, we didn't see this as an
>> > issue as the classloader gets cleared, so its not a problem.
>> >
>> > However, if you test proxy based classes in an SE environment, the
>> static
>> > reference to the contextual instance may be loaded incorrectly.  In
>> those
>> > situations, we need to make sure its cleared.
>> >
>> > I removed the static reference.  I'm concerned about the performance
>> > implications.  Do you see any reason to not use an app scoped bean here
>> > instead of dependent?  I wouldn't consider this done, as the dependent
>> bean
>> > still leaks.
>> >
>> > John
>> >
>> >
>> > On Tue, Jul 5, 2016 at 9:37 PM  wrote:
>> >
>> >> Repository: deltaspike
>> >> Updated Branches:
>> >>   refs/heads/master 81b390e29 -> bc8c82e5b
>> >>
>> >>
>> >> DELTASPIKE-1179 Don't use a static reference to a contextual bean, in
>> the
>> >> case of beans being reloaded by multiple deployments.
>> >>
>> >>
>> >> Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo
>> >> Commit:
>> http://git-wip-us.apache.org/repos/asf/deltaspike/commit/bc8c82e5
>> >> Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/bc8c82e5
>> >> Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/bc8c82e5
>> >>
>> >> Branch: refs/heads/master
>> >> Commit: bc8c82e5b68fb1d888fa6bac7494ed9870dca80d
>> >> Parents: 81b390e
>> >> Author: John D. Ament 
>> >> Authored: Tue Jul 5 21:36:41 2016 -0400
>> >> Committer: John D. Ament 
>> >> Committed: Tue Jul 5 21:37:07 2016 -0400
>> >>
>> >> --
>> >>  .../proxy/impl/invocation/DelegateManualInvocationHandler.java | 6
>> +++---
>> >>  .../impl/invocation/InterceptManualInvocationHandler.java  | 6
>> +++---
>> >>  .../apache/deltaspike/test/testcontrol/uc003/TestSuite.java| 3 ---
>> >>  3 files changed, 6 insertions(+), 9 deletions(-)
>> >> --
>> >>
>> >>
>> >>
>> >>
>> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/bc8c82e5/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
>> >> --
>> >> diff --git
>> >>
>> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
>> >>
>> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
>> >> index d247253..a4911f7 100644
>> >> ---
>> >>
>> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
>> >> +++
>> >>
>> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
>> >> @@ -18,6 +18,7 @@
>> >>   */
>> >>  package org.apache.deltaspike.proxy.impl.invocation;
>> >>
>> >> +import org.apache.deltaspike.core.api.provider.BeanProvider;
>> >>  import org.apache.deltaspike.proxy.spi.DeltaSpikeProxy;
>> >>
>> >>  import java.lang.reflect.InvocationHandler;
>> >> @@ -32,11 +33,10 @@ import javax.enterprise.inject.Typed;
>> >>  @Typed
>> >>  public class DelegateManualInvocationHandler extends
>> >> AbstractManualInvocationHandler
>> >>  {
>> >> -private static final DelegateManualInvocationHandler INSTANCE =
>> new
>> >> DelegateManualInvocationHandler();
>> >> -
>> >>  public static Object staticInvoke(Object proxy, Method method,
>> >> Object[] parameters) throws Throwable
>> >>  {
>> >> -return INSTANCE.invoke(proxy, method, parameters);
>> >> +DelegateManualInvocationHandler handler =
>> >>
>> 

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

[Thomas Andraschko]

Hi John,

thanks for fixing it.
The current solution will be very slow and we should make
DelegateManualInvocationHandler and InterceptManualInvocationHandler
ApplicationScoped.
It would be still great if you could compare the performance e.g. for
10.000 calls with our old code (with static) vs
ApplicationScoped+BeanProvider.

2016-07-06 4:12 GMT+02:00 John D. Ament :

> I ended up pushing a second commit which I think will make things better.
> But still not 100% sure.  The problem is that the static invocation handler
> was holding a reference to InterceptorLookup, which gets lost between
> container boots (or even, if there are multiple bean managers around for
> some reason).
>
> On Tue, Jul 5, 2016 at 9:42 PM John D. Ament 
> wrote:
>
> > Hi @Thomas and others
> >
> > This was a tricky one but I think I got it.  Don't have a good test for
> it
> > yet.
> >
> > Basically, in the case of web profile tests, we didn't see this as an
> > issue as the classloader gets cleared, so its not a problem.
> >
> > However, if you test proxy based classes in an SE environment, the static
> > reference to the contextual instance may be loaded incorrectly.  In those
> > situations, we need to make sure its cleared.
> >
> > I removed the static reference.  I'm concerned about the performance
> > implications.  Do you see any reason to not use an app scoped bean here
> > instead of dependent?  I wouldn't consider this done, as the dependent
> bean
> > still leaks.
> >
> > John
> >
> >
> > On Tue, Jul 5, 2016 at 9:37 PM  wrote:
> >
> >> Repository: deltaspike
> >> Updated Branches:
> >>   refs/heads/master 81b390e29 -> bc8c82e5b
> >>
> >>
> >> DELTASPIKE-1179 Don't use a static reference to a contextual bean, in
> the
> >> case of beans being reloaded by multiple deployments.
> >>
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo
> >> Commit:
> http://git-wip-us.apache.org/repos/asf/deltaspike/commit/bc8c82e5
> >> Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/bc8c82e5
> >> Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/bc8c82e5
> >>
> >> Branch: refs/heads/master
> >> Commit: bc8c82e5b68fb1d888fa6bac7494ed9870dca80d
> >> Parents: 81b390e
> >> Author: John D. Ament 
> >> Authored: Tue Jul 5 21:36:41 2016 -0400
> >> Committer: John D. Ament 
> >> Committed: Tue Jul 5 21:37:07 2016 -0400
> >>
> >> --
> >>  .../proxy/impl/invocation/DelegateManualInvocationHandler.java | 6
> +++---
> >>  .../impl/invocation/InterceptManualInvocationHandler.java  | 6
> +++---
> >>  .../apache/deltaspike/test/testcontrol/uc003/TestSuite.java| 3 ---
> >>  3 files changed, 6 insertions(+), 9 deletions(-)
> >> --
> >>
> >>
> >>
> >>
> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/bc8c82e5/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> --
> >> diff --git
> >>
> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >>
> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> index d247253..a4911f7 100644
> >> ---
> >>
> a/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> +++
> >>
> b/deltaspike/modules/proxy/impl-asm5/src/main/java/org/apache/deltaspike/proxy/impl/invocation/DelegateManualInvocationHandler.java
> >> @@ -18,6 +18,7 @@
> >>   */
> >>  package org.apache.deltaspike.proxy.impl.invocation;
> >>
> >> +import org.apache.deltaspike.core.api.provider.BeanProvider;
> >>  import org.apache.deltaspike.proxy.spi.DeltaSpikeProxy;
> >>
> >>  import java.lang.reflect.InvocationHandler;
> >> @@ -32,11 +33,10 @@ import javax.enterprise.inject.Typed;
> >>  @Typed
> >>  public class DelegateManualInvocationHandler extends
> >> AbstractManualInvocationHandler
> >>  {
> >> -private static final DelegateManualInvocationHandler INSTANCE = new
> >> DelegateManualInvocationHandler();
> >> -
> >>  public static Object staticInvoke(Object proxy, Method method,
> >> Object[] parameters) throws Throwable
> >>  {
> >> -return INSTANCE.invoke(proxy, method, parameters);
> >> +DelegateManualInvocationHandler handler =
> >>
> BeanProvider.getContextualReference(DelegateManualInvocationHandler.class);
> >> +return handler.invoke(proxy, method, parameters);
> >>  }
> >>
> >>  @Override
> >>
> >>
> >>
> 

Re: [DISCUSS] GitHub PR Builder

[Christian Kaltepoth]

I think such build jobs are very valuable. So +1 for them.



2016-07-06 4:06 GMT+02:00 John D. Ament :

> Hey guys
>
> We've been getting a few more PRs over github.  Its IMHO easier to merge
> those instead of patches in JIRA tickets.
>
> I went ahead and created a PR build job.  When someone raises a PR against
> us in github, it will trigger a build.  Right now that build only runs OWB
> 1.6.x, but I think it would be good to get more tests in there.  Say one
> embedded container and one full container?
>
> What do others think? Useful? Not useful?
>
> John
>



-- 
Christian Kaltepoth
Blog: http://blog.kaltepoth.de/
Twitter: http://twitter.com/chkal
GitHub: https://github.com/chkal