Re: [VOTE] release Apache DeltaSpike-1.8.1

[Mark Struberg]

Yes you are right, checked directly on our Jenkins - all fine still.

It was just my mail client who fooled me. It still had the subject „.. 
failed..“ on the thread still.
But the last mail was an OK message.

Sorry and LieGrue,
Strub

> Am 31.12.2017 um 00:22 schrieb John D. Ament :
> 
> I didn't see an answer on this, but I'm fine with releasing as is
> considering the contents so here's my +1.
> 
> On Sat, Dec 30, 2017 at 11:59 AM John D. Ament 
> wrote:
> 
>> Where did it break jenkins?
>> 
>> 
>> https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_TomEE/1220/
>> passed
>> 
>> https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_Payara_4.1.x/48/
>> passed
>> 
>> https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_Wildfly_10.1/63/
>> passed
>> 
>> In fact, I asked the contributor to rebase to ensure that CI was passing
>> since CI was failing.
>> 
>> John
>> 
>> 
>> On Sat, Dec 30, 2017 at 11:48 AM Mark Struberg 
>> wrote:
>> 
>>> I've moved 1299 to 1.8.2. It did break Jenkins, so we should look at it
>>> again and take time as needed.
>>> But we should really get this release out of the door asap as it contains
>>> important security fixes.
>>> 
>>> Happy to run an 1.8.2 release in the next weeks.
>>> 
>>> LieGrue,
>>> strub
>>> 
 Am 30.12.2017 um 17:43 schrieb John D. Ament :
 
 Hmmm looks like we crossed wires.  Can you rerun with current master?  I
 want to ensure that 1299 is included.
 
 On Sat, Dec 30, 2017 at 11:39 AM Mark Struberg
>>> 
 wrote:
 
> Hi folks!
> 
> I did run the necessary steps for releasing DeltaSpike-1.8.1
> 
> The following bugs and improvements got implemented:
> 
> Bug
> 
>   • [DELTASPIKE-1252] - data-documentation missing Optional return
> value
>   • [DELTASPIKE-1271] - [perf] cache Transactional
>   • [DELTASPIKE-1272] - ConfigResolver asList breaks if no value
>>> is
> found
>   • [DELTASPIKE-1275] - Build fails on Linux because Testclass
> filenames are to long
>   • [DELTASPIKE-1278] - PropertyFileConfig does not respect
>>> optional
> on external resources
>   • [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
> persistenf factory config using "javax.persistence.bean.manager"
>   • [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
> configured value exists
>   • [DELTASPIKE-1288] - Default values are not interpolated
>   • [DELTASPIKE-1294] - Secured Stereotypes are not applied to
> inherited methods
>   • [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
> internal extensions
>   • [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
> always empty
>   • [DELTASPIKE-1303] - @Configuration proxies should support List
> without converters
>   • [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
> redirects
>   • [DELTASPIKE-1306] - IE sometimes doesn't set window.name
> correctly
>   • [DELTASPIKE-1307] - Deltaspike JSF: XSS
>>> WindowIdHtmlRenderer.java
> Improvement
> 
>   • [DELTASPIKE-940] - @Transactional and @EntityManagerConfig
>>> each
> use a different method to resolve EntityManagers
>   • [DELTASPIKE-1070] - Refactor RepositoryComponent/s
>   • [DELTASPIKE-1258] - skip flush with one EntityManager
>   • [DELTASPIKE-1267] - Remove second factory mechanism of
> QueryBuilder's
>   • [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
>   • [DELTASPIKE-1269] - [perf] Cache singleResultType per method
>   • [DELTASPIKE-1270] - [perf] cache requiresTransaction per
>>> method
>   • [DELTASPIKE-1274] - Refactor proxy-module / improve
>>> performance
>   • [DELTASPIKE-1279] - SimpleSecurityViolation needs
>>> equals/hashcode
>   • [DELTASPIKE-1283] - Placeholders not supported for defaults
>   • [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
> BeanManager
>   • [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
>   • [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment
>>> on
> Weld by default
> Task
> 
>   • [DELTASPIKE-1259] - upgraded version numbers
>   • [DELTASPIKE-1297] - add test with a customized
>>> DynamicMockManager
>   • [DELTASPIKE-1298] - document customization of a
> DynamicMockManager
> Test
> 
>   • [DELTASPIKE-1273] - Test against OWB 2
> 
> 
> 
> The staging repo is
> 
> 
>>> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/
> 
> The source release can be found at
> 
> 
>>> 

[jira] [Commented] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[John D. Ament (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306996#comment-16306996
 ] 

John D. Ament commented on DELTASPIKE-1299:
---

[~tandraschko] I don't know what this ticket has to do with ASM upgrade?

> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.2
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] release Apache DeltaSpike-1.8.1

[John D. Ament]

I didn't see an answer on this, but I'm fine with releasing as is
considering the contents so here's my +1.

On Sat, Dec 30, 2017 at 11:59 AM John D. Ament 
wrote:

> Where did it break jenkins?
>
>
> https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_TomEE/1220/
>  passed
>
> https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_Payara_4.1.x/48/
>  passed
>
> https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_Wildfly_10.1/63/
>  passed
>
> In fact, I asked the contributor to rebase to ensure that CI was passing
> since CI was failing.
>
> John
>
>
> On Sat, Dec 30, 2017 at 11:48 AM Mark Struberg 
> wrote:
>
>> I've moved 1299 to 1.8.2. It did break Jenkins, so we should look at it
>> again and take time as needed.
>> But we should really get this release out of the door asap as it contains
>> important security fixes.
>>
>> Happy to run an 1.8.2 release in the next weeks.
>>
>> LieGrue,
>> strub
>>
>> > Am 30.12.2017 um 17:43 schrieb John D. Ament :
>> >
>> > Hmmm looks like we crossed wires.  Can you rerun with current master?  I
>> > want to ensure that 1299 is included.
>> >
>> > On Sat, Dec 30, 2017 at 11:39 AM Mark Struberg
>> 
>> > wrote:
>> >
>> >> Hi folks!
>> >>
>> >> I did run the necessary steps for releasing DeltaSpike-1.8.1
>> >>
>> >> The following bugs and improvements got implemented:
>> >>
>> >> Bug
>> >>
>> >>• [DELTASPIKE-1252] - data-documentation missing Optional return
>> >> value
>> >>• [DELTASPIKE-1271] - [perf] cache Transactional
>> >>• [DELTASPIKE-1272] - ConfigResolver asList breaks if no value
>> is
>> >> found
>> >>• [DELTASPIKE-1275] - Build fails on Linux because Testclass
>> >> filenames are to long
>> >>• [DELTASPIKE-1278] - PropertyFileConfig does not respect
>> optional
>> >> on external resources
>> >>• [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
>> >> persistenf factory config using "javax.persistence.bean.manager"
>> >>• [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
>> >> configured value exists
>> >>• [DELTASPIKE-1288] - Default values are not interpolated
>> >>• [DELTASPIKE-1294] - Secured Stereotypes are not applied to
>> >> inherited methods
>> >>• [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
>> >> internal extensions
>> >>• [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
>> >> always empty
>> >>• [DELTASPIKE-1303] - @Configuration proxies should support List
>> >> without converters
>> >>• [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
>> >> redirects
>> >>• [DELTASPIKE-1306] - IE sometimes doesn't set window.name
>> >> correctly
>> >>• [DELTASPIKE-1307] - Deltaspike JSF: XSS
>> WindowIdHtmlRenderer.java
>> >> Improvement
>> >>
>> >>• [DELTASPIKE-940] - @Transactional and @EntityManagerConfig
>> each
>> >> use a different method to resolve EntityManagers
>> >>• [DELTASPIKE-1070] - Refactor RepositoryComponent/s
>> >>• [DELTASPIKE-1258] - skip flush with one EntityManager
>> >>• [DELTASPIKE-1267] - Remove second factory mechanism of
>> >> QueryBuilder's
>> >>• [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
>> >>• [DELTASPIKE-1269] - [perf] Cache singleResultType per method
>> >>• [DELTASPIKE-1270] - [perf] cache requiresTransaction per
>> method
>> >>• [DELTASPIKE-1274] - Refactor proxy-module / improve
>> performance
>> >>• [DELTASPIKE-1279] - SimpleSecurityViolation needs
>> equals/hashcode
>> >>• [DELTASPIKE-1283] - Placeholders not supported for defaults
>> >>• [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
>> >> BeanManager
>> >>• [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
>> >>• [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment
>> on
>> >> Weld by default
>> >> Task
>> >>
>> >>• [DELTASPIKE-1259] - upgraded version numbers
>> >>• [DELTASPIKE-1297] - add test with a customized
>> DynamicMockManager
>> >>• [DELTASPIKE-1298] - document customization of a
>> >> DynamicMockManager
>> >> Test
>> >>
>> >>• [DELTASPIKE-1273] - Test against OWB 2
>> >>
>> >>
>> >>
>> >> The staging repo is
>> >>
>> >>
>> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/
>> >>
>> >> The source release can be found at
>> >>
>> >>
>> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
>> >> sha1
>> >> <
>> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/sha1
>> >
>> >> is 4d7db712629261a92e6dcddfdcb7a446015bf432
>> >>
>> >>
>> >> Please VOTE:
>> >>
>> >> [+1] yea, let's ship it
>> >> [+0] meh, don't care
>> >> [-1] 

Re: [VOTE] release Apache DeltaSpike-1.8.1

[Romain Manni-Bucau]

+1

Le 30 déc. 2017 21:14, "Gerhard Petracek"  a écrit :

> +1
>
> regards,
> gerhard
>
>
>
> 2017-12-30 17:39 GMT+01:00 Mark Struberg :
>
> > Hi folks!
> >
> > I did run the necessary steps for releasing DeltaSpike-1.8.1
> >
> > The following bugs and improvements got implemented:
> >
> > Bug
> >
> > • [DELTASPIKE-1252] - data-documentation missing Optional return
> > value
> > • [DELTASPIKE-1271] - [perf] cache Transactional
> > • [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is
> > found
> > • [DELTASPIKE-1275] - Build fails on Linux because Testclass
> > filenames are to long
> > • [DELTASPIKE-1278] - PropertyFileConfig does not respect
> optional
> > on external resources
> > • [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
> > persistenf factory config using "javax.persistence.bean.manager"
> > • [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
> > configured value exists
> > • [DELTASPIKE-1288] - Default values are not interpolated
> > • [DELTASPIKE-1294] - Secured Stereotypes are not applied to
> > inherited methods
> > • [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
> > internal extensions
> > • [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
> > always empty
> > • [DELTASPIKE-1303] - @Configuration proxies should support List
> > without converters
> > • [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
> > redirects
> > • [DELTASPIKE-1306] - IE sometimes doesn't set window.name
> > correctly
> > • [DELTASPIKE-1307] - Deltaspike JSF: XSS
> WindowIdHtmlRenderer.java
> > Improvement
> >
> > • [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each
> > use a different method to resolve EntityManagers
> > • [DELTASPIKE-1070] - Refactor RepositoryComponent/s
> > • [DELTASPIKE-1258] - skip flush with one EntityManager
> > • [DELTASPIKE-1267] - Remove second factory mechanism of
> > QueryBuilder's
> > • [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
> > • [DELTASPIKE-1269] - [perf] Cache singleResultType per method
> > • [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
> > • [DELTASPIKE-1274] - Refactor proxy-module / improve performance
> > • [DELTASPIKE-1279] - SimpleSecurityViolation needs
> equals/hashcode
> > • [DELTASPIKE-1283] - Placeholders not supported for defaults
> > • [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
> > BeanManager
> > • [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
> > • [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on
> > Weld by default
> > Task
> >
> > • [DELTASPIKE-1259] - upgraded version numbers
> > • [DELTASPIKE-1297] - add test with a customized
> DynamicMockManager
> > • [DELTASPIKE-1298] - document customization of a
> > DynamicMockManager
> > Test
> >
> > • [DELTASPIKE-1273] - Test against OWB 2
> >
> >
> >
> > The staging repo is
> > https://repository.apache.org/content/repositories/
> > orgapachedeltaspike-1046/
> >
> > The source release can be found at
> > https://repository.apache.org/content/repositories/
> > orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
> > sha1 is 4d7db712629261a92e6dcddfdcb7a446015bf432
> >
> >
> > Please VOTE:
> >
> > [+1] yea, let's ship it
> > [+0] meh, don't care
> > [-1] yikes, stop because ${showstopper}
> >
> > The VOTE is open for 72h.
> >
> >
> > Here is my own +1
> >
> > txs and LieGrue,
> > strub
>

Re: [VOTE] release Apache DeltaSpike-1.8.1

[Gerhard Petracek]

+1

regards,
gerhard



2017-12-30 17:39 GMT+01:00 Mark Struberg :

> Hi folks!
>
> I did run the necessary steps for releasing DeltaSpike-1.8.1
>
> The following bugs and improvements got implemented:
>
> Bug
>
> • [DELTASPIKE-1252] - data-documentation missing Optional return
> value
> • [DELTASPIKE-1271] - [perf] cache Transactional
> • [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is
> found
> • [DELTASPIKE-1275] - Build fails on Linux because Testclass
> filenames are to long
> • [DELTASPIKE-1278] - PropertyFileConfig does not respect optional
> on external resources
> • [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
> persistenf factory config using "javax.persistence.bean.manager"
> • [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
> configured value exists
> • [DELTASPIKE-1288] - Default values are not interpolated
> • [DELTASPIKE-1294] - Secured Stereotypes are not applied to
> inherited methods
> • [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
> internal extensions
> • [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
> always empty
> • [DELTASPIKE-1303] - @Configuration proxies should support List
> without converters
> • [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
> redirects
> • [DELTASPIKE-1306] - IE sometimes doesn't set window.name
> correctly
> • [DELTASPIKE-1307] - Deltaspike JSF: XSS WindowIdHtmlRenderer.java
> Improvement
>
> • [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each
> use a different method to resolve EntityManagers
> • [DELTASPIKE-1070] - Refactor RepositoryComponent/s
> • [DELTASPIKE-1258] - skip flush with one EntityManager
> • [DELTASPIKE-1267] - Remove second factory mechanism of
> QueryBuilder's
> • [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
> • [DELTASPIKE-1269] - [perf] Cache singleResultType per method
> • [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
> • [DELTASPIKE-1274] - Refactor proxy-module / improve performance
> • [DELTASPIKE-1279] - SimpleSecurityViolation needs equals/hashcode
> • [DELTASPIKE-1283] - Placeholders not supported for defaults
> • [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
> BeanManager
> • [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
> • [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on
> Weld by default
> Task
>
> • [DELTASPIKE-1259] - upgraded version numbers
> • [DELTASPIKE-1297] - add test with a customized DynamicMockManager
> • [DELTASPIKE-1298] - document customization of a
> DynamicMockManager
> Test
>
> • [DELTASPIKE-1273] - Test against OWB 2
>
>
>
> The staging repo is
> https://repository.apache.org/content/repositories/
> orgapachedeltaspike-1046/
>
> The source release can be found at
> https://repository.apache.org/content/repositories/
> orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
> sha1 is 4d7db712629261a92e6dcddfdcb7a446015bf432
>
>
> Please VOTE:
>
> [+1] yea, let's ship it
> [+0] meh, don't care
> [-1] yikes, stop because ${showstopper}
>
> The VOTE is open for 72h.
>
>
> Here is my own +1
>
> txs and LieGrue,
> strub

Re: [VOTE] release Apache DeltaSpike-1.8.1

[Cody Lerum]

+1

On Sat, Dec 30, 2017 at 9:39 AM, Mark Struberg
 wrote:
> Hi folks!
>
> I did run the necessary steps for releasing DeltaSpike-1.8.1
>
> The following bugs and improvements got implemented:
>
> Bug
>
> • [DELTASPIKE-1252] - data-documentation missing Optional return value
> • [DELTASPIKE-1271] - [perf] cache Transactional
> • [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is 
> found
> • [DELTASPIKE-1275] - Build fails on Linux because Testclass 
> filenames are to long
> • [DELTASPIKE-1278] - PropertyFileConfig does not respect optional on 
> external resources
> • [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to 
> persistenf factory config using "javax.persistence.bean.manager"
> • [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no 
> configured value exists
> • [DELTASPIKE-1288] - Default values are not interpolated
> • [DELTASPIKE-1294] - Secured Stereotypes are not applied to 
> inherited methods
> • [DELTASPIKE-1296] - PropertyFileConfig doesn't work with internal 
> extensions
> • [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is 
> always empty
> • [DELTASPIKE-1303] - @Configuration proxies should support List 
> without converters
> • [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple redirects
> • [DELTASPIKE-1306] - IE sometimes doesn't set window.name correctly
> • [DELTASPIKE-1307] - Deltaspike JSF: XSS WindowIdHtmlRenderer.java
> Improvement
>
> • [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each use 
> a different method to resolve EntityManagers
> • [DELTASPIKE-1070] - Refactor RepositoryComponent/s
> • [DELTASPIKE-1258] - skip flush with one EntityManager
> • [DELTASPIKE-1267] - Remove second factory mechanism of 
> QueryBuilder's
> • [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
> • [DELTASPIKE-1269] - [perf] Cache singleResultType per method
> • [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
> • [DELTASPIKE-1274] - Refactor proxy-module / improve performance
> • [DELTASPIKE-1279] - SimpleSecurityViolation needs equals/hashcode
> • [DELTASPIKE-1283] - Placeholders not supported for defaults
> • [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse 
> BeanManager
> • [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
> • [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on 
> Weld by default
> Task
>
> • [DELTASPIKE-1259] - upgraded version numbers
> • [DELTASPIKE-1297] - add test with a customized DynamicMockManager
> • [DELTASPIKE-1298] - document customization of a DynamicMockManager
> Test
>
> • [DELTASPIKE-1273] - Test against OWB 2
>
>
>
> The staging repo is
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/
>
> The source release can be found at
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
> sha1 is 4d7db712629261a92e6dcddfdcb7a446015bf432
>
>
> Please VOTE:
>
> [+1] yea, let's ship it
> [+0] meh, don't care
> [-1] yikes, stop because ${showstopper}
>
> The VOTE is open for 72h.
>
>
> Here is my own +1
>
> txs and LieGrue,
> strub

[jira] [Created] (DELTASPIKE-1309) Upgrade ASM

[Thomas Andraschko (JIRA)]

Thomas Andraschko created DELTASPIKE-1309:
-

 Summary: Upgrade ASM
 Key: DELTASPIKE-1309
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1309
 Project: DeltaSpike
  Issue Type: Improvement
  Components: Data-Module, PartialBean, Proxy-Module
Reporter: Thomas Andraschko
 Fix For: 1.8.2






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] release Apache DeltaSpike-1.8.1

[John D. Ament]

Where did it break jenkins?

https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_TomEE/1220/
 passed
https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_Payara_4.1.x/48/
 passed
https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike_Wildfly_10.1/63/
 passed

In fact, I asked the contributor to rebase to ensure that CI was passing
since CI was failing.

John

On Sat, Dec 30, 2017 at 11:48 AM Mark Struberg 
wrote:

> I've moved 1299 to 1.8.2. It did break Jenkins, so we should look at it
> again and take time as needed.
> But we should really get this release out of the door asap as it contains
> important security fixes.
>
> Happy to run an 1.8.2 release in the next weeks.
>
> LieGrue,
> strub
>
> > Am 30.12.2017 um 17:43 schrieb John D. Ament :
> >
> > Hmmm looks like we crossed wires.  Can you rerun with current master?  I
> > want to ensure that 1299 is included.
> >
> > On Sat, Dec 30, 2017 at 11:39 AM Mark Struberg  >
> > wrote:
> >
> >> Hi folks!
> >>
> >> I did run the necessary steps for releasing DeltaSpike-1.8.1
> >>
> >> The following bugs and improvements got implemented:
> >>
> >> Bug
> >>
> >>• [DELTASPIKE-1252] - data-documentation missing Optional return
> >> value
> >>• [DELTASPIKE-1271] - [perf] cache Transactional
> >>• [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is
> >> found
> >>• [DELTASPIKE-1275] - Build fails on Linux because Testclass
> >> filenames are to long
> >>• [DELTASPIKE-1278] - PropertyFileConfig does not respect
> optional
> >> on external resources
> >>• [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
> >> persistenf factory config using "javax.persistence.bean.manager"
> >>• [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
> >> configured value exists
> >>• [DELTASPIKE-1288] - Default values are not interpolated
> >>• [DELTASPIKE-1294] - Secured Stereotypes are not applied to
> >> inherited methods
> >>• [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
> >> internal extensions
> >>• [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
> >> always empty
> >>• [DELTASPIKE-1303] - @Configuration proxies should support List
> >> without converters
> >>• [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
> >> redirects
> >>• [DELTASPIKE-1306] - IE sometimes doesn't set window.name
> >> correctly
> >>• [DELTASPIKE-1307] - Deltaspike JSF: XSS
> WindowIdHtmlRenderer.java
> >> Improvement
> >>
> >>• [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each
> >> use a different method to resolve EntityManagers
> >>• [DELTASPIKE-1070] - Refactor RepositoryComponent/s
> >>• [DELTASPIKE-1258] - skip flush with one EntityManager
> >>• [DELTASPIKE-1267] - Remove second factory mechanism of
> >> QueryBuilder's
> >>• [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
> >>• [DELTASPIKE-1269] - [perf] Cache singleResultType per method
> >>• [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
> >>• [DELTASPIKE-1274] - Refactor proxy-module / improve performance
> >>• [DELTASPIKE-1279] - SimpleSecurityViolation needs
> equals/hashcode
> >>• [DELTASPIKE-1283] - Placeholders not supported for defaults
> >>• [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
> >> BeanManager
> >>• [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
> >>• [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on
> >> Weld by default
> >> Task
> >>
> >>• [DELTASPIKE-1259] - upgraded version numbers
> >>• [DELTASPIKE-1297] - add test with a customized
> DynamicMockManager
> >>• [DELTASPIKE-1298] - document customization of a
> >> DynamicMockManager
> >> Test
> >>
> >>• [DELTASPIKE-1273] - Test against OWB 2
> >>
> >>
> >>
> >> The staging repo is
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/
> >>
> >> The source release can be found at
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
> >> sha1
> >> <
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/sha1
> >
> >> is 4d7db712629261a92e6dcddfdcb7a446015bf432
> >>
> >>
> >> Please VOTE:
> >>
> >> [+1] yea, let's ship it
> >> [+0] meh, don't care
> >> [-1] yikes, stop because ${showstopper}
> >>
> >> The VOTE is open for 72h.
> >>
> >>
> >> Here is my own +1
> >>
> >> txs and LieGrue,
> >> strub
>
>

Jenkins status

[Mark Struberg]

Hi!

Before running the 1.8.1 release I've fixed all Jenkins jobs. 
Most did fail because the current Jenkins needs to use Java8 to run Maven 
builds.

There are currently 2 Jobs failing due to setup issues: 
* AS7 requires Java7 to run. It fails on Java8. We must delete this Maven job 
and replace it with a 'freestyle' job.
* Weld1. Issue is currently evaluated by Matej. But it's a very old problem, so 
doesn't prevent any release.

LieGrue,
strub

Re: [VOTE] release Apache DeltaSpike-1.8.1

[Mark Struberg]

I've moved 1299 to 1.8.2. It did break Jenkins, so we should look at it again 
and take time as needed. 
But we should really get this release out of the door asap as it contains 
important security fixes.

Happy to run an 1.8.2 release in the next weeks.

LieGrue,
strub

> Am 30.12.2017 um 17:43 schrieb John D. Ament :
> 
> Hmmm looks like we crossed wires.  Can you rerun with current master?  I
> want to ensure that 1299 is included.
> 
> On Sat, Dec 30, 2017 at 11:39 AM Mark Struberg 
> wrote:
> 
>> Hi folks!
>> 
>> I did run the necessary steps for releasing DeltaSpike-1.8.1
>> 
>> The following bugs and improvements got implemented:
>> 
>> Bug
>> 
>>• [DELTASPIKE-1252] - data-documentation missing Optional return
>> value
>>• [DELTASPIKE-1271] - [perf] cache Transactional
>>• [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is
>> found
>>• [DELTASPIKE-1275] - Build fails on Linux because Testclass
>> filenames are to long
>>• [DELTASPIKE-1278] - PropertyFileConfig does not respect optional
>> on external resources
>>• [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
>> persistenf factory config using "javax.persistence.bean.manager"
>>• [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
>> configured value exists
>>• [DELTASPIKE-1288] - Default values are not interpolated
>>• [DELTASPIKE-1294] - Secured Stereotypes are not applied to
>> inherited methods
>>• [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
>> internal extensions
>>• [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
>> always empty
>>• [DELTASPIKE-1303] - @Configuration proxies should support List
>> without converters
>>• [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
>> redirects
>>• [DELTASPIKE-1306] - IE sometimes doesn't set window.name
>> correctly
>>• [DELTASPIKE-1307] - Deltaspike JSF: XSS WindowIdHtmlRenderer.java
>> Improvement
>> 
>>• [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each
>> use a different method to resolve EntityManagers
>>• [DELTASPIKE-1070] - Refactor RepositoryComponent/s
>>• [DELTASPIKE-1258] - skip flush with one EntityManager
>>• [DELTASPIKE-1267] - Remove second factory mechanism of
>> QueryBuilder's
>>• [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
>>• [DELTASPIKE-1269] - [perf] Cache singleResultType per method
>>• [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
>>• [DELTASPIKE-1274] - Refactor proxy-module / improve performance
>>• [DELTASPIKE-1279] - SimpleSecurityViolation needs equals/hashcode
>>• [DELTASPIKE-1283] - Placeholders not supported for defaults
>>• [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
>> BeanManager
>>• [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
>>• [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on
>> Weld by default
>> Task
>> 
>>• [DELTASPIKE-1259] - upgraded version numbers
>>• [DELTASPIKE-1297] - add test with a customized DynamicMockManager
>>• [DELTASPIKE-1298] - document customization of a
>> DynamicMockManager
>> Test
>> 
>>• [DELTASPIKE-1273] - Test against OWB 2
>> 
>> 
>> 
>> The staging repo is
>> 
>> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/
>> 
>> The source release can be found at
>> 
>> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
>> sha1
>> 
>> is 4d7db712629261a92e6dcddfdcb7a446015bf432
>> 
>> 
>> Please VOTE:
>> 
>> [+1] yea, let's ship it
>> [+0] meh, don't care
>> [-1] yikes, stop because ${showstopper}
>> 
>> The VOTE is open for 72h.
>> 
>> 
>> Here is my own +1
>> 
>> txs and LieGrue,
>> strub

Re: [VOTE] release Apache DeltaSpike-1.8.1

[John D. Ament]

Hmmm looks like we crossed wires.  Can you rerun with current master?  I
want to ensure that 1299 is included.

On Sat, Dec 30, 2017 at 11:39 AM Mark Struberg 
wrote:

> Hi folks!
>
> I did run the necessary steps for releasing DeltaSpike-1.8.1
>
> The following bugs and improvements got implemented:
>
> Bug
>
> • [DELTASPIKE-1252] - data-documentation missing Optional return
> value
> • [DELTASPIKE-1271] - [perf] cache Transactional
> • [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is
> found
> • [DELTASPIKE-1275] - Build fails on Linux because Testclass
> filenames are to long
> • [DELTASPIKE-1278] - PropertyFileConfig does not respect optional
> on external resources
> • [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to
> persistenf factory config using "javax.persistence.bean.manager"
> • [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no
> configured value exists
> • [DELTASPIKE-1288] - Default values are not interpolated
> • [DELTASPIKE-1294] - Secured Stereotypes are not applied to
> inherited methods
> • [DELTASPIKE-1296] - PropertyFileConfig doesn't work with
> internal extensions
> • [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is
> always empty
> • [DELTASPIKE-1303] - @Configuration proxies should support List
> without converters
> • [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple
> redirects
> • [DELTASPIKE-1306] - IE sometimes doesn't set window.name
> correctly
> • [DELTASPIKE-1307] - Deltaspike JSF: XSS WindowIdHtmlRenderer.java
> Improvement
>
> • [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each
> use a different method to resolve EntityManagers
> • [DELTASPIKE-1070] - Refactor RepositoryComponent/s
> • [DELTASPIKE-1258] - skip flush with one EntityManager
> • [DELTASPIKE-1267] - Remove second factory mechanism of
> QueryBuilder's
> • [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
> • [DELTASPIKE-1269] - [perf] Cache singleResultType per method
> • [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
> • [DELTASPIKE-1274] - Refactor proxy-module / improve performance
> • [DELTASPIKE-1279] - SimpleSecurityViolation needs equals/hashcode
> • [DELTASPIKE-1283] - Placeholders not supported for defaults
> • [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse
> BeanManager
> • [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
> • [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on
> Weld by default
> Task
>
> • [DELTASPIKE-1259] - upgraded version numbers
> • [DELTASPIKE-1297] - add test with a customized DynamicMockManager
> • [DELTASPIKE-1298] - document customization of a
> DynamicMockManager
> Test
>
> • [DELTASPIKE-1273] - Test against OWB 2
>
>
>
> The staging repo is
>
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/
>
> The source release can be found at
>
> https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
> sha1
> 
> is 4d7db712629261a92e6dcddfdcb7a446015bf432
>
>
> Please VOTE:
>
> [+1] yea, let's ship it
> [+0] meh, don't care
> [-1] yikes, stop because ${showstopper}
>
> The VOTE is open for 72h.
>
>
> Here is my own +1
>
> txs and LieGrue,
> strub

[VOTE] release Apache DeltaSpike-1.8.1

[Mark Struberg]

Hi folks!

I did run the necessary steps for releasing DeltaSpike-1.8.1

The following bugs and improvements got implemented:

Bug

• [DELTASPIKE-1252] - data-documentation missing Optional return value
• [DELTASPIKE-1271] - [perf] cache Transactional
• [DELTASPIKE-1272] - ConfigResolver asList breaks if no value is found
• [DELTASPIKE-1275] - Build fails on Linux because Testclass filenames 
are to long
• [DELTASPIKE-1278] - PropertyFileConfig does not respect optional on 
external resources
• [DELTASPIKE-1281] - Deltaspike does not pass BeanManager to 
persistenf factory config using "javax.persistence.bean.manager"
• [DELTASPIKE-1287] - asList() getValue() fails with a NPE if no 
configured value exists
• [DELTASPIKE-1288] - Default values are not interpolated
• [DELTASPIKE-1294] - Secured Stereotypes are not applied to inherited 
methods
• [DELTASPIKE-1296] - PropertyFileConfig doesn't work with internal 
extensions
• [DELTASPIKE-1302] - ThreadPoolManager: ExecutorService map is always 
empty
• [DELTASPIKE-1303] - @Configuration proxies should support List 
without converters
• [DELTASPIKE-1305] - Multiple ds:windowId leads to multiple redirects
• [DELTASPIKE-1306] - IE sometimes doesn't set window.name correctly
• [DELTASPIKE-1307] - Deltaspike JSF: XSS WindowIdHtmlRenderer.java
Improvement

• [DELTASPIKE-940] - @Transactional and @EntityManagerConfig each use a 
different method to resolve EntityManagers
• [DELTASPIKE-1070] - Refactor RepositoryComponent/s
• [DELTASPIKE-1258] - skip flush with one EntityManager
• [DELTASPIKE-1267] - Remove second factory mechanism of QueryBuilder's
• [DELTASPIKE-1268] - QueryProcessorFactory should be a bean
• [DELTASPIKE-1269] - [perf] Cache singleResultType per method
• [DELTASPIKE-1270] - [perf] cache requiresTransaction per method
• [DELTASPIKE-1274] - Refactor proxy-module / improve performance
• [DELTASPIKE-1279] - SimpleSecurityViolation needs equals/hashcode
• [DELTASPIKE-1283] - Placeholders not supported for defaults
• [DELTASPIKE-1289] - GlobalInterceptorExtension could reuse BeanManager
• [DELTASPIKE-1293] - CDI qualifiers support for JSF converters
• [DELTASPIKE-1304] - Make CdiTestRunner use "flat" deployment on Weld 
by default
Task

• [DELTASPIKE-1259] - upgraded version numbers
• [DELTASPIKE-1297] - add test with a customized DynamicMockManager
• [DELTASPIKE-1298] - document customization of a DynamicMockManager
Test

• [DELTASPIKE-1273] - Test against OWB 2



The staging repo is
https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/

The source release can be found at
https://repository.apache.org/content/repositories/orgapachedeltaspike-1046/org/apache/deltaspike/deltaspike/1.8.1/
sha1 is 4d7db712629261a92e6dcddfdcb7a446015bf432


Please VOTE:

[+1] yea, let's ship it
[+0] meh, don't care
[-1] yikes, stop because ${showstopper}

The VOTE is open for 72h.


Here is my own +1

txs and LieGrue,
strub

[jira] [Updated] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated DELTASPIKE-1299:
--
Fix Version/s: (was: 1.8.1)
   1.8.2

> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.2
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[Mark Struberg (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306866#comment-16306866
 ] 

Mark Struberg commented on DELTASPIKE-1299:
---

Too late, already rolled it. 
But we can ship 1.8.2 shortly - with proper testing.

> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.1
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[Thomas Andraschko (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306862#comment-16306862
 ] 

Thomas Andraschko commented on DELTASPIKE-1299:
---

[~struberg] [~johndament] before doing the 1.8.1 release, could you please 
check if we can update ASM? AFAIK there is a new version which supports also 
java9. If all unittests are still running with the newest version, we should 
upgrade it. I'm away the next days, so i don't have the chance.

> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.1
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[John D. Ament (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John D. Ament resolved DELTASPIKE-1299.
---
Resolution: Fixed

Thanks for the patch, applied!

> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.1
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[John D. Ament (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John D. Ament updated DELTASPIKE-1299:
--
Fix Version/s: 1.8.1

> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.1
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DELTASPIKE-1299) Order by items are applied in alphabetic order

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306860#comment-16306860
 ] 

ASF subversion and git services commented on DELTASPIKE-1299:
-

Commit 2c4c80d65984648437dcd602f2ba57f9deca91f6 in deltaspike's branch 
refs/heads/master from [~Mobe]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=2c4c80d ]

DELTASPIKE-1299: fixed orderby item order


> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
> Fix For: 1.8.1
>
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order 
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the 
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (DELTASPIKE-1262) Remove CdiContainer control

[John D. Ament (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John D. Ament reopened DELTASPIKE-1262:
---

[~struberg] This is for a planned 2.0 (who knows when it will happen).  You can 
still accomplish what you're talking about with SeContainer though, but the 
question is why would you?  
https://github.com/cdi-spec/cdi/blob/master/api/src/main/java/javax/enterprise/inject/se/SeContainerInitializer.java#L259-L268

> Remove CdiContainer control
> ---
>
> Key: DELTASPIKE-1262
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1262
> Project: DeltaSpike
>  Issue Type: Improvement
>Reporter: John D. Ament
> Fix For: 2.0
>
>
> The bootstrap mechanisms for CDI are present in CDI 2.0.  We no longer need 
> this functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers

[John D. Ament (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306857#comment-16306857
 ] 

John D. Ament commented on DELTASPIKE-940:
--

Yep, simply forgot to upate JIRA!

> @Transactional and @EntityManagerConfig each use a different method to 
> resolve EntityManagers
> -
>
> Key: DELTASPIKE-940
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-940
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Data-Module, JPA-Module
>Reporter: Xavier Dury
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.8.1
>
> Attachments: ds940.patch
>
>
> When an application uses multiple {{EntityManager}}'s, there must be a way to 
> specify which one(s) should be used. Currently, {{@Transactional}} and 
> {{@EntityManagerConfig}} use different approaches:
> - {{@Transactional}} can take one or more qualifiers directly in its 
> {{qualifier()}} member ({{@Transactional(qualifier = MyDB.class)}})
> - While {{@EntityManagerConfig}} must define an {{EntityManagerResolver}} 
> ({{@EntityManagerConfig(entityManagerResolver = 
> MyDBEntityManagerResolver.class}})
> I think both should be unified and use a single way to specify which 
> {{EntityManager}} to use. IMHO, the {{@Transactional}} way of doing looks 
> better and should be applied to {{@EntityManagerConfig}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DELTASPIKE-1212) Introduce a ConfigResolver.resolveAllProperties method

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated DELTASPIKE-1212:
--
Fix Version/s: (was: 1.8.1)
   1.8.2

> Introduce a ConfigResolver.resolveAllProperties method
> --
>
> Key: DELTASPIKE-1212
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1212
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: John D. Ament
>Assignee: John D. Ament
> Fix For: 1.8.2
>
>
> Invoking ConfigResolver.getAllProperties does not expand out any inlined 
> variables.  In addition, assume the following properties file and project 
> stage = Development
> {code}
> some-service-url=${edge-server-url}/some-service
> edge-server-url=undefined
> edge-server-url.Development=http://development:8081
> edge-server-url.Staging=http://staging:8081
> edge-server-url.Production=http://prod:8081
> {code}
> calling {{getAllProperties}} returns the raw output of this file.  
> Introducing a new {{resolveAllProperties}} method would only return back the 
> active values.  The expected result would be
> {code}
> some-service-url=http://development:8081/some-service
> edge-server-url=http://development:8081
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1262) Remove CdiContainer control

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1262.
---
Resolution: Won't Fix

Hi John!
CdiContainer allows for far more control than CDI-2.0. DeltaSpike for example 
also allows to pass a property map. This is especially handy in embedded 
OpenEJB or GlassFish as it allows to pass in DataSource configuration and much 
more. CDI-2.0 doesn't cover all that.

> Remove CdiContainer control
> ---
>
> Key: DELTASPIKE-1262
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1262
> Project: DeltaSpike
>  Issue Type: Improvement
>Reporter: John D. Ament
> Fix For: 2.0
>
>
> The bootstrap mechanisms for CDI are present in CDI 2.0.  We no longer need 
> this functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1283) Placeholders not supported for defaults

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1283.
---
   Resolution: Fixed
Fix Version/s: 1.8.1

> Placeholders not supported for defaults
> ---
>
> Key: DELTASPIKE-1283
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1283
> Project: DeltaSpike
>  Issue Type: Improvement
>Reporter: Romain Manni-Bucau
>Assignee: Mark Struberg
> Fix For: 1.8.1
>
>
> It would be neat and common to be able to use placeholders for default values 
> as well. Typically:
> {code}
> @ConfigProperty(name = "", defaultValue = "${user.home}/foo.txt")
> String path();
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1296) PropertyFileConfig doesn't work with internal extensions

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1296.
---
   Resolution: Fixed
Fix Version/s: 1.8.1

> PropertyFileConfig doesn't work with internal extensions
> 
>
> Key: DELTASPIKE-1296
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1296
> Project: DeltaSpike
>  Issue Type: Bug
>Affects Versions: 1.8.0
>Reporter: Romain Manni-Bucau
>Assignee: Mark Struberg
> Fix For: 1.8.1
>
>
> We register PropertyFileConfig in AfterDeploymentValidation hook but 
> extensions potentially already read the config entries. Technically there is 
> probably no blocker to do it earlier and we should probably ensure all our 
> extensions read keys in AfterDeploymentValidation.
> My use case was a configured cron expression in the scheduler usage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1302) ThreadPoolManager: ExecutorService map is always empty

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1302.
---
   Resolution: Fixed
 Assignee: Romain Manni-Bucau
Fix Version/s: 1.8.1

> ThreadPoolManager: ExecutorService map is always empty
> --
>
> Key: DELTASPIKE-1302
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1302
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.8.0
>Reporter: Alonso Gonzalez
>Assignee: Romain Manni-Bucau
>Priority: Minor
> Fix For: 1.8.1
>
>
> ThreadPoolManager contains a ConcurrentHashMap that maps from a pool name to 
> an ExecutorService. Unfortunately the map never gets populated. It's always 
> empty.
> I need this because I want to use a specific ExecutorService with @Futureable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DELTASPIKE-1302) ThreadPoolManager: ExecutorService map is always empty

[Mark Struberg (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306801#comment-16306801
 ] 

Mark Struberg commented on DELTASPIKE-1302:
---

looks like it got fixed, right?


> ThreadPoolManager: ExecutorService map is always empty
> --
>
> Key: DELTASPIKE-1302
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1302
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.8.0
>Reporter: Alonso Gonzalez
>Priority: Minor
>
> ThreadPoolManager contains a ConcurrentHashMap that maps from a pool name to 
> an ExecutorService. Unfortunately the map never gets populated. It's always 
> empty.
> I need this because I want to use a specific ExecutorService with @Futureable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1307) Deltaspike JSF: XSS WindowIdHtmlRenderer.java

[Mark Struberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1307.
---
   Resolution: Fixed
Fix Version/s: 1.8.1

Txs for the report, that part should now be fixed!

> Deltaspike JSF: XSS WindowIdHtmlRenderer.java
> -
>
> Key: DELTASPIKE-1307
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1307
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: JSF-Module
>Affects Versions: 1.8.0
> Environment: any
>Reporter: md
>Assignee: Mark Struberg
>Priority: Blocker
>  Labels: security
> Fix For: 1.8.1
>
>
> 10 chars ough to be enough for XSS.
> Try escaping your variables.
> https://github.com/apache/deltaspike/blob/master/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java
> Line 80
> PoC
> dswid='-open()-'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DELTASPIKE-1307) Deltaspike JSF: XSS WindowIdHtmlRenderer.java

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306701#comment-16306701
 ] 

ASF subversion and git services commented on DELTASPIKE-1307:
-

Commit d95abe8c01d256da2ce0a5a88f4593138156a4e5 in deltaspike's branch 
refs/heads/master from [~struberg]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=d95abe8 ]

DELTASPIKE-1307 improve sanitise windowId

Also guard against html injection


> Deltaspike JSF: XSS WindowIdHtmlRenderer.java
> -
>
> Key: DELTASPIKE-1307
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1307
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: JSF-Module
>Affects Versions: 1.8.0
> Environment: any
>Reporter: md
>Assignee: Mark Struberg
>Priority: Blocker
>  Labels: security
>
> 10 chars ough to be enough for XSS.
> Try escaping your variables.
> https://github.com/apache/deltaspike/blob/master/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java
> Line 80
> PoC
> dswid='-open()-'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)