j-be opened a new pull request #83: Fix wrong JDK version in README.md.
URL: https://github.com/apache/deltaspike/pull/83
deltaspike/parent/pom.xml states 1.8.
Signed-off-by: Juri Berlanda
This is an automated message
j-be opened a new pull request #84: Scheduler control
URL: https://github.com/apache/deltaspike/pull/84
**Disclaimer:** I wanted to test GitHub's new "Draft Pull Request" feature,
which is why this exists.
### What it does
Introduce a new SPI to DeltaSpike's scheduler module to co
j-be commented on issue #84: Scheduler control
URL: https://github.com/apache/deltaspike/pull/84#issuecomment-466646141
I implemented the changes:
* invert logic of the per-job hook to `vetoJobExecution` to match Quartz'
`TriggerListener`
* don't touch `isActivated`
* add Log state
j-be commented on issue #84: Scheduler control
URL: https://github.com/apache/deltaspike/pull/84#issuecomment-466647381
I think the pull-request is ready now.
The last open discussion point, i.e. support for multiple implementations of
`SchedulerControl`, goes beyond what I initially pro
Daniel-Dos opened a new pull request #85: -DELTASPIKE-1371: Fixed documentation
Data Module
URL: https://github.com/apache/deltaspike/pull/85
see my comments here -> https://issues.apache.org/jira/browse/DELTASPIKE-1371
This
tandraschko merged pull request #85: -DELTASPIKE-1371: Fixed documentation Data
Module
URL: https://github.com/apache/deltaspike/pull/85
This is an automated message from the Apache Git Service.
To respond to the message, pl
Daniel-Dos commented on issue #85: -DELTASPIKE-1371: Fixed documentation Data
Module
URL: https://github.com/apache/deltaspike/pull/85#issuecomment-472022249
thanks
This is an automated message from the Apache Git Service.
To
j-be opened a new pull request #86: DELTASPIKE-1372 Fix test-control's
dependencies.
URL: https://github.com/apache/deltaspike/pull/86
Test-Control module has a de-facto runtime dependency on core-impl, which
is neither documented, nor declared in the pom. This commit adds it so
Test-
gpetracek merged pull request #86: DELTASPIKE-1372 Fix test-control's
dependencies.
URL: https://github.com/apache/deltaspike/pull/86
This is an automated message from the Apache Git Service.
To respond to the message, pleas
gpetracek merged pull request #84: Scheduler control
URL: https://github.com/apache/deltaspike/pull/84
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Daniel-Dos opened a new pull request #87: DELTASPIKE-1373-fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87
my commnets here = https://issues.apache.org/jira/browse/DELTASPIKE-1373
thanks
---
gpetracek commented on issue #87: DELTASPIKE-1373-fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87#issuecomment-474097637
please fix the commit-message
This is an automated message from th
Daniel-Dos commented on issue #87: DELTASPIKE-1373-fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87#issuecomment-474098784
I change to DELTASPIKE-1373-fix doc core and InjectableResource ?
thanks
-
Daniel-Dos removed a comment on issue #87: DELTASPIKE-1373-fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87#issuecomment-474098784
I change to DELTASPIKE-1373-fix doc core and InjectableResource ?
thanks
-
Daniel-Dos commented on issue #87: DELTASPIKE-1373:fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87#issuecomment-474103841
done .
This is an automated message from the Apache Git Service.
gpetracek merged pull request #87: DELTASPIKE-1373:fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, pl
Daniel-Dos commented on issue #87: DELTASPIKE-1373:fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87#issuecomment-474512649
thanks
This is an automated message from the Apache Git Service.
gpetracek commented on issue #87: DELTASPIKE-1373:fix doc core and
InjectableResource
URL: https://github.com/apache/deltaspike/pull/87#issuecomment-474515622
@Daniel-Dos:
thx as well!
This is an automated message from the
Daniel-Dos opened a new pull request #88: DELTASPIKE-1374: fix version to 1.9.0
URL: https://github.com/apache/deltaspike/pull/88
my comments
[here](https://issues.apache.org/jira/projects/DELTASPIKE/issues/DELTASPIKE-1374)
T
tandraschko merged pull request #76: List 'void' as valid Futureable return
URL: https://github.com/apache/deltaspike/pull/76
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tandraschko merged pull request #88: DELTASPIKE-1374: fix version to 1.9.0
URL: https://github.com/apache/deltaspike/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
tandraschko commented on issue #75: DELTASPIKE-1299: fixed orderby item order
URL: https://github.com/apache/deltaspike/pull/75#issuecomment-476133537
Already applied
This is an automated message from the Apache Git Service.
T
tandraschko commented on issue #76: List 'void' as valid Futureable return
URL: https://github.com/apache/deltaspike/pull/76#issuecomment-476133082
Thanks!
This is an automated message from the Apache Git Service.
To respond t
tandraschko closed pull request #75: DELTASPIKE-1299: fixed orderby item order
URL: https://github.com/apache/deltaspike/pull/75
This is an automated message from the Apache Git Service.
To respond to the message, please log
tandraschko merged pull request #83: Fix wrong JDK version in README.md.
URL: https://github.com/apache/deltaspike/pull/83
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tandraschko commented on issue #83: Fix wrong JDK version in README.md.
URL: https://github.com/apache/deltaspike/pull/83#issuecomment-476132577
Thanks!
This is an automated message from the Apache Git Service.
To respond to t
tandraschko commented on issue #88: DELTASPIKE-1374: fix version to 1.9.0
URL: https://github.com/apache/deltaspike/pull/88#issuecomment-476132259
Thanks!
This is an automated message from the Apache Git Service.
To respond to
Daniel-Dos commented on issue #88: DELTASPIKE-1374: fix version to 1.9.0
URL: https://github.com/apache/deltaspike/pull/88#issuecomment-476232553
your welcome
This is an automated message from the Apache Git Service.
To respo
rdomingonl opened a new pull request #89: Test and Bugfix for null
entitymanager when first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89
We discovered entity manager can be null when after startup of application,
multiple threads are accessing entitymanager at sam
tandraschko commented on issue #89: Test and Bugfix for null entitymanager when
first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-491777466
@rdomingonl thanks! could you please also create a issue for tracking?
---
os890 commented on issue #89: Test and Bugfix for null entitymanager when first
usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-492006511
@rdomingonl, @tandraschko:
this fix is not correct - please see initGlobalEntityManager - that one is
synchronize
os890 edited a comment on issue #89: Test and Bugfix for null entitymanager
when first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-492006511
@rdomingonl, @tandraschko:
this fix is not correct - please see initGlobalEntityManager - that one is
sync
os890 edited a comment on issue #89: Test and Bugfix for null entitymanager
when first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-492006511
@rdomingonl, @tandraschko:
this fix is not correct - please see initGlobalEntityManager - that one is
sync
rdomingonl commented on issue #89: Test and Bugfix for null entitymanager when
first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-492147816
@os890 @tandraschko Won't initGlobalEntityManager be invoked multiple times
when we don't synchronize lazyInitG
rdomingonl commented on issue #89: Test and Bugfix for null entitymanager when
first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-492151504
> @rdomingonl thanks! could you please also create a issue for tracking?
https://issues.apache.org/jira/b
os890 commented on issue #89: Test and Bugfix for null entitymanager when first
usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-492192794
@rdomingonl:
please see the second null check in initGlobalEntityManager
just adding a second synchronized
jw941 opened a new pull request #90: Fix an issue which causes "Argument bean
must not be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90
…Init() is called concurrently, the first thread should be the only one to
initialize it; however, deltaSpikeProxyInvocationHandler
os890 commented on issue #90: Fix an issue which causes "Argument bean must not
be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90#issuecomment-494665502
the changes in view of deltaSpikeProxyInvocationHandler is fine - the rest
isn't needed (since deltaSpikeProxyInvoca
tandraschko commented on issue #89: Test and Bugfix for null entitymanager when
first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89#issuecomment-494759161
Already fixed by gerhard:
https://github.com/apache/deltaspike/commit/eb6ae03a3286232ad0606d2f2bf6f4eb82607ab6
tandraschko closed pull request #89: Test and Bugfix for null entitymanager
when first usage is concurrent…
URL: https://github.com/apache/deltaspike/pull/89
This is an automated message from the Apache Git Service.
To respo
tandraschko commented on issue #90: Fix an issue which causes "Argument bean
must not be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90#issuecomment-494759543
@jw941 please create a issue and link it with this PR, i will apply it then
--
jw941 commented on issue #90: Fix an issue which causes "Argument bean must not
be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90#issuecomment-494782243
> @jw941 please create a issue and link it with this PR, i will apply it then
I can't see the issue tab under
jw941 removed a comment on issue #90: Fix an issue which causes "Argument bean
must not be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90#issuecomment-494782243
> @jw941 please create a issue and link it with this PR, i will apply it then
I can't see the issue ta
jw941 commented on issue #90: Fix an issue which causes "Argument bean must not
be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90#issuecomment-494786988
> @jw941 please create a issue and link it with this PR, i will apply it then
Created.
https://issues.apach
tandraschko merged pull request #90: Fix an issue which causes "Argument bean
must not be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90
This is an automated message from the Apache Git Service.
To respo
tandraschko commented on issue #90: Fix an issue which causes "Argument bean
must not be null". When lazy…
URL: https://github.com/apache/deltaspike/pull/90#issuecomment-494811683
Thanks!
This is an automated message from the
j-be opened a new pull request #91: DELTASPIKE-1382: Use
window.location.replace() for WindowId redirect.
URL: https://github.com/apache/deltaspike/pull/91
While assigning window.location directly seems to work well in most of the
cases, it manages to break Browser's back button if certa
tandraschko merged pull request #91: DELTASPIKE-1382: Use
window.location.replace() for WindowId redirect.
URL: https://github.com/apache/deltaspike/pull/91
This is an automated message from the Apache Git Service.
To respon
hiddewie opened a new pull request #92: Fix DELTASPIKE-1383. Fix multiple
threads causing NPE in Authorizer
URL: https://github.com/apache/deltaspike/pull/92
See issue in https://issues.apache.org/jira/browse/DELTASPIKE-1383.
gpetracek merged pull request #92: Fix DELTASPIKE-1383. Fix multiple threads
causing NPE in Authorizer
URL: https://github.com/apache/deltaspike/pull/92
This is an automated message from the Apache Git Service.
To respond to
j-be opened a new pull request #93: Implement @CreatedBy, similar to @CreatedOn
URL: https://github.com/apache/deltaspike/pull/93
As discussed on the mailing list, there are currently `@CreatedOn` and
`@ModifiedOn`, but only `@ModifiedBy` and no `@CreatedBy`.
This pull-request adds `
skybber opened a new pull request #94: Deltaspike 1377
URL: https://github.com/apache/deltaspike/pull/94
Fixed ID evaluation of annotation if annotation has property of array of
Class or Annotations
This is an automated messa
skybber closed pull request #94: Deltaspike 1377
URL: https://github.com/apache/deltaspike/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
tandraschko closed pull request #95: DELTASPIKE-1377 fix typeId evaluation
URL: https://github.com/apache/deltaspike/pull/95
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
tandraschko commented on issue #95: DELTASPIKE-1377 fix typeId evaluation
URL: https://github.com/apache/deltaspike/pull/95#issuecomment-516319380
Seems like mark fixed it, i will close this PR
This is an automated message fro
tandraschko merged pull request #93: Implement @CreatedBy, similar to @CreatedOn
URL: https://github.com/apache/deltaspike/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please lo
beikov opened a new pull request #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96
This is an automated message from the Apache Git Service.
To respond to the mess
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-535435684
Die you try if everything is working fine after the Upgrade in both java11
and 13?
-
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-535908095
I did not. Do you have a CI configuration file somewhere or can maybe add
java 11 and java 13 to the build matrix?
--
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-535911091
We have the Apache Jenkins but never managed it
Maybe Gerhard or Mark can assist?
However, or should be fine if you run
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-535912130
Oh
We probably dont have a tomee8 Profile yet, tomee7 only supports up to java8
--
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536446654
Ok, what do you suggest then? I can test if it makes DS work for me on Java
13, but I guess you would like to run the testsuite yo
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536447483
can you maybe try to introduce tomee8-build-managed? (TomEE8 was released
recently)
would be a great contribution!
--
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536471433
I just tried but it seems that running with just that profile in the root
directory won't work because container control tests wil
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536472533
i think you need to start from "deltaspike" dir
This is an a
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536475296
Stupid question, what kind of commands do you normally run to make sure
everything works? I just setup a Travis CI configuration b
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536476462
cd deltaspike
mvn clean install -Ptomee-build-managed
should work - at least on java8
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536562065
Are the WELD2 and OWB15 profiles supposed to work? I'm getting failures here
* WELD2: https://travis-ci.org/beikov/deltaspik
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536567979
no idea, never used/developed the testcontrol. CC @struberg ?
---
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536679990
Ok, I think everything should be fine now except for a few profiles that run
into errors that I can't explain. Maybe someone else
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.1 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536701407
FYI it's failing currently because asm 7.2 hasn't been synched to the google
mirror of maven central yet since it was released jus
beikov commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.2 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-536910930
There you go, ready for review: https://travis-ci.org/beikov/deltaspike
--
twyszomirski opened a new pull request #97: DELTASPIKE-1388 - Fix
initialization issue when using repos extended on interface
URL: https://github.com/apache/deltaspike/pull/97
Fixes https://issues.apache.org/jira/browse/DELTASPIKE-1388
--
tandraschko commented on issue #97: DELTASPIKE-1388 - Fix initialization issue
when using repos extended on interface
URL: https://github.com/apache/deltaspike/pull/97#issuecomment-538385835
Thanks for your contribution.
Would it be possible to add your case in new repository classes ins
tandraschko commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.2 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-538386620
Thanks, looks good for me!
This is an automated message from
tandraschko merged pull request #96: DELTASPIKE-1387 - Update ASM to 7.2 for
Java 13 support
URL: https://github.com/apache/deltaspike/pull/96
This is an automated message from the Apache Git Service.
To respond to the messa
twyszomirski commented on issue #97: DELTASPIKE-1388 - Fix initialization issue
when using repos extended on interface
URL: https://github.com/apache/deltaspike/pull/97#issuecomment-538887305
I changed the tests structure. For the sake of having "clean" history I
reworked my initial commit
tandraschko commented on issue #97: DELTASPIKE-1388 - Fix initialization issue
when using repos extended on interface
URL: https://github.com/apache/deltaspike/pull/97#issuecomment-539414557
Great, thank you for your contribution!
---
tandraschko merged pull request #97: DELTASPIKE-1388 - Fix initialization issue
when using repos extended on interface
URL: https://github.com/apache/deltaspike/pull/97
This is an automated message from the Apache Git Servic
beikov opened a new pull request #98: DELTASPIKE-1390 - Test and fix for
CLIENTWINDOW mode with frames
URL: https://github.com/apache/deltaspike/pull/98
https://issues.apache.org/jira/browse/DELTASPIKE-1390
You can see the failure which is based on the first commit here:
https://tra
beikov commented on issue #98: DELTASPIKE-1390 - Test and fix for CLIENTWINDOW
mode with frames
URL: https://github.com/apache/deltaspike/pull/98#issuecomment-541074178
The latest commit also fixes
https://issues.apache.org/jira/browse/DELTASPIKE-1391
-
beikov commented on issue #98: DELTASPIKE-1390 - Test and fix for CLIENTWINDOW
mode with frames
URL: https://github.com/apache/deltaspike/pull/98#issuecomment-541083288
As you can see here, tests run through:
https://travis-ci.org/beikov/deltaspike/builds/596614575
---
tandraschko merged pull request #98: DELTASPIKE-1390 - Test and fix for
CLIENTWINDOW mode with frames
URL: https://github.com/apache/deltaspike/pull/98
This is an automated message from the Apache Git Service.
To respond to
balta3 commented on issue #96: DELTASPIKE-1387 - Update ASM to 7.2 for Java 13
support
URL: https://github.com/apache/deltaspike/pull/96#issuecomment-549154056
Is there any roadmap when this will be released? I want to switch to JDK 13
:)
--
garyhodgson opened a new pull request #99: DELTASPIKE-1396 - Incorrect
parameter meaning in AbstractQuartzSchedu…
URL: https://github.com/apache/deltaspike/pull/99
…ler.stop of Scheduler Module
This is an automated message fr
tandraschko commented on issue #99: DELTASPIKE-1396 - Incorrect parameter
meaning in AbstractQuartzSchedu…
URL: https://github.com/apache/deltaspike/pull/99#issuecomment-551433965
@struberg did you change it without applying the PR? Then we should close
this here
-
beikov opened a new pull request #100: [DELTASPIKE-1393] Testcase for
reproducing ContextNotActiveException
URL: https://github.com/apache/deltaspike/pull/100
Reproducer test case for issues with CLIENTWINDOW mode when using POST from
non-JSF page to a JSF one.
https://issues.apache
struberg closed pull request #99: DELTASPIKE-1396 - Incorrect parameter meaning
in AbstractQuartzSchedu…
URL: https://github.com/apache/deltaspike/pull/99
This is an automated message from the Apache Git Service.
To respond
struberg commented on issue #99: DELTASPIKE-1396 - Incorrect parameter meaning
in AbstractQuartzSchedu…
URL: https://github.com/apache/deltaspike/pull/99#issuecomment-552762434
yes indeed, sorry @garyhodgson I did not see the PR before :(
Thanks again for the report and patch!
-
dependabot[bot] opened a new pull request #101: Bump httpclient from 4.2.5 to
4.3.6 in /deltaspike/cdictrl/servlet
URL: https://github.com/apache/deltaspike/pull/101
Bumps httpclient from 4.2.5 to 4.3.6.
[](https://medium.co
struberg merged pull request #103: [SECURITY] Use HTTPS to resolve dependencies
in Maven Build
URL: https://github.com/apache/deltaspike/pull/103
This is an automated message from the Apache Git Service.
To respond to the me
YYTVicky opened a new pull request #104: Change hash and cipher algorithm
URL: https://github.com/apache/deltaspike/pull/104
Change hash and cipher algorithm for security concern
This is an automated message from the Apache Gi
Daniel-Dos opened a new pull request #105: DELTASPIKE-1403
URL: https://github.com/apache/deltaspike/pull/105
[my comments](https://issues.apache.org/jira/browse/DELTASPIKE-1403)
This is an automated message from the Apache Gi
tandraschko commented on issue #104: Change hash and cipher algorithm
URL: https://github.com/apache/deltaspike/pull/104#issuecomment-605629335
Can you please add a JIRA ticket before (with some description)?
This is an automa
tandraschko merged pull request #105: DELTASPIKE-1403 - fix version to 1.9.3
URL: https://github.com/apache/deltaspike/pull/105
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tandraschko merged pull request #101: Bump httpclient from 4.2.5 to 4.3.6 in
/deltaspike/cdictrl/servlet
URL: https://github.com/apache/deltaspike/pull/101
This is an automated message from the Apache Git Service.
To respond
Daniel-Dos opened a new pull request #106: DELTASPIKE-1404 - add some links for
example and articles.
URL: https://github.com/apache/deltaspike/pull/106
- add some links for articles and examples.
This is an automated messag
Mahir92 commented on pull request #104:
URL: https://github.com/apache/deltaspike/pull/104#issuecomment-624001825
Hi @tandraschko , a JIRA issue has been created addressing this change.
Please take a look at the
[issue](https://issues.apache.org/jira/browse/DELTASPIKE-1406) and let us know
1 - 100 of 224 matches
Mail list logo