[jira] [Commented] (DELTASPIKE-1007) test @Transactional and @TransactionScoped support for @Repository
[ https://issues.apache.org/jira/browse/DELTASPIKE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448071#comment-16448071 ] Thomas Andraschko commented on DELTASPIKE-1007: --- We maybe don't have tests for Transactional but we have many many tests for interceptors. I think it's ok to close. WDYT [~gpetracek]? > test @Transactional and @TransactionScoped support for @Repository > -- > > Key: DELTASPIKE-1007 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1007 > Project: DeltaSpike > Issue Type: Task > Components: Data-Module, Tests >Affects Versions: 1.5.1 >Reporter: Gerhard Petracek >Assignee: Harald Wellmann >Priority: Major > > currently it's tested manually, but we should add a test to the test-suite. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DELTASPIKE-1007) test @Transactional and @TransactionScoped support for @Repository
[ https://issues.apache.org/jira/browse/DELTASPIKE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066250#comment-15066250 ] Gerhard Petracek commented on DELTASPIKE-1007: -- [~hwellmann] thx for helping with this topic, but this ticket was intended for @org.apache.deltaspike.jpa.api.transaction.Transactional and @org.apache.deltaspike.jpa.api.transaction.TransactionScoped -> i'm not sure that we should add a whole module for it. the intention was just to test that the @org.apache.deltaspike.jpa.api.transaction.Transactional gets called as expected. > test @Transactional and @TransactionScoped support for @Repository > -- > > Key: DELTASPIKE-1007 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1007 > Project: DeltaSpike > Issue Type: Task > Components: Data-Module, Tests >Affects Versions: 1.5.1 >Reporter: Gerhard Petracek >Assignee: Harald Wellmann > Fix For: 1.5.3 > > > currently it's tested manually, but we should add a test to the test-suite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1007) test @Transactional and @TransactionScoped support for @Repository
[
https://issues.apache.org/jira/browse/DELTASPIKE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066274#comment-15066274
]
Harald Wellmann commented on DELTASPIKE-1007:
-
Well, the description was a bit vague... My tests do cover both flavours of
{{\@Transactional}}. There are {{Jta*}} tests using the JTA 1.2 annotations
(providing regression tests for DELTASPIKE-420) and {{DeltaSpike*}} tests using
the DeltaSpike JPA annotations.
A separate test module seems to be easiest way to handle multiple versions of
the JTA API. Moving these new tests into the Data {{impl}} module would require
upgrading the JTA dependency to 1.2, which might lead to incompatibility with
Java EE 6.
> test @Transactional and @TransactionScoped support for @Repository
> --
>
> Key: DELTASPIKE-1007
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1007
> Project: DeltaSpike
> Issue Type: Task
> Components: Data-Module, Tests
>Affects Versions: 1.5.1
>Reporter: Gerhard Petracek
>Assignee: Harald Wellmann
> Fix For: 1.5.3
>
>
> currently it's tested manually, but we should add a test to the test-suite.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1007) test @Transactional and @TransactionScoped support for @Repository
[ https://issues.apache.org/jira/browse/DELTASPIKE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066541#comment-15066541 ] Gerhard Petracek commented on DELTASPIKE-1007: -- well, we have to test mainly our logic and in this case just if interceptors like the tx-interceptor works with the data-module. imo it doesn't make sense to test the same again (since @javax.transaction.Transactional) is technically just an other interceptor you can use. we also don't test data-repos with other ee-interceptors, because they should just work. -> from the conceptional point of view we currently have an own module just to have a "redundant" test. > test @Transactional and @TransactionScoped support for @Repository > -- > > Key: DELTASPIKE-1007 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1007 > Project: DeltaSpike > Issue Type: Task > Components: Data-Module, Tests >Affects Versions: 1.5.1 >Reporter: Gerhard Petracek >Assignee: Harald Wellmann > Fix For: 1.5.3 > > > currently it's tested manually, but we should add a test to the test-suite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
