[jira] [Commented] (DELTASPIKE-1030) Initial redirect does not encode URL properly
[ https://issues.apache.org/jira/browse/DELTASPIKE-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021707#comment-15021707 ] Armin Schaberl commented on DELTASPIKE-1030: thanks for your reply. you are definitly right - it's not a good idea to mix encodings. but i'm in the situation of developing framework components for many of our applications, so the real applications are out of my control. i have to think about it, it still may be the best solution to change the default response encoding using servlet filters. despite of these considerations, the UrlEncoder spi seems to be a good idea. flexibility is alwas a good idea :) > Initial redirect does not encode URL properly > - > > Key: DELTASPIKE-1030 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1030 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.5.1 > Environment: JBoss EAP 6.4.4 > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 >Reporter: Armin Schaberl >Assignee: Rafael Benevides >Priority: Minor > Fix For: 1.5.2 > > > Unicode Parameters on the initial request to an application won't get encoded > properly. > They are currently encoded by the response's default encoding (i.e. > ISO8859-1). The encoding for the servers URL parameters could possible be > another one. I.e. we are using a UTF-8 (due to vm parameter > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 on our JBoss EAP 6.4). > So Deltaspike generates a redirect URL to the same Application/Server with an > incorrect encoding. > The test ist quite simple, just use parameters with German umlauts on the > initial request to a server which supports UTF-8 URL parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1030) Initial redirect does not encode URL properly
[ https://issues.apache.org/jira/browse/DELTASPIKE-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021853#comment-15021853 ] Gerhard Petracek commented on DELTASPIKE-1030: -- if you need such a spi, please create a separated ticket for such an improvement. > Initial redirect does not encode URL properly > - > > Key: DELTASPIKE-1030 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1030 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.5.1 > Environment: JBoss EAP 6.4.4 > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 >Reporter: Armin Schaberl >Assignee: Rafael Benevides >Priority: Minor > Fix For: 1.5.2 > > > Unicode Parameters on the initial request to an application won't get encoded > properly. > They are currently encoded by the response's default encoding (i.e. > ISO8859-1). The encoding for the servers URL parameters could possible be > another one. I.e. we are using a UTF-8 (due to vm parameter > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 on our JBoss EAP 6.4). > So Deltaspike generates a redirect URL to the same Application/Server with an > incorrect encoding. > The test ist quite simple, just use parameters with German umlauts on the > initial request to a server which supports UTF-8 URL parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1030) Initial redirect does not encode URL properly
[ https://issues.apache.org/jira/browse/DELTASPIKE-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015514#comment-15015514 ] Thomas Andraschko commented on DELTASPIKE-1030: --- [~gpetracek] Could you please have a look at this? You already fixed the encoding in the initial redirect. > Initial redirect does not encode URL properly > - > > Key: DELTASPIKE-1030 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1030 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.5.1 > Environment: JBoss EAP 6.4.4 > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 >Reporter: Armin Schaberl >Assignee: Gerhard Petracek > Fix For: 1.5.2 > > > Unicode Parameters on the initial request to an application won't get encoded > properly. > They are currently encoded by the response's default encoding (i.e. > ISO8859-1). The encoding for the servers URL parameters could possible be > another one. I.e. we are using a UTF-8 (due to vm parameter > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 on our JBoss EAP 6.4). > So Deltaspike generates a redirect URL to the same Application/Server with an > incorrect encoding. > The test ist quite simple, just use parameters with German umlauts on the > initial request to a server which supports UTF-8 URL parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1030) Initial redirect does not encode URL properly
[ https://issues.apache.org/jira/browse/DELTASPIKE-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015568#comment-15015568 ] Gerhard Petracek commented on DELTASPIKE-1030: -- we use the encoding returned by ExternalContext#getResponseCharacterEncoding - that's the official api to use -> please check if the jsf implementation you are using returns the correct value. the composed url even gets passed to ExternalContext#encodeResourceURL before we send the redirect. > Initial redirect does not encode URL properly > - > > Key: DELTASPIKE-1030 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1030 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.5.1 > Environment: JBoss EAP 6.4.4 > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 >Reporter: Armin Schaberl >Assignee: Gerhard Petracek > Fix For: 1.5.2 > > > Unicode Parameters on the initial request to an application won't get encoded > properly. > They are currently encoded by the response's default encoding (i.e. > ISO8859-1). The encoding for the servers URL parameters could possible be > another one. I.e. we are using a UTF-8 (due to vm parameter > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 on our JBoss EAP 6.4). > So Deltaspike generates a redirect URL to the same Application/Server with an > incorrect encoding. > The test ist quite simple, just use parameters with German umlauts on the > initial request to a server which supports UTF-8 URL parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1030) Initial redirect does not encode URL properly
[ https://issues.apache.org/jira/browse/DELTASPIKE-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018419#comment-15018419 ] Gerhard Petracek commented on DELTASPIKE-1030: -- [~aschaberl] thx for providing more details about the constellation you have. we could provide an optional UrlEncoder spi, because we have several parts which encode an url (and we can't provide a config for all of them). however, you should never mix encodings in your pages. if your application would break because you mixed it, you need to fix your application (because sooner or later it would break anyway due to that reason). > Initial redirect does not encode URL properly > - > > Key: DELTASPIKE-1030 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1030 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.5.1 > Environment: JBoss EAP 6.4.4 > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 >Reporter: Armin Schaberl >Assignee: Rafael Benevides > Fix For: 1.5.2 > > > Unicode Parameters on the initial request to an application won't get encoded > properly. > They are currently encoded by the response's default encoding (i.e. > ISO8859-1). The encoding for the servers URL parameters could possible be > another one. I.e. we are using a UTF-8 (due to vm parameter > -Dorg.apache.catalina.connector.URI_ENCODING=UTF-8 on our JBoss EAP 6.4). > So Deltaspike generates a redirect URL to the same Application/Server with an > incorrect encoding. > The test ist quite simple, just use parameters with German umlauts on the > initial request to a server which supports UTF-8 URL parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
