[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316899#comment-16316899 ] Thomas Andraschko commented on DELTASPIKE-1311: --- I think we can close this one. Deactivatable and @Vetoed are fine. > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313288#comment-16313288 ] John D. Ament commented on DELTASPIKE-1311: --- [~gpetracek] thanks for the reminder. We already support Deactivatable on repositories - https://github.com/apache/deltaspike/blob/master/deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/RepositoryExtension.java#L87 I've got a response I'll share on user list that the person can use immediately. > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313267#comment-16313267 ] Gerhard Petracek commented on DELTASPIKE-1311: -- @john: as i just mentioned we have Deactivatable for that purpose already (we just need to add the check to RepositoryExtension) > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313263#comment-16313263 ] Thomas Andraschko commented on DELTASPIKE-1311: --- -1 for introducing yet-another-config I'm fine with @Vetoed or Deactivatable for now > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313258#comment-16313258 ] Gerhard Petracek commented on DELTASPIKE-1311: -- @observer ordering: we discussed that already (in the context of @Exclude) and the agreement was that we don't use it in ds itself (because it's a Deactivatable feature) and due to the lack of ordering also not for artifacts which get registered dynamically (instead we support Deactivatable here as well). with cdi 2.0 we have a new situation, however, before v2.0 we can only support it via @Vetoed or Deactivatable easily. i would only add support for @Exclude if all parts of it are supported (which means a dependency to ExcludeExtension). > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[
https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313252#comment-16313252
]
John D. Ament commented on DELTASPIKE-1311:
---
[~romain.manni-bucau] no this is a common use case (the on list reporter
mentions CDI 2.0). Vetoed will work, I just worry about not having a solution
for EE6 use cases. The problem is that the repository is not an actual bean,
but we register one, so we want to use {{@Vetoed}} or similar to indicate it
should not have a repository bean registered.
[~gpetracek] [~tandraschko] what about the idea of also introducing a config
property, e.g. {{com.mycompany.repository.RepositoryClass.vetoed=true}} to see
if it should be vetoed? Considered {{false}} by default.
> Allow Excluded Repositories
> ---
>
> Key: DELTASPIKE-1311
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Data-Module
>Affects Versions: 1.8.1
>Reporter: John D. Ament
>Assignee: John D. Ament
> Fix For: 1.8.2
>
>
> When a repository is discovered, if it has @Exclude on it, then don't include
> it as a possible repository bean.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313224#comment-16313224 ] Gerhard Petracek commented on DELTASPIKE-1311: -- +1 for @Vetoed, but not for @Exclude (at least until we know which version of cdi the initial reporter is using). we would introduce something special, which is part of cdi since almost 5 years. + maybe we should improve the extensibility of RepositoryExtension (several other extension-classes are extensible/replaceable already). > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313214#comment-16313214 ] Thomas Andraschko commented on DELTASPIKE-1311: --- Yep right. If our ExcludeExtension would run before the RepoExtensions, it might already work... > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313201#comment-16313201 ] Romain Manni-Bucau commented on DELTASPIKE-1311: No need of veto since it will not be seen so I tend to join Gerhard here, is it only a legacy, EE 6 enhancement? If so we should fully support exclude (doable since part of the core feature) IMHO. > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313187#comment-16313187 ] Thomas Andraschko commented on DELTASPIKE-1311: --- I think it's ok for to just check for the annotation(s) (both Vetoed and Exclude) as the example is quite special. > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313181#comment-16313181 ] John D. Ament commented on DELTASPIKE-1311: --- It probably works well as a minimal slice. We can iterate over it as we gain user input on the enhancement. No reason to boil the ocean. > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1311) Allow Excluded Repositories
[ https://issues.apache.org/jira/browse/DELTASPIKE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313171#comment-16313171 ] Gerhard Petracek commented on DELTASPIKE-1311: -- imo it doesn't make sense to just support a small part of @Exclude here. > Allow Excluded Repositories > --- > > Key: DELTASPIKE-1311 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1311 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.8.1 >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.8.2 > > > When a repository is discovered, if it has @Exclude on it, then don't include > it as a possible repository bean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
