RE: [DISCUSS] Add persist and merge methods to EntityRepository

2015-08-25 Thread Marvin Toll
- From: Thomas Hug [mailto:thomas@gmail.com] Sent: Monday, August 24, 2015 5:00 PM To: dev@deltaspike.apache.org Subject: Re: [DISCUSS] Add persist and merge methods to EntityRepository Also I had the impression that having save, persist and merge would be confusing - seems like that assumption

Re: [DISCUSS] Add persist and merge methods to EntityRepository

2015-08-24 Thread Thomas Hug
EntityRepository is optional, so default hierarchy might be misleading here ;) Similar as EntityRepository or CriteriaSupport, EntityManagerDelegate was rather something to put on top of a repo, that's primarily why I didn't extend EntityRepository from it. Also I had the impression that having

Re: [DISCUSS] Add persist and merge methods to EntityRepository

2015-08-23 Thread John D. Ament
On Sun, Aug 23, 2015 at 12:39 PM Thomas Andraschko andraschko.tho...@gmail.com wrote: Thats not required. You can just extend/implement EntityManagerDelegate Thanks for pointing that out. I missed that note in the docs. Is there a reason that this isn't the default hierarchy? 2015-08-23

Re: [DISCUSS] Add persist and merge methods to EntityRepository

2015-08-23 Thread Thomas Andraschko
Thats not required. You can just extend/implement EntityManagerDelegate 2015-08-23 17:37 GMT+02:00 Harald Wellmann hwellmann...@gmail.com: +1 Regards, Harald Am 22.08.2015 um 03:23 schrieb John D. Ament: All, Based on the findings from Harald, and the general issues being seen with

Re: [DISCUSS] Add persist and merge methods to EntityRepository

2015-08-23 Thread Harald Wellmann
+1 Regards, Harald Am 22.08.2015 um 03:23 schrieb John D. Ament: All, Based on the findings from Harald, and the general issues being seen with EntityRepository I'd like to propose that we add merge and persist methods to the EntityRepository interface. Both methods would delegate down

RE: [DISCUSS] Add persist and merge methods to EntityRepository

2015-08-21 Thread Marvin Toll
21, 2015 9:23 PM To: deltaspike dev@deltaspike.apache.org Subject: [DISCUSS] Add persist and merge methods to EntityRepository All, Based on the findings from Harald, and the general issues being seen with EntityRepository I'd like to propose that we add merge and persist methods

[DISCUSS] Add persist and merge methods to EntityRepository

2015-08-21 Thread John D. Ament
All, Based on the findings from Harald, and the general issues being seen with EntityRepository I'd like to propose that we add merge and persist methods to the EntityRepository interface. Both methods would delegate down direct to the underlying EntityManager's methods of the same signature and