Re: [DISCUSS] GitHub PR Builder

Yes, sorry, I wasn't clear. If you rebase their commit then it has a tendency to not close the PR which is when you need "This closes #123" John On Wed, Jul 6, 2016 at 6:21 AM Daniel Cunha wrote: > Hi John, > > When we're following the steps presented by asg-git, the PR is marked like > merged

Re: [DISCUSS] GitHub PR Builder

Hi John, When we're following the steps presented by asg-git, the PR is marked like merged. For example: https://github.com/apache/deltaspike/pull/57 The steps: https://issues.apache.org/jira/browse/DELTASPIKE-1180?focusedCommentId=15361289&page=com.atlassian.jira.plugin.system.issuetabpanels:com

Re: [DISCUSS] GitHub PR Builder

Short answer is you can't. You need to pull the branch and push to our master. You need to make the commit message include the "This closes #123" line to make github know to close it. Or ask the requestor to close it. There is an open git-dual POC from infra. Last I looked, it wasn't doing wel

Re: [DISCUSS] GitHub PR Builder

+1 Stupid question but how can i merge PRs from github? The last PRs from georgekankava are looking good. 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth : > I think such build jobs are very valuable. So +1 fo

Re: [DISCUSS] GitHub PR Builder

I think such build jobs are very valuable. So +1 for them. 2016-07-06 4:06 GMT+02:00 John D. Ament : > Hey guys > > We've been getting a few more PRs over github. Its IMHO easier to merge > those instead of patches in JIRA tickets. > > I went ahead and created a PR build job. When someone rai

[DISCUSS] GitHub PR Builder

Hey guys We've been getting a few more PRs over github. Its IMHO easier to merge those instead of patches in JIRA tickets. I went ahead and created a PR build job. When someone raises a PR against us in github, it will trigger a build. Right now that build only runs OWB 1.6.x, but I think it w