[jira] [Commented] (DELTASPIKE-1296) PropertyFileConfig doesn't work with internal extensions
[ https://issues.apache.org/jira/browse/DELTASPIKE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270512#comment-16270512 ] ASF subversion and git services commented on DELTASPIKE-1296: - Commit 5685edbf58e42baa285198f9b6244d88b82ff7bf in deltaspike's branch refs/heads/master from [~rmannibucau] [ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=5685edb ] DELTASPIKE-1296 fixing configuration extension lifecycle > PropertyFileConfig doesn't work with internal extensions > > > Key: DELTASPIKE-1296 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1296 > Project: DeltaSpike > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Romain Manni-Bucau >Assignee: Mark Struberg > > We register PropertyFileConfig in AfterDeploymentValidation hook but > extensions potentially already read the config entries. Technically there is > probably no blocker to do it earlier and we should probably ensure all our > extensions read keys in AfterDeploymentValidation. > My use case was a configured cron expression in the scheduler usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1296) PropertyFileConfig doesn't work with internal extensions
[
https://issues.apache.org/jira/browse/DELTASPIKE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270455#comment-16270455
]
Matej Novotny commented on DELTASPIKE-1296:
---
[~struberg] The commit/fix is against
[specification|http://docs.jboss.org/cdi/spec/1.2/cdi-spec.html#beanmanager] as
you are not allowed to invoke {{BeanManager.getReference()}} before
{{AfterDeploymentValidation}}. I just run the build with Weld 3 and it crashes
there (as expected) on DefinitionException.
> PropertyFileConfig doesn't work with internal extensions
>
>
> Key: DELTASPIKE-1296
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1296
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.8.0
>Reporter: Romain Manni-Bucau
>Assignee: Mark Struberg
>
> We register PropertyFileConfig in AfterDeploymentValidation hook but
> extensions potentially already read the config entries. Technically there is
> probably no blocker to do it earlier and we should probably ensure all our
> extensions read keys in AfterDeploymentValidation.
> My use case was a configured cron expression in the scheduler usage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1296) PropertyFileConfig doesn't work with internal extensions
[ https://issues.apache.org/jira/browse/DELTASPIKE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266915#comment-16266915 ] ASF subversion and git services commented on DELTASPIKE-1296: - Commit f0d56be8f4867908c39c1937fdf25fa8d8524c07 in deltaspike's branch refs/heads/master from [~struberg] [ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=f0d56be ] DELTASPIKE-1296 move ConfigSource registration we now register PropertyFileConfig ConfigSources already in AfterBeanDiscovery and not in AfterDeploymentValidation. As requested by Romain > PropertyFileConfig doesn't work with internal extensions > > > Key: DELTASPIKE-1296 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1296 > Project: DeltaSpike > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Romain Manni-Bucau >Assignee: Mark Struberg > > We register PropertyFileConfig in AfterDeploymentValidation hook but > extensions potentially already read the config entries. Technically there is > probably no blocker to do it earlier and we should probably ensure all our > extensions read keys in AfterDeploymentValidation. > My use case was a configured cron expression in the scheduler usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1296) PropertyFileConfig doesn't work with internal extensions
[ https://issues.apache.org/jira/browse/DELTASPIKE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266801#comment-16266801 ] Romain Manni-Bucau commented on DELTASPIKE-1296: If we register them at AfterBeanDiscovery phase we would be deterministic and solve the inter extension issue. Strictly speaking having a single AfterDeploymentValidation deltaspike extension and sorting ourself all the extensions using this hook would make it deterministic too and solve the original issue. In any case current implementation is not usable since it leads to a misbehavior in most cases cause using the SPI file for a PropertyFileConfig is all but recommanded in all our doc and would lead to a simple ConfigSource so is not justified. > PropertyFileConfig doesn't work with internal extensions > > > Key: DELTASPIKE-1296 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1296 > Project: DeltaSpike > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Romain Manni-Bucau >Assignee: Mark Struberg > > We register PropertyFileConfig in AfterDeploymentValidation hook but > extensions potentially already read the config entries. Technically there is > probably no blocker to do it earlier and we should probably ensure all our > extensions read keys in AfterDeploymentValidation. > My use case was a configured cron expression in the scheduler usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1296) PropertyFileConfig doesn't work with internal extensions
[ https://issues.apache.org/jira/browse/DELTASPIKE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266630#comment-16266630 ] Romain Manni-Bucau commented on DELTASPIKE-1296: Hi Mark, issue is really to have a config module not compatible with other module usage. 1 should directly register the config and not way for any later phase to ensure it is used by other extensions IMO. I'm also fine forbidding any discovery other than SPI one since it would make it work smoothly but it is less user friendly. > PropertyFileConfig doesn't work with internal extensions > > > Key: DELTASPIKE-1296 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1296 > Project: DeltaSpike > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Romain Manni-Bucau >Assignee: Mark Struberg > > We register PropertyFileConfig in AfterDeploymentValidation hook but > extensions potentially already read the config entries. Technically there is > probably no blocker to do it earlier and we should probably ensure all our > extensions read keys in AfterDeploymentValidation. > My use case was a configured cron expression in the scheduler usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
