[jira] [Commented] (DELTASPIKE-1390) Client window handler doesn't work with frames

2019-10-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950283#comment-16950283
 ] 

ASF subversion and git services commented on DELTASPIKE-1390:
-

Commit f9f0c6aaf997d7a8224d06290048f2e8eae5f1d7 in deltaspike's branch 
refs/heads/master from Thomas Andraschko
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=f9f0c6a ]

Merge pull request #98 from beikov/DELTASPIKE-1390

DELTASPIKE-1390 - Test and fix for CLIENTWINDOW mode with frames

> Client window handler doesn't work with frames
> --
>
> Key: DELTASPIKE-1390
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1390
> Project: DeltaSpike
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>  Components: JSF-Module
>Reporter: Christian Beikov
>Priority: Major
> Fix For: 1.9.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The CLIENTWINDOW handler code loses the window when frames are involved.
> Using e.g. a window scoped bean with the Primefaces Dialog Framework will 
> result in issues. The bean is initialized in window1. A click on a button 
> opens a dialog, which is opened through an iframe, but the dialog doesn't use 
> the window id defined in the parent window. If a button in the dialog 
> requires the original bean, it will find an uninitialized bean, because the 
> frame gets a new window id window2.
> The solution is to use the root window for the window id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1390) Client window handler doesn't work with frames

2019-10-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950281#comment-16950281
 ] 

ASF subversion and git services commented on DELTASPIKE-1390:
-

Commit cdc155ef3042ec93bce3574eef78e9d78eaecbad in deltaspike's branch 
refs/heads/master from Christian Beikov
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=cdc155e ]

DELTASPIKE-1390 - Fix CLIENTWINDOW mode to work with frames


> Client window handler doesn't work with frames
> --
>
> Key: DELTASPIKE-1390
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1390
> Project: DeltaSpike
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>  Components: JSF-Module
>Reporter: Christian Beikov
>Priority: Major
> Fix For: 1.9.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The CLIENTWINDOW handler code loses the window when frames are involved.
> Using e.g. a window scoped bean with the Primefaces Dialog Framework will 
> result in issues. The bean is initialized in window1. A click on a button 
> opens a dialog, which is opened through an iframe, but the dialog doesn't use 
> the window id defined in the parent window. If a button in the dialog 
> requires the original bean, it will find an uninitialized bean, because the 
> frame gets a new window id window2.
> The solution is to use the root window for the window id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1390) Client window handler doesn't work with frames

2019-10-13 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950279#comment-16950279
 ] 

Thomas Andraschko commented on DELTASPIKE-1390:
---

Looks good to me, thanks!

> Client window handler doesn't work with frames
> --
>
> Key: DELTASPIKE-1390
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1390
> Project: DeltaSpike
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>  Components: JSF-Module
>Reporter: Christian Beikov
>Priority: Major
> Fix For: 1.9.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The CLIENTWINDOW handler code loses the window when frames are involved.
> Using e.g. a window scoped bean with the Primefaces Dialog Framework will 
> result in issues. The bean is initialized in window1. A click on a button 
> opens a dialog, which is opened through an iframe, but the dialog doesn't use 
> the window id defined in the parent window. If a button in the dialog 
> requires the original bean, it will find an uninitialized bean, because the 
> frame gets a new window id window2.
> The solution is to use the root window for the window id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1390) Client window handler doesn't work with frames

2019-10-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950284#comment-16950284
 ] 

ASF subversion and git services commented on DELTASPIKE-1390:
-

Commit f9f0c6aaf997d7a8224d06290048f2e8eae5f1d7 in deltaspike's branch 
refs/heads/master from Thomas Andraschko
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=f9f0c6a ]

Merge pull request #98 from beikov/DELTASPIKE-1390

DELTASPIKE-1390 - Test and fix for CLIENTWINDOW mode with frames

> Client window handler doesn't work with frames
> --
>
> Key: DELTASPIKE-1390
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1390
> Project: DeltaSpike
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>  Components: JSF-Module
>Reporter: Christian Beikov
>Priority: Major
> Fix For: 1.9.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The CLIENTWINDOW handler code loses the window when frames are involved.
> Using e.g. a window scoped bean with the Primefaces Dialog Framework will 
> result in issues. The bean is initialized in window1. A click on a button 
> opens a dialog, which is opened through an iframe, but the dialog doesn't use 
> the window id defined in the parent window. If a button in the dialog 
> requires the original bean, it will find an uninitialized bean, because the 
> frame gets a new window id window2.
> The solution is to use the root window for the window id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1390) Client window handler doesn't work with frames

2019-10-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950280#comment-16950280
 ] 

ASF subversion and git services commented on DELTASPIKE-1390:
-

Commit 3eba0378b4ddd613749ed60a5353f73fff76b89f in deltaspike's branch 
refs/heads/master from Christian Beikov
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=3eba037 ]

DELTASPIKE-1390 - Test that frames don't work with CLIENTWINDOW mode


> Client window handler doesn't work with frames
> --
>
> Key: DELTASPIKE-1390
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1390
> Project: DeltaSpike
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>  Components: JSF-Module
>Reporter: Christian Beikov
>Priority: Major
> Fix For: 1.9.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The CLIENTWINDOW handler code loses the window when frames are involved.
> Using e.g. a window scoped bean with the Primefaces Dialog Framework will 
> result in issues. The bean is initialized in window1. A click on a button 
> opens a dialog, which is opened through an iframe, but the dialog doesn't use 
> the window id defined in the parent window. If a button in the dialog 
> requires the original bean, it will find an uninitialized bean, because the 
> frame gets a new window id window2.
> The solution is to use the root window for the window id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)