[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320064#comment-14320064 ] Thomas Andraschko commented on DELTASPIKE-647: -- Fixed by DELTASPIKE-823 and for OWB 1.2.x by OWB-1036 AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117196#comment-14117196 ] Thomas Andraschko commented on DELTASPIKE-647: -- Why do we need a default constructor in OWB? Can we fix it with commons-proxy or do we need to switch to plain ASM? AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100363#comment-14100363 ] Romain Manni-Bucau commented on DELTASPIKE-647: --- we should enhance and use commons-proxy imho since we own the code and don't need any license check AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100667#comment-14100667 ] Gerhard Petracek commented on DELTASPIKE-647: - only +1 if we can shade it in and there is a clear advantage over the owb-proxies which are highly optimized. AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100681#comment-14100681 ] Thomas Andraschko commented on DELTASPIKE-647: -- Can we reuse the owb-proxy logic? Whats the advantage of plain asm vs commons-poxy-asm? AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100697#comment-14100697 ] Gerhard Petracek commented on DELTASPIKE-647: - i haven't looked at the details so far, however, owb-proxies should be more to the point we need (including interceptors). AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101007#comment-14101007 ] Romain Manni-Bucau commented on DELTASPIKE-647: --- @Gerhard: do we shade javassist today? I'm -1 to shade it since we'll depend on [proxy] API but not the impl (asm, javassist, cglib...). This will be up to the user (and one advantage is to not import 10 proxying libs!). asm code is pretty much the same as OWB one (actually the same as openejb). -1000 to reimplement it again in DS which is not the place to get proxies (once again [proxy] is the place - if it is not enough for DS need we can enhance it pretty quickly) AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101081#comment-14101081 ] Gerhard Petracek commented on DELTASPIKE-647: - no we don't shade javassist. if the only choice which really works is commons-proxy-asm, i don't see a reason why we should add an abstraction-layer which just can be used with one impl. AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101084#comment-14101084 ] Romain Manni-Bucau commented on DELTASPIKE-647: --- cause that's not the only solution (cglib should work) and cause this feature is blur enough to work in most cases and be enough for some part of users. AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101100#comment-14101100 ] Mark Struberg commented on DELTASPIKE-647: -- I'm for commons-proxy or an own ASM impl as well. We cannot use the OWB code 1:1 at least. In OWB we do much more optimizations which are not usable in a more generic way. E.g. we cache the created class directly in our ProducerT resp BeanT. When you create dynamic classes you always have to solve the ugly problem with serialization. And this is why we store it directly in our BeanT (or a wrapper for 3rd party Beans). This allows us to do much more optimizations which work even if you have a managed bean + 3 different producer methods (using different qualifiers) for the same bean class. But in DS we just cannot use this trick as we are not so deep inside the container. Thus we need to use much more generic proxies... AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101109#comment-14101109 ] Gerhard Petracek commented on DELTASPIKE-647: - if we can't use those optimizations, we have to think about the interceptors topic. if there is also no difference, i'm ok with commons-proxy. AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100095#comment-14100095 ] Mark Struberg commented on DELTASPIKE-647: -- OWB and Weld work fine in this regard. The problem is that the beanClass created by the PartialBeanExtension is the original abstract class. And this of course does NOT have the willFail() method... The PartialBean system would need to create the 'full' class upfront and use this as bean class. After that any container will be able to properly proxy your instances. AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100117#comment-14100117 ] Mark Struberg commented on DELTASPIKE-647: -- grr, I debugged into it and the ugly truth is that javassist is nuts and generates those 'new' methods as 'final'. Thus we cannot proxy them :( Is there any way we can tell javassist to *not* mark those methods as final? AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100123#comment-14100123 ] Gerhard Petracek commented on DELTASPIKE-647: - we might need to drop javassist and use the same approach as owb itself + the interceptor logic. (also see DELTASPIKE-605) AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: 0001-Failing-PartialBeans-test.patch, DELTASPIKE-647.patch, DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058674#comment-14058674 ] Thomas Andraschko commented on DELTASPIKE-647: -- Is there a chance to get this fixed for the next release Thomas H.? I would owe you a beer someday ;) It's really annoying wrap the repos manually in my app... AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Thomas Hug Attachments: DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058697#comment-14058697 ] Thomas Hug commented on DELTASPIKE-647: --- Wasted too much time trying to make Data work on WebLogic this week, but will try to give this one a spin as well. No promises though as last time I looked into it I left with no clue about the problem ;-). What kind of beer? (just for the motivation... :-)) AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Thomas Hug Attachments: DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040508#comment-14040508 ] Thomas Andraschko commented on DELTASPIKE-647: -- run via mvn jetty:run open test1.xhtml - works as expected with a interface repo open test2.xhtml - Caused by: java.lang.AbstractMethodError: test.TestRepository2.saveAndFlush(Ljava/lang/Object;)Ljava/lang/Object; AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Thomas Hug Attachments: DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-647) AppScoped abstract repositories doesn't work
[ https://issues.apache.org/jira/browse/DELTASPIKE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040561#comment-14040561 ] Thomas Hug commented on DELTASPIKE-647: --- Seems to crash before reaching any Data module code. Could this be related to PartialBeans? AppScoped abstract repositories doesn't work Key: DELTASPIKE-647 URL: https://issues.apache.org/jira/browse/DELTASPIKE-647 Project: DeltaSpike Issue Type: Bug Components: Data-Module Reporter: Thomas Andraschko Assignee: Thomas Hug Attachments: DS-647.7z -- This message was sent by Atlassian JIRA (v6.2#6252)
