[jira] [Created] (DIRSERVER-2233) Apacheds sometimes slow query

2018-04-22 Thread cokuehuang (JIRA)
cokuehuang created DIRSERVER-2233: - Summary: Apacheds sometimes slow query Key: DIRSERVER-2233 URL: https://issues.apache.org/jira/browse/DIRSERVER-2233 Project: Directory ApacheDS Issue

[GitHub] seelmann closed pull request #2: Change the method name "select" to "isSelected".

2018-04-22 Thread GitBox
seelmann closed pull request #2: Change the method name "select" to "isSelected". URL: https://github.com/apache/directory-studio/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] BruceKuiLiu commented on issue #2: Change the method name "select" to "isSelected".

2018-04-22 Thread GitBox
BruceKuiLiu commented on issue #2: Change the method name "select" to "isSelected". URL: https://github.com/apache/directory-studio/pull/2#issuecomment-383412904 You are right, the **select** method name is given by the super class org.eclipse.jface.viewers.ViewerFilter from the Eclipse

[GitHub] seelmann commented on issue #2: Change the method name "select" to "isSelected".

2018-04-22 Thread GitBox
seelmann commented on issue #2: Change the method name "select" to "isSelected". URL: https://github.com/apache/directory-studio/pull/2#issuecomment-383411399 I agree that `isSelected` would be the better name. However the `select` method name is given by the super class

Re: [jira] [Commented] (DIRSTUDIO-1177) Enhance default editor mappings for eDirectory/Identity Manager

2018-04-22 Thread Stefan Seelmann
On 04/19/2018 08:00 AM, Lothar Haeger wrote: >> Stefan Seelmann commented on DIRSTUDIO-1177: >> >> >> Also see https://issues.apache.org/jira/browse/DIRSTUDIO-1002 which proposes >> and implements more eDirectory specific value editors but which would

[GitHub] BruceKuiLiu opened a new pull request #2: Change the method name "select" to "isSelected".

2018-04-22 Thread GitBox
BruceKuiLiu opened a new pull request #2: Change the method name "select" to "isSelected". URL: https://github.com/apache/directory-studio/pull/2 The method is checking whether the "element" is selected or not. But "select" is prone to mean that something will be selected. Thus the