[jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting

2016-04-07 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231453#comment-15231453 ] Jiajia Li commented on DIRKRB-546: -- Thanks for the updating, it looks good to me, +1. > Add super class

[jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting

2016-04-07 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229791#comment-15229791 ] Kai Zheng commented on DIRKRB-546: -- Thanks for the clarifying, Yan. Understood. > Add super class to

[jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting

2016-04-07 Thread YanYan (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229767#comment-15229767 ] YanYan commented on DIRKRB-546: --- Thanks for Kai's comments. There already exist {{getAdminServerConfig}} and

[jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting

2016-04-06 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229611#comment-15229611 ] Kai Zheng commented on DIRKRB-546: -- I think in this context, the word 'kdc' should be 'adminServer'. >

[jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting

2016-04-05 Thread YanYan (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225893#comment-15225893 ] YanYan commented on DIRKRB-546: --- Got it. I'll change the abstract super class into an interface. > Add

[jira] [Commented] (DIRKRB-546) Add super class to AdminSetting and KdcSetting

2016-04-05 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225833#comment-15225833 ] Jiajia Li commented on DIRKRB-546: -- The getKdcRealm() and getKdcConfig() in ServerSetting can be the