Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Kiran Ayyagari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14/#review5 --- Ship it! I would suggest that we confine the usage of beans to config

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Kiran Ayyagari
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Kiran Ayyagari
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread akarasulu
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread akarasulu
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread akarasulu
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread akarasulu
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread akarasulu
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Kiran Ayyagari
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -

Re: Review Request: ApacheDsService.start() method refactoring

2010-10-27 Thread Emmanuel Lécharny
On 2010-10-27 04:38:22, Kiran Ayyagari wrote: I would suggest that we confine the usage of beans to config reader only(even if they can be accessed publicly), cause we need to copy the property values from bean to the corresponding real instance (e.x DirectoryServiceBean -