[GitHub] [directory-scimple] bdemers commented on pull request #44: Import JAXRS common code from PennState/commons-jaxrs
bdemers commented on PR #44: URL: https://github.com/apache/directory-scimple/pull/44#issuecomment-1129456251 NOTE: these bits can likely be merged into the `scim-common` module, keeping separate for now until the TODO items in this PR are resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #37: Bump lombok from 1.18.22 to 1.18.24
bdemers merged PR #37: URL: https://github.com/apache/directory-scimple/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-studio] roubert commented on a diff in pull request #34: DIRSTUDIO-1298: Add address editor UI test
roubert commented on code in PR #34:
URL: https://github.com/apache/directory-studio/pull/34#discussion_r875190111
##
tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java:
##
@@ -567,6 +568,76 @@ public void testTextValueEditor( TestLdapServer server )
throws Exception
}
+/**
+ * DIRSTUDIO-1298: The RFC 4517 Postal Address value editor en-/decoding
is incomplete
+ */
+@ParameterizedTest
+@LdapServersSource
+public void testAddressValueEditor( TestLdapServer server ) throws
Exception
+{
+connectionsViewBot.createTestConnection( server );
+browserViewBot.selectEntry( path( BJENSEN_DN ) );
Review Comment:
Just an idea, not important: Maybe it could have some added value if you
instead began the testing with an entry that already has the `postalAddress`
field set, like eg. _Aaccf Amar_ from the export test, so that you get to first
test that LDAP data gets correctly decoded before going into the added
complications of text entry and encoding.
##
tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java:
##
@@ -567,6 +568,76 @@ public void testTextValueEditor( TestLdapServer server )
throws Exception
}
+/**
+ * DIRSTUDIO-1298: The RFC 4517 Postal Address value editor en-/decoding
is incomplete
+ */
+@ParameterizedTest
+@LdapServersSource
+public void testAddressValueEditor( TestLdapServer server ) throws
Exception
+{
+connectionsViewBot.createTestConnection( server );
+browserViewBot.selectEntry( path( BJENSEN_DN ) );
+
+EntryEditorBot entryEditorBot = studioBot.getEntryEditorBot(
BJENSEN_DN.getName() );
+entryEditorBot.activate();
+String dn = entryEditorBot.getDnText();
+assertEquals( "DN: " + BJENSEN_DN.getName(), dn );
+assertEquals( 8, entryEditorBot.getAttributeValues().size() );
+assertEquals( "", modificationLogsViewBot.getModificationLogsText() );
+
+// add postalAddress attribute and verify value is correctly encoded
+entryEditorBot.activate();
+NewAttributeWizardBot wizardBot =
entryEditorBot.openNewAttributeWizard();
+assertTrue( wizardBot.isVisible() );
+wizardBot.typeAttributeType( "postalAddress" );
+AddressEditorDialogBot addressEditorDialogBot =
wizardBot.clickFinishButtonExpectingAddressEditor();
+assertTrue( addressEditorDialogBot.isVisible() );
+addressEditorDialogBot.setText( "1234 Main St.\nAnytown, CA
12345\nUSA" );
Review Comment:
Is it really correct to use plain `\n` here? I know precious little about
Eclipse RCP but the very existence of such things as
`BrowserCoreConstants.LINE_SEPARATOR` makes me wary and I'd like to make sure
that you're sure that this `setText()` call really is the right way to do it.
##
tests/test.integration.ui/src/main/java/org/apache/directory/studio/test/integration/ui/EntryEditorTest.java:
##
@@ -567,6 +568,76 @@ public void testTextValueEditor( TestLdapServer server )
throws Exception
}
+/**
+ * DIRSTUDIO-1298: The RFC 4517 Postal Address value editor en-/decoding
is incomplete
+ */
+@ParameterizedTest
+@LdapServersSource
+public void testAddressValueEditor( TestLdapServer server ) throws
Exception
+{
+connectionsViewBot.createTestConnection( server );
+browserViewBot.selectEntry( path( BJENSEN_DN ) );
+
+EntryEditorBot entryEditorBot = studioBot.getEntryEditorBot(
BJENSEN_DN.getName() );
+entryEditorBot.activate();
+String dn = entryEditorBot.getDnText();
+assertEquals( "DN: " + BJENSEN_DN.getName(), dn );
+assertEquals( 8, entryEditorBot.getAttributeValues().size() );
+assertEquals( "", modificationLogsViewBot.getModificationLogsText() );
+
+// add postalAddress attribute and verify value is correctly encoded
+entryEditorBot.activate();
+NewAttributeWizardBot wizardBot =
entryEditorBot.openNewAttributeWizard();
+assertTrue( wizardBot.isVisible() );
+wizardBot.typeAttributeType( "postalAddress" );
+AddressEditorDialogBot addressEditorDialogBot =
wizardBot.clickFinishButtonExpectingAddressEditor();
+assertTrue( addressEditorDialogBot.isVisible() );
+addressEditorDialogBot.setText( "1234 Main St.\nAnytown, CA
12345\nUSA" );
+addressEditorDialogBot.clickOkButton();
+assertEquals( 9, entryEditorBot.getAttributeValues().size() );
+assertTrue(
+entryEditorBot.getAttributeValues().contains( "postalAddress: 1234
Main St., Anytown, CA 12345, USA" ) );
+modificationLogsViewBot.waitForText( "add:
postalAddress\npostalAddress: 1234 Main St.$Anytown, CA 12345$USA" );
+
+// verify value is correctly decoded
+addressEditorDialogBot =
[GitHub] [directory-scimple] bdemers opened a new pull request, #44: Import JAXRS common code from PennState/commons-jaxrs
bdemers opened a new pull request, #44: URL: https://github.com/apache/directory-scimple/pull/44 TODO: find out if this project went through copyright transfer process, if a NOTICE file may need to be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #34: Bump zjsonpatch from 0.4.4 to 0.4.12
bdemers merged PR #34: URL: https://github.com/apache/directory-scimple/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #36: Bump mockito-junit-jupiter from 4.4.0 to 4.5.1
bdemers merged PR #36: URL: https://github.com/apache/directory-scimple/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #38: Bump jacoco-maven-plugin from 0.8.7 to 0.8.8
bdemers merged PR #38: URL: https://github.com/apache/directory-scimple/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #39: Bump jackson-bom from 2.13.2.1 to 2.13.3
bdemers merged PR #39: URL: https://github.com/apache/directory-scimple/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #40: Bump tomee-maven-plugin from 1.7.1 to 1.7.5
bdemers merged PR #40: URL: https://github.com/apache/directory-scimple/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #41: Bump guava from 31.0.1-android to 31.1-android
bdemers merged PR #41: URL: https://github.com/apache/directory-scimple/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #42: Bump nexus-staging-maven-plugin from 1.6.12 to 1.6.13
bdemers merged PR #42: URL: https://github.com/apache/directory-scimple/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #43: Consolidate Jackson ObjectMapper creation logic
bdemers merged PR #43: URL: https://github.com/apache/directory-scimple/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] bdemers opened a new pull request, #43: Consolidate Jackson ObjectMapper creation logic
bdemers opened a new pull request, #43: URL: https://github.com/apache/directory-scimple/pull/43 DRY out creation of ObjectMapper. This could be cleaned up further, but creation of ObjectMappers happen in a single place so it should be easier to trace down -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-studio] seelmann merged pull request #34: DIRSTUDIO-1298: Add address editor UI test
seelmann merged PR #34: URL: https://github.com/apache/directory-studio/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Updated] (DIRSTUDIO-1298) The RFC 4517 Postal Address value editor en-/decoding is incomplete
[ https://issues.apache.org/jira/browse/DIRSTUDIO-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seelmann updated DIRSTUDIO-1298: --- Fix Version/s: 2.0.0-M18 > The RFC 4517 Postal Address value editor en-/decoding is incomplete > --- > > Key: DIRSTUDIO-1298 > URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1298 > Project: Directory Studio > Issue Type: Bug > Components: studio-ldapbrowser >Affects Versions: 2.0.0-M17 >Reporter: Fredrik Roubert >Priority: Major > Fix For: 2.0.0-M18 > > > The current implementation only handles newlines but not the other two > (dollar sign and backslash) character for which RFC 4517 specifies an > encoding, meaning that it can't handle addresses containing these characters. > These characters are rare in real life postal addresses (even though the RFC > contains a somewhat convincing example address) and this is probably the > reason for why no-one else has cared until now, but it would still be better > to implement the standard correctly than incompletely. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-studio] seelmann commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.
seelmann commented on PR #33: URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1128453433 > It would (of course) be nice to have an integration test also for the `AddressDialog`, but as far as I can tell there aren't any existing tests for those dialogs I created a test, please adjust as needed: https://github.com/apache/directory-studio/pull/34 > I fear that writing one from scratch myself would be beyond my capabilities. I have to disagree :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
