[GitHub] incubator-distributedlog pull request #130: DL-199: Be able to support files...

2017-05-19 Thread jiazhai
Github user jiazhai commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/130#discussion_r117600405 --- Diff: distributedlog-core/src/test/java/org/apache/distributedlog/TestBKDistributedLogNamespace.java --- @@ -143,7 +172,7 @@ public v

[GitHub] incubator-distributedlog pull request #130: DL-199: Be able to support files...

2017-05-19 Thread jiazhai
Github user jiazhai commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/130#discussion_r117600348 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/util/DLUtils.java --- @@ -281,41 +281,89 @@ public static boolean i

[GitHub] incubator-distributedlog pull request #130: DL-199: Be able to support files...

2017-05-19 Thread jiazhai
Github user jiazhai commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/130#discussion_r117600036 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/util/DLUtils.java --- @@ -281,41 +281,89 @@ public static boolean i