[GitHub] incubator-distributedlog pull request #88: DL-155 : fix flaky TestAsyncReade...

2016-12-22 Thread xieliang
GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/88 DL-155 : fix flaky TestAsyncReaderLock#testReaderLockMultiReadersScenario Ran the case with changed patch 30 times, all are passed; and it'll fail w/o patch You can merge this p

[jira] [Updated] (DL-155) TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky

2016-12-22 Thread Liang Xie (JIRA)
[ https://issues.apache.org/jira/browse/DL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Xie updated DL-155: - Affects Version/s: 0.4.0 > TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky > -

[jira] [Commented] (DL-155) TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky

2016-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/DL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769519#comment-15769519 ] ASF GitHub Bot commented on DL-155: --- GitHub user xieliang opened a pull request: https:

Re: Is there a REST API for Write and Read proxies?

2016-12-22 Thread Asko Kauppi
Hi Jay, > One comment about "a REST / websockets proxy", are you thinking of running > a separate service or part of current proxy (e.g. listening on a separate > port to handle REST/websockets request)? I was thinking of a separate service, and a separate project, at least first. I work in Sca

Re: Request wiki edit permissions

2016-12-22 Thread Jay Juma
Sijie, My wiki handle is jayk.juma. https://cwiki.apache.org/confluence/display/~jayk.juma Thanks in advance. - Jay On Thu, Dec 15, 2016 at 11:35 AM, Sijie Guo wrote: > Jay, > > what is your wiki handle? > > - Sijie > > On Wed, Dec 14, 2016 at 6:26 PM, Jay Juma wrote: > > > Hi, > > > > I'd

What's the 'name' parameter for opening a Write Proxy Client?

2016-12-22 Thread Asko Kauppi
In http://distributedlog.incubator.apache.org/docs/latest/tutorials/basic-2.html DistributedLogClientBuilder builder = DistributedLogClientBuilder.newBuilder(); .clientId(ClientId.apply("console-proxy-writer"

[GitHub] incubator-distributedlog pull request #89: DL-132: Enable check style for di...

2016-12-22 Thread xiliuant
GitHub user xiliuant opened a pull request: https://github.com/apache/incubator-distributedlog/pull/89 DL-132: Enable check style for distributedlog service module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xiliuant/incubat

Re: What's the 'name' parameter for opening a Write Proxy Client?

2016-12-22 Thread Sijie Guo
Re "client id and name" Client Id is the identifier used by finagle-thrift to identify "who" is sending the request. The client id can then be used by the thrift proxy server to reject unknown clients optionally. ( http://www.rubydoc.info/gems/finagle-thrift/1.4.1/FinagleThrift/ClientId) The name

Re: Request wiki edit permissions

2016-12-22 Thread Sijie Guo
Done. - Sijie On Thu, Dec 22, 2016 at 12:59 AM, Jay Juma wrote: > Sijie, > > My wiki handle is jayk.juma. > > https://cwiki.apache.org/confluence/display/~jayk.juma > > Thanks in advance. > > - Jay > > On Thu, Dec 15, 2016 at 11:35 AM, Sijie Guo > wrote: > > > Jay, > > > > what is your wiki ha

Re: Is there a REST API for Write and Read proxies?

2016-12-22 Thread Sijie Guo
On Thu, Dec 22, 2016 at 12:58 AM, Asko Kauppi wrote: > Hi Jay, > > > One comment about "a REST / websockets proxy", are you thinking of > running > > a separate service or part of current proxy (e.g. listening on a separate > > port to handle REST/websockets request)? > > > I was thinking of a se

Re: Is there a REST API for Write and Read proxies?

2016-12-22 Thread Asko Kauppi
I appreciate that, Sijie, but in practise I think the tooling would collide. I am most productive in Scala and akka-http, and I think those are a good platform for the future. Doing something HTTP and Websocket based in Java is outside of my experience, and willingness. While merging the two to

[GitHub] incubator-distributedlog issue #85: DL-153: typo in distributedlog-benchmark...

2016-12-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/85 The change looks good to me. +1 Thank you @jayk-juma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-distributedlog issue #78: DL-145 : the write requests should be er...

2016-12-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/78 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog issue #86: DL-17: Ledger allocator pool should be a...

2016-12-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/86 Awesome, @jayk-juma ! Thank you for the contribution. This is really good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-distributedlog issue #88: DL-155 : fix flaky TestAsyncReaderLock#t...

2016-12-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/88 The change looks good to me, +1. Thanks @xieliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-distributedlog issue #90: DL-133: Enable check style for distribut...

2016-12-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/90 Great job, @xiliuant ! The patch looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-distributedlog issue #87: DL-131: Enable checkstyle for distribute...

2016-12-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/87 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so