[GitHub] incubator-distributedlog pull request #97: DL-170: All dependency versions s...

2017-01-05 Thread gerritsundaram
GitHub user gerritsundaram opened a pull request: https://github.com/apache/incubator-distributedlog/pull/97 DL-170: All dependency versions should be defined in the parent pom make all dependencies' version be defined in the parent pom file. You can merge this pull request into a G

[GitHub] incubator-distributedlog pull request #98: DL-171 : adding a short sleep to ...

2017-01-05 Thread xieliang
GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/98 DL-171 : adding a short sleep to let the WriteCompleteListener have time to run before the final position be requested once the "writer.write" is done, if "writer.position()" be in

[GitHub] incubator-distributedlog pull request #99: DL-172: Provide a IDL definition ...

2017-01-05 Thread gerritsundaram
GitHub user gerritsundaram opened a pull request: https://github.com/apache/incubator-distributedlog/pull/99 DL-172: Provide a IDL definition for stream metadata and segment meta… https://issues.apache.org/jira/browse/DL-172 You can merge this pull request into a Git repository by

Re: [Review] The first release of Apache DistributedLog

2017-01-05 Thread Asko Kauppi
Hi Sijie, most readers will likely not know about DistributedLog. A short comparison - or a link to one - e.g. with Kafka might help set the stage for them. i.e. why does it exist? This is even more important since Uber recently also publicized their persistent message bus solution. If these star

[GitHub] incubator-distributedlog issue #99: DL-172: Provide a IDL definition for str...

2017-01-05 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/99 @gerritsundaram looks like a findbugs warming. you might consider excluding the generated code. regarding whether using thrift or protobuf, can you raise a discussion email th

[GitHub] incubator-distributedlog issue #98: DL-171 : adding a short sleep to let the...

2017-01-05 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/98 looks good to me. it is okay for a short term fix. moving forward, we might consider how to improve the test in general to make them time independent. +1 --- If your project

[GitHub] incubator-distributedlog issue #96: DL-83: Add javadoc to website

2017-01-05 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/96 @mgodave @leighst need this for generating the javadoc for the release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-distributedlog issue #97: DL-170: All dependency versions should b...

2017-01-05 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/97 I liked the change of managing the versions in a central place. great contribution! @gerritsundaram +1 --- If your project is set up for it, you can reply to this email and

Re: [Discuss] Transaction Support

2017-01-05 Thread Sijie Guo
On Wed, Jan 4, 2017 at 1:14 AM, Asko Kauppi wrote: > > Beside that, I have one general question - What is the major goal for > this > > feature? Are you targeting on building a general XA transaction > coordinator > > or just for supporting things like `copy-modify-write' style workflow? > > The

Re: [Discuss] Transaction Support

2017-01-05 Thread Sijie Guo
Xi, I added more comments. We are looking forward to your reply and seeing this happen. - Sijie On Tue, Jan 3, 2017 at 11:18 PM, Sijie Guo wrote: > Sorry for late response. I think Leigh and you already had some very > valuable discussions in the doc. I will try to add some of my questions to >

[GitHub] incubator-distributedlog pull request #100: DL-28: changed // comments to /*...

2017-01-05 Thread adamtracymartin
GitHub user adamtracymartin opened a pull request: https://github.com/apache/incubator-distributedlog/pull/100 DL-28: changed // comments to /* */ You can merge this pull request into a Git repository by running: $ git pull https://github.com/adamtracymartin/incubator-distribu

Re: [Review] The first release of Apache DistributedLog

2017-01-05 Thread Enrico Olivelli
Hi Sijie, I am following this release and the great work DL comunity is doing. Maybe it would be worth to write some paragraph about the difference from BookKeeper and/or the relation with it. Enrico Il gio 5 gen 2017, 19:13 Asko Kauppi ha scritto: > Hi Sijie, > > most readers will likely not

[GitHub] incubator-distributedlog pull request #101: DL-173: changed FileUtiles.delet...

2017-01-05 Thread adamtracymartin
GitHub user adamtracymartin opened a pull request: https://github.com/apache/incubator-distributedlog/pull/101 DL-173: changed FileUtiles.deleteDirectory to FileUtiles.forceDeleteOnExit so files would delete on Windows You can merge this pull request into a Git repository by runni

[GitHub] incubator-distributedlog pull request #101: DL-173: changed FileUtiles.delet...

2017-01-05 Thread adamtracymartin
Github user adamtracymartin closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog issue #95: DL-4: Add repackaging script

2017-01-05 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/95 oops I think we need to change the artifact name too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-distributedlog pull request #102: DL-176: Rename the DL artifact f...

2017-01-05 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/102 DL-176: Rename the DL artifact from com.twitter to org.apache.distributedlog You can merge this pull request into a Git repository by running: $ git pull https://github.com/sij

Re: [Review] The first release of Apache DistributedLog

2017-01-05 Thread Sijie Guo
Thank you for your suggestion, Asko. Try to make the announcement post shorter and keep it focused on release. Will try to prepare another post for education. - Sijie On Thu, Jan 5, 2017 at 10:13 AM, Asko Kauppi wrote: > Hi Sijie, > > most readers will likely not know about DistributedLog. A

Re: [Review] The first release of Apache DistributedLog

2017-01-05 Thread Sijie Guo
Cool to see you here, Enrico. And thank you for your suggestion. I will try to write a separate one for DL and BK. Try to keep this one focus on a short release post. - Sijie On Thu, Jan 5, 2017 at 1:43 PM, Enrico Olivelli wrote: > Hi Sijie, > I am following this release and the great work DL

[GitHub] incubator-distributedlog pull request #103: DL-173: changed FileUtils.delete...

2017-01-05 Thread adamtracymartin
GitHub user adamtracymartin opened a pull request: https://github.com/apache/incubator-distributedlog/pull/103 DL-173: changed FileUtils.deleteDirectory to FileUtils.forceDeleteOnExit so directory will delete on Windows. You can merge this pull request into a Git repository by run

[GitHub] incubator-distributedlog pull request #104: DL-174: added getParent method t...

2017-01-05 Thread adamtracymartin
GitHub user adamtracymartin opened a pull request: https://github.com/apache/incubator-distributedlog/pull/104 DL-174: added getParent method to Utils to replace usage of File.getParent which changes / to \ on Windows …ich changes / to \ in Windows. You can merge this pull reques

[GitHub] incubator-distributedlog pull request #105: DL-152: removed symlink distribu...

2017-01-05 Thread adamtracymartin
GitHub user adamtracymartin opened a pull request: https://github.com/apache/incubator-distributedlog/pull/105 DL-152: removed symlink distributedlog-service/conf and copied files from distributedlog-core/conf to distributed-service/conf …tributedlog-core/conf to distributedlog-se

[GitHub] incubator-distributedlog issue #99: DL-172: Provide a IDL definition for str...

2017-01-05 Thread gerritsundaram
Github user gerritsundaram commented on the issue: https://github.com/apache/incubator-distributedlog/pull/99 @sijie sorry my bad. exclude the generated files from findbugs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-distributedlog issue #99: DL-172: Provide a IDL definition for str...

2017-01-05 Thread gerritsundaram
Github user gerritsundaram commented on the issue: https://github.com/apache/incubator-distributedlog/pull/99 @sijie will start a discussion thread for the protobuf. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[DISCUSS] using protobuf than thrift

2017-01-05 Thread Gerrit Sundaram
Hello all, for the comment in https://github.com/apache/incubator-distributedlog/pull/99, I am starting this email thread for discussing using protobuf to store metadata for ease extension. I have a few reasons for using protobuf rather than using thrift: - bookkeeper is using protobuf for stori

Re: [DISCUSS] using protobuf than thrift

2017-01-05 Thread Gerrit Sundaram
Sijie, sorry. I typed your name in the wrong line. was planning to mention since you raised the comment in the pull request. On Thu, Jan 5, 2017 at 10:29 PM, Gerrit Sundaram wrote: > Hello all, > > for the comment in https://github.com/apache/ > incubator-distributedlog/pull/99, I am starting th

Re: [Discuss] Transaction Support

2017-01-05 Thread Xi Liu
Asko and Sijie, Thank you so much for your feedbacks. We are not targeting at building a general XA transaction coordinator. The feature we want is be able to write data to multiple log streams in an atomic way. I totally agreed with you about building minimal logic. We also don't want to enforc

Re: [Review] The first release of Apache DistributedLog

2017-01-05 Thread Xi Liu
It would be great to include any performance numbers. On Thu, Jan 5, 2017 at 5:51 PM, Sijie Guo wrote: > Cool to see you here, Enrico. And thank you for your suggestion. > > I will try to write a separate one for DL and BK. Try to keep this one > focus on a short release post. > > - Sijie > > On

Re: vote process for proposals?

2017-01-05 Thread Xi Liu
I think there is not a lot of activities on proposals. A 'lazy approval' might be just good enough - a proposal with lazy approval is implicitly allowed/accepted unless a -1 vote is received. That's probably the best for now. what do you think? On Wed, Jan 4, 2017 at 12:50 AM, Sijie Guo wrote:

Re: [DISCUSS] using protobuf than thrift

2017-01-05 Thread Khurrum Nasim
one question - bk is using protobuf 2.x while gRPC is using 3.x. IMO, they are not backward compatible. Are you also considering moving bk's protobuf to 3.x? On Thu, Jan 5, 2017 at 10:29 PM, Gerrit Sundaram wrote: > Hello all, > > for the comment in > https://github.com/apache/incubator-distribu