[VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

2017-06-08 Thread Sijie Guo
( /cc bookkeeper dev@ and incubator general@ for awareness ) Hi all, There was a joint discussion between BookKeeper PMC and DistributedLog PPMC about moving the development of DistributedLog as part of Apache BookKeeper. The reasons behind it are: First, DistributedLog is born as an extension t

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

2017-06-08 Thread John D. Ament
Sije, Can you provide links to the PPMC and PMC votes going on for this move? John On Thu, Jun 8, 2017 at 8:21 PM Sijie Guo wrote: > ( /cc bookkeeper dev@ and incubator general@ for awareness ) > > Hi all, > > There was a joint discussion between BookKeeper PMC and DistributedLog PPMC > about

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

2017-06-08 Thread Sijie Guo
Sure. The discussion email thread between BookKeeper PMC and DistributedLog PPMC: https://mail-search.apache.org/pmc/private-arch/bookkeeper-private/201706.mbox/%3ccao2ydyzu+r1eaepyhzufxe_w0qakhnyxnnmn5+zx6q520uz...@mail.gmail.com%3E The BookKeeper PMC VOTE email thread (it is still ongoing): htt

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

2017-06-08 Thread John D. Ament
On Thu, Jun 8, 2017 at 8:44 PM Sijie Guo wrote: > Sure. > > The discussion email thread between BookKeeper PMC and DistributedLog PPMC: > > https://mail-search.apache.org/pmc/private-arch/bookkeeper-private/201706.mbox/%3ccao2ydyzu+r1eaepyhzufxe_w0qakhnyxnnmn5+zx6q520uz...@mail.gmail.com%3E > > T

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

2017-06-08 Thread Sijie Guo
On Thu, Jun 8, 2017 at 5:47 PM, John D. Ament wrote: > On Thu, Jun 8, 2017 at 8:44 PM Sijie Guo wrote: > > > Sure. > > > > The discussion email thread between BookKeeper PMC and DistributedLog > PPMC: > > > > https://mail-search.apache.org/pmc/private-arch/ > bookkeeper-private/201706.mbox/%3CCA

[GitHub] incubator-distributedlog issue #133: DL-124: Use Java8 Future rather than tw...

2017-06-08 Thread leighst
Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/133 Is there some way we can make migration easier? We're going to have to do a lot of translation to twitter futures when we integrate. Should we be thinking about some kind of adapter

[GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...

2017-06-08 Thread leighst
Github user leighst commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/133#discussion_r121046543 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/util/Utils.java --- @@ -635,4 +631,80 @@ public static String getPar

[GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...

2017-06-08 Thread leighst
Github user leighst commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/133#discussion_r121046009 --- Diff: distributedlog-benchmark/pom.xml --- @@ -27,12 +27,12 @@ org.apache.distributedlog - distri

[GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...

2017-06-08 Thread leighst
Github user leighst commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/133#discussion_r121046188 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/BKLogReadHandler.java --- @@ -201,33 +183,31 @@ public void safeRun

[GitHub] incubator-distributedlog pull request #130: DL-199: Be able to support files...

2017-06-08 Thread leighst
Github user leighst commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/130#discussion_r121047018 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/util/Utils.java --- @@ -635,4 +636,16 @@ public static String getPar

[GitHub] incubator-distributedlog issue #132: DL-204: Bump libthrift to latest versio...

2017-06-08 Thread leighst
Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/132 Is this version back compatible with the finagle version? Do we still use old thrift in proxy-server? Etc.? Whats the long term plan here? Should we get rid of hard dependency

[GitHub] incubator-distributedlog pull request #130: DL-199: Be able to support files...

2017-06-08 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/130#discussion_r121057253 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/util/Utils.java --- @@ -635,4 +636,16 @@ public static String getParen

[GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...

2017-06-08 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/133#discussion_r121057495 --- Diff: distributedlog-benchmark/pom.xml --- @@ -27,12 +27,12 @@ org.apache.distributedlog - distribu

[GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...

2017-06-08 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/133#discussion_r121057575 --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/BKLogReadHandler.java --- @@ -201,33 +183,31 @@ public void safeRun()

[GitHub] incubator-distributedlog issue #133: DL-124: Use Java8 Future rather than tw...

2017-06-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/133 @leighst : let's discuss this tomorrow face to face. I am thinking of a new api with java8 future that works for both core-library and proxy. that means the way to distinguish core an

[GitHub] incubator-distributedlog issue #132: DL-204: Bump libthrift to latest versio...

2017-06-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/132 @leighst : it is format backward compatible, but not binary compatible. I only change the library in distributedlog-core and shade it. The other modules - proxy-protocol, proxy-client

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

2017-06-08 Thread Sijie Guo
(dropping general@) - Sijie On Thu, Jun 8, 2017 at 5:21 PM, Sijie Guo wrote: > ( /cc bookkeeper dev@ and incubator general@ for awareness ) > > Hi all, > > There was a joint discussion between BookKeeper PMC and DistributedLog > PPMC about moving the development of DistributedLog as part of Apa